openstack/python-cinderclient
Code Issues Proposed changes

Fix error in unit testcase

Browse Source 
'ddt.data' decorator is wrongly used in 'test_volumes.py',
correct it.

Change-Id: Ib60c4cad33c071f52391fcfa227ed29482ad9445
This commit is contained in:
TommyLike
2017-06-12 11:19:46 +08:00
parent 44e650a4ed
commit 32ce22c744
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cinderclient/tests/unit/v3/test_volumes.py
View File

@@ -27,7 +27,7 @@ from six.moves.urllib import parse
cs = fakes.FakeClient() cs = fakes.FakeClient()
@ddt.data @ddt.ddt
class VolumesTest(utils.TestCase): class VolumesTest(utils.TestCase):
def test_volume_manager_upload_to_image(self): def test_volume_manager_upload_to_image(self):
@@ -107,7 +107,7 @@ class VolumesTest(utils.TestCase):
@ddt.data(True, False) @ddt.data(True, False)
def test_get_pools_filter_by_name(self, detail): def test_get_pools_filter_by_name(self, detail):
cs = fakes.FakeClient(api_version=api_versions.APIVersion('3.33')) cs = fakes.FakeClient(api_version=api_versions.APIVersion('3.33'))
vol = cs.volumes.get_pools(detail, 'pool1') vol = cs.volumes.get_pools(detail, {'name': 'pool1'})
request_url = '/scheduler-stats/get_pools?name=pool1' request_url = '/scheduler-stats/get_pools?name=pool1'
if detail: if detail:
request_url = '/scheduler-stats/get_pools?detail=True&name=pool1' request_url = '/scheduler-stats/get_pools?detail=True&name=pool1'