openstack/python-cinderclient
Code Issues Proposed changes

Update notes for submitted changes

Browse Source 
* The is_public filter in VolumeTypeManager.list broke the find in VolumeTypeAccessManager, which caused all commands which should have taken a volume_type name to fail.  I have choosen to fix this by effectively removing the filter in the client (and the --all argument to type-list). This is OK, since Cinder implements the filtering by user anyway.  The consequence of this change is that the Admin user will always see the entire list (including private types) every time they execute type-list
This commit is contained in:
Gerrit Code Review
2015-06-16 19:06:52 +00:00
parent 778088810c
commit 55941f65b9
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
28/9ab37c790b8848e78582926c336628ca51ca6d Normal file
View File

@@ -0,0 +1,11 @@
Verified+2: Jenkins
Code-Review+2: Mike Perez <thingee@gmail.com>
Workflow+1: Mike Perez <thingee@gmail.com>
Code-Review+2: John Griffith <john.griffith8@gmail.com>
Code-Review+1: Patrick East <patrick.east@purestorage.com>
Code-Review+1: Yuriy Nesenenko <ynesenenko@mirantis.com>
Submitted-by: Jenkins
Submitted-at: Tue, 16 Jun 2015 19:06:52 +0000
Reviewed-on: https://review.openstack.org/191621
Project: openstack/python-cinderclient
Branch: refs/heads/master