openstack/python-cinderclient
Code Issues Proposed changes

Fix typo in cinderclient

Browse Source 
sematics --> semantics
hypen-separated --> hyphen-separated
typicaly --> typically

Change-Id: I5df277ef7036082d0e4b079c23d41da809e5270f
Closes-Bug: #1254587
This commit is contained in:
huangtianhua
2013-11-25 18:08:01 +08:00
parent e8a0e6abdf
commit 5aaa68f09e
4 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cinderclient/base.py
View File

@@ -110,7 +110,7 @@ class Manager(utils.HookableMixin):
try: try:
os.makedirs(cache_dir, 0o755) os.makedirs(cache_dir, 0o755)
except OSError: except OSError:
# NOTE(kiall): This is typicaly either permission denied while # NOTE(kiall): This is typically either permission denied while
# attempting to create the directory, or the directory # attempting to create the directory, or the directory
# already exists. Either way, don't fail. # already exists. Either way, don't fail.
pass pass
@@ -124,7 +124,7 @@ class Manager(utils.HookableMixin):
try: try:
setattr(self, cache_attr, open(path, mode)) setattr(self, cache_attr, open(path, mode))
except IOError: except IOError:
# NOTE(kiall): This is typicaly a permission denied while # NOTE(kiall): This is typically a permission denied while
# attempting to write the cache file. # attempting to write the cache file.
pass pass

2
cinderclient/shell.py
View File

@@ -298,7 +298,7 @@ class OpenStackCinderShell(object):
def _find_actions(self, subparsers, actions_module): def _find_actions(self, subparsers, actions_module):
for attr in (a for a in dir(actions_module) if a.startswith('do_')): for attr in (a for a in dir(actions_module) if a.startswith('do_')):
# I prefer to be hypen-separated instead of underscores. # I prefer to be hyphen-separated instead of underscores.
command = attr[3:].replace('_', '-') command = attr[3:].replace('_', '-')
callback = getattr(actions_module, attr) callback = getattr(actions_module, attr)
desc = callback.__doc__ or '' desc = callback.__doc__ or ''

2
cinderclient/utils.py
View File

@@ -56,7 +56,7 @@ def add_arg(f, *args, **kwargs):
# NOTE(sirp): avoid dups that can occur when the module is shared across # NOTE(sirp): avoid dups that can occur when the module is shared across
# tests. # tests.
if (args, kwargs) not in f.arguments: if (args, kwargs) not in f.arguments:
# Because of the sematics of decorator composition if we just append # Because of the semantics of decorator composition if we just append
# to the options list positional options will appear to be backwards. # to the options list positional options will appear to be backwards.
f.arguments.insert(0, (args, kwargs)) f.arguments.insert(0, (args, kwargs))

1
doc/source/index.rst
View File

@@ -32,6 +32,7 @@ Release Notes
MASTER MASTER
------ ------
.. _1254951: http://bugs.launchpad.net/python-cinderclient/+bug/1254951 .. _1254951: http://bugs.launchpad.net/python-cinderclient/+bug/1254951
.. _1254587: http://bugs.launchpad.net/python-cinderclient/+bug/1254587
1.0.7 1.0.7
----- -----