openstack/python-cinderclient
Code Issues Proposed changes

Remove the mutable default arguments "[]"

Browse Source 
Remove the default arguments "[]" when the function is defined.

Ref: http://docs.python-guide.org/en/latest/writing/gotchas/

Change-Id: I92340596a6c9d1489b428b23adbfbddf2c5f4e59
This commit is contained in:
Shaojiang Deng 2015-12-18 10:45:30 +08:00
parent 614e6a380c
commit 6305abbbf8
1 changed files with 3 additions and 1 deletions

4
cinderclient/openstack/common/apiclient/fake_client.py

@ -33,7 +33,9 @@ from six.moves.urllib import parse
from cinderclient.openstack.common.apiclient import client
def assert_has_keys(dct, required=[], optional=[]):
def assert_has_keys(dct, required=None, optional=None):
required = required or []
optional = optional or []
for k in required:
try:
assert k in dct