openstack/python-cinderclient
Code Issues Proposed changes

Remove useless args in create_group_from_src

Browse Source 
Remove status, project_id
and user_id args from create_group_from_src.

Those args will cause error when using cinderclient since
schema validation in Cinder side.

Change-Id: Iba9a45625f9e6423e8e582425605ca184238cde9
Closes-Bug: #1772375
This commit is contained in:
wanghao
2018-05-21 17:01:35 +08:00
parent 3f6aa2a648
commit 7283dedb13
3 changed files with 1 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cinderclient/tests/unit/v3/test_groups.py
View File

@@ -128,12 +128,9 @@ class GroupsTest(utils.TestCase):
grp = cs.groups.create_from_src('5678', None, name='group') grp = cs.groups.create_from_src('5678', None, name='group')
expected = { expected = {
'create-from-src': { 'create-from-src': {
'status': 'creating',
'description': None, 'description': None,
'user_id': None,
'name': 'group', 'name': 'group',
'group_snapshot_id': '5678', 'group_snapshot_id': '5678',
'project_id': None,
'source_group_id': None 'source_group_id': None
} }
} }
@@ -146,12 +143,9 @@ class GroupsTest(utils.TestCase):
grp = cs.groups.create_from_src(None, '5678', name='group') grp = cs.groups.create_from_src(None, '5678', name='group')
expected = { expected = {
'create-from-src': { 'create-from-src': {
'status': 'creating',
'description': None, 'description': None,
'user_id': None,
'name': 'group', 'name': 'group',
'source_group_id': '5678', 'source_group_id': '5678',
'project_id': None,
'group_snapshot_id': None 'group_snapshot_id': None
} }
} }

3
cinderclient/tests/unit/v3/test_shell.py
View File

@@ -680,9 +680,6 @@ class ShellTest(utils.TestCase):
def test_group_create_from_src(self, grp_snap_id, src_grp_id, src): def test_group_create_from_src(self, grp_snap_id, src_grp_id, src):
expected = {'create-from-src': {'name': 'test-1', expected = {'create-from-src': {'name': 'test-1',
'description': 'test-1-desc', 'description': 'test-1-desc',
'user_id': None,
'project_id': None,
'status': 'creating',
'group_snapshot_id': grp_snap_id, 'group_snapshot_id': grp_snap_id,
'source_group_id': src_grp_id}} 'source_group_id': src_grp_id}}
cmd = ('--os-volume-api-version 3.14 ' cmd = ('--os-volume-api-version 3.14 '

5
cinderclient/v3/groups.py
View File

@@ -114,10 +114,7 @@ class GroupManager(base.ManagerWithFind):
body = {'create-from-src': {'name': name, body = {'create-from-src': {'name': name,
'description': description, 'description': description,
'group_snapshot_id': group_snapshot_id, 'group_snapshot_id': group_snapshot_id,
'source_group_id': source_group_id, 'source_group_id': source_group_id, }}
'user_id': user_id,
'project_id': project_id,
'status': "creating", }}
self.run_hooks('modify_body_for_action', body, self.run_hooks('modify_body_for_action', body,
'create-from-src') 'create-from-src')