openstack
/
python-cinderclient
Code Issues Proposed changes

Update revert_to_snapshot params 

In revert_to_snapshot method, snapshot param must be a object and
also has 'id' attribute, so before use the method, we have to use
snapshot.get method to get snapshot information.

But revert_to_snaoshot only use id of snapshot, we can use snapshot
instead of snapshot.id.

Change-Id: Ifbdbae3ee66d72f9d34cf4a8fdf2bde388b2b6f0
This commit is contained in:
Armstrong Liu 2019-12-13 11:43:23 +08:00 committed by Armstrong Liu
parent d240091c32
commit 8f12b620a0
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cinderclient/v3/volumes.py
View File

@ -129,11 +129,11 @@ class VolumeManager(volumes.VolumeManager):
"""Revert a volume to a snapshot. """Revert a volume to a snapshot.
The snapshot must be the most recent one known to cinder. The snapshot must be the most recent one known to cinder.
:param volume: volume object. :param volume: volume object or volume id.
:param snapshot: snapshot object. :param snapshot: snapshot object or snapshot id.
""" """
return self._action('revert', volume, return self._action('revert', volume,
info={'snapshot_id': base.getid(snapshot.id)}) info={'snapshot_id': base.getid(snapshot)})
@api_versions.wraps('3.12') @api_versions.wraps('3.12')
def summary(self, all_tenants): def summary(self, all_tenants):