openstack/python-cinderclient
Code Issues Proposed changes

Fixes quota-class-update commands

Browse Source 
The quota-class-update commands for v1 and v2 are both broken,
Fix v1 by returning result for update method in QuotaClassSetManager,
fix v2 by changing arg 'class-name' to 'class_name' for consistent
with v1.

Change-Id: Ic7188f485b914dc55048cf056a0685618134e87a
Closes-bug: #1423884
This commit is contained in:
liyingjun
2015-03-02 16:01:34 +08:00
parent ae9dd86093
commit 9db3430ccd
3 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cinderclient/v1/quota_classes.py
View File

@@ -26,7 +26,7 @@ class QuotaClassSet(base.Resource):
return self.class_name return self.class_name
def update(self, *args, **kwargs): def update(self, *args, **kwargs):
self.manager.update(self.class_name, *args, **kwargs) return self.manager.update(self.class_name, *args, **kwargs)
class QuotaClassSetManager(base.Manager): class QuotaClassSetManager(base.Manager):
@@ -42,4 +42,6 @@ class QuotaClassSetManager(base.Manager):
for update in updates: for update in updates:
body['quota_class_set'][update] = updates[update] body['quota_class_set'][update] = updates[update]
self._update('/os-quota-class-sets/%s' % (class_name), body) result = self._update('/os-quota-class-sets/%s' % (class_name), body)
return self.resource_class(self,
result['quota_class_set'], loaded=True)

6
cinderclient/v2/quota_classes.py
View File

@@ -24,7 +24,7 @@ class QuotaClassSet(base.Resource):
return self.class_name return self.class_name
def update(self, *args, **kwargs): def update(self, *args, **kwargs):
self.manager.update(self.class_name, *args, **kwargs) return self.manager.update(self.class_name, *args, **kwargs)
class QuotaClassSetManager(base.Manager): class QuotaClassSetManager(base.Manager):
@@ -40,4 +40,6 @@ class QuotaClassSetManager(base.Manager):
for update in updates: for update in updates:
body['quota_class_set'][update] = updates[update] body['quota_class_set'][update] = updates[update]
self._update('/os-quota-class-sets/%s' % (class_name), body) result = self._update('/os-quota-class-sets/%s' % (class_name), body)
return self.resource_class(self,
result['quota_class_set'], loaded=True)

4
cinderclient/v2/shell.py
View File

@@ -997,8 +997,8 @@ def do_quota_class_show(cs, args):
_quota_show(cs.quota_classes.get(args.class_name)) _quota_show(cs.quota_classes.get(args.class_name))
@utils.arg('class-name', @utils.arg('class_name',
metavar='<class-name>', metavar='<class_name>',
help='Name of quota class for which to set quotas.') help='Name of quota class for which to set quotas.')
@utils.arg('--volumes', @utils.arg('--volumes',
metavar='<volumes>', metavar='<volumes>',