openstack/python-cinderclient
Code Issues Proposed changes

[Optimize] Adds interval and increase waiting time

Browse Source 
Gives more time to wait resource's status to change
in functional testcases and adds default interval
to reduce query amount.

Change-Id: I2a29a2d04836fd1261d45e404341bb1aa657417b
This commit is contained in:
TommyLike
2017-06-15 09:31:00 +08:00
parent 728e13442d
commit afa10404bc
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cinderclient/tests/functional/base.py
View File

@@ -108,7 +108,7 @@ class ClientTestBase(base.ClientTestBase):
return (object_name + '-' + cmd if object_name != 'volume' else cmd) return (object_name + '-' + cmd if object_name != 'volume' else cmd)
def wait_for_object_status(self, object_name, object_id, status, def wait_for_object_status(self, object_name, object_id, status,
timeout=60): timeout=120, interval=3):
"""Wait until object reaches given status. """Wait until object reaches given status.
:param object_name: object name :param object_name: object name
@@ -121,6 +121,7 @@ class ClientTestBase(base.ClientTestBase):
while time.time() - start_time < timeout: while time.time() - start_time < timeout:
if status in self.cinder(cmd, params=object_id): if status in self.cinder(cmd, params=object_id):
break break
time.sleep(interval)
else: else:
self.fail("%s %s did not reach status %s after %d seconds." self.fail("%s %s did not reach status %s after %d seconds."
% (object_name, object_id, status, timeout)) % (object_name, object_id, status, timeout))