openstack/python-cinderclient
Code Issues Proposed changes

Remove redundant statement and refactor

Browse Source 
1. Remove redundant pass-statement in except-block.
2. Define "body = None" before if-block to get rid of body-statement both in
   except-block and else-case.
3. Acknowledge error occurred instead of silently squashing it.

Change-Id: I31e17827b40e7a15d88ecacf1fdb2abbbe2da5c0
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
This commit is contained in:
Lin Yang
2015-06-29 13:49:57 +08:00
parent f860668d71
commit c23586b73f
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
cinderclient/client.py
View File

@@ -238,14 +238,12 @@ class HTTPClient(object):
**kwargs) **kwargs)
self.http_log_resp(resp) self.http_log_resp(resp)
body = None
if resp.text: if resp.text:
try: try:
body = json.loads(resp.text) body = json.loads(resp.text)
except ValueError: except ValueError as e:
pass self._logger.debug("Load http response text error: %s", e)
body = None
else:
body = None
if resp.status_code >= 400: if resp.status_code >= 400:
raise exceptions.from_response(resp, body) raise exceptions.from_response(resp, body)