openstack/python-cinderclient
Code Issues Proposed changes

Replace 'MagicMock' with 'Mock'

Browse Source 
In magicmock,there just have a mock_add_spec function,in this code,there have
not called this method so i think it can be removed and call mock directly.

Change-Id: Ic3b218eecb5738769dd2c18b6029dc70210d3989
This commit is contained in:
xianming mao 2016-09-21 12:13:22 +08:00 committed by xianming.mao
parent 0834b2b58b
commit cc736ad626
1 changed files with 1 additions and 1 deletions

2
cinderclient/tests/unit/test_shell.py

@ -154,7 +154,7 @@ class ShellTest(utils.TestCase):
side_effect=ks_exc.ConnectFailure())
@mock.patch('keystoneauth1.discover.Discover',
side_effect=ks_exc.ConnectFailure())
@mock.patch('sys.stdin', side_effect=mock.MagicMock)
@mock.patch('sys.stdin', side_effect=mock.Mock)
@mock.patch('getpass.getpass', return_value='password')
def test_password_prompted(self, mock_getpass, mock_stdin, mock_discover,
mock_token, mock_password):