openstack/python-cinderclient
Code Issues Proposed changes

Improve help text of volume create command

Browse Source 
This patch adds information about whichever default type is set for
API will be used during volume creation if we don't provide a
volume type in volume create command.
This patch also improves the help text of `cinder type-default` command.

Change-Id: I0c437b2c4f02c12d17c04719cbeff8521647ae15
This commit is contained in:
whoami-rajat
2021-11-01 11:57:44 -04:00
parent be0b88409b
commit e268778d3e
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cinderclient/v3/shell.py
View File

@@ -649,7 +649,10 @@ def do_reset_state(cs, args):
@utils.arg('--volume-type', @utils.arg('--volume-type',
metavar='<volume-type>', metavar='<volume-type>',
default=None, default=None,
help='Volume type. Default=None.') help='Volume type. Default=None, that is, use the default '
'volume type configured for the Block Storage API. You '
"can see what type this is by using the 'cinder type-default'"
' command.')
@utils.arg('--volume_type', @utils.arg('--volume_type',
help=argparse.SUPPRESS) help=argparse.SUPPRESS)
@utils.arg('--availability-zone', @utils.arg('--availability-zone',

8
cinderclient/v3/shell_base.py
View File

@@ -693,7 +693,13 @@ def do_type_list(cs, args):
def do_type_default(cs, args): def do_type_default(cs, args):
"""List the default volume type.""" """List the default volume type.
The Block Storage service allows configuration of a default
type for each project, as well as the system default, so use
this command to determine what your effective default volume
type is.
"""
vtype = cs.volume_types.default() vtype = cs.volume_types.default()
shell_utils.print_volume_type_list([vtype]) shell_utils.print_volume_type_list([vtype])