openstack/python-cinderclient
Code Issues Proposed changes

Merge "Add test coverage for shell snapshot-create w/ metadata"

Browse Source
This commit is contained in:
Zuul 2023-02-13 19:26:47 +00:00 committed by Gerrit Code Review
commit f045928d82
1 changed files with 18 additions and 0 deletions

18
cinderclient/tests/unit/v3/test_shell.py

@ -970,6 +970,15 @@ class ShellTest(utils.TestCase):
} }
} }
SNAP_BODY_3_66_W_METADATA = {
'snapshot': {
'volume_id': '123456',
'name': None,
'description': None,
'metadata': {'a': 'b'}
}
}
@ddt.data(True, 'true', 'on', '1') @ddt.data(True, 'true', 'on', '1')
@mock.patch('cinderclient.utils.find_resource') @mock.patch('cinderclient.utils.find_resource')
def test_snapshot_create_3_66_with_force_true(self, f_val, mock_find_vol): def test_snapshot_create_3_66_with_force_true(self, f_val, mock_find_vol):
@ -1037,6 +1046,15 @@ class ShellTest(utils.TestCase):
self.assert_called_anytime('POST', '/snapshots', self.assert_called_anytime('POST', '/snapshots',
body=pre_3_66_request_body) body=pre_3_66_request_body)
@mock.patch('cinderclient.utils.find_resource')
def test_snapshot_create_w_metadata(self, mock_find_vol):
mock_find_vol.return_value = volumes.Volume(
self, {'id': '123456'}, loaded=True)
self.run_command('--os-volume-api-version 3.66 '
'snapshot-create 123456 --metadata a=b')
self.assert_called_anytime('POST', '/snapshots',
body=self.SNAP_BODY_3_66_W_METADATA)
def test_snapshot_manageable_list(self): def test_snapshot_manageable_list(self):
self.run_command('--os-volume-api-version 3.8 ' self.run_command('--os-volume-api-version 3.8 '
'snapshot-manageable-list fakehost') 'snapshot-manageable-list fakehost')