Adjusted conditional statements to use instanceof when
comparing variables. Instanceof supports inheritance type
checking better than type.
Change-Id: I449f3df92b3646c384de717b7d53f7f85258c449
This adds the --cascade parameter to the volume
delete command. Using this will call the volume delete
with an additional parameter that deletes snapshots as
part of the same operation.
The name "cascade" is chosen to be somewhat generic,
so that we can extend this if desired in the future.
(And to hint at the terminology from SQL.)
Depends-On: I33d15b76d4bd0de14c635d404b2c97096c977a58
Change-Id: I05ce61e647c43f9a1e6d74444356a76e5d284673
Blueprint: del-vols-with-snaps
This changes:
$ cinder rename asdf
ERROR: Must supply either name or description. (HTTP 1)
To:
$ cinder rename asdf
ERROR: Must supply either name or description.
Affects rename, snapshot-rename, consisgroup-update,
and consisgroup-create-from-src.
(consisgroup-* previously printed HTTP 400.)
Closes-Bug: #1549020
Closes-Bug: #1549026
Change-Id: Ia920b3b75b53170789b694cbdd49100bd6a72d21
As Mitaka implments snapshot backup function, created_at
shows when backups are created, and data_timestamp shows
time when data are taken from volumes.
This patch adds data_timestamp as a sort item, so that
customers can list backups sorted by data_timestamp. As
a result, they can know which backup has latest data.
Closes-Bug: #1536065
Change-Id: Ibb680769cc73bd513dee81e55817d87df5958359
Cheesecake introduces a host based replication use case.
This change includes the changes needed to support those
implementations in the Cinder API.
Implements: blueprint replication-update
Change-Id: I74dc1a00fb4a2c05510c6159253036ac19706959
For more details on how request_id will be returned to the caller,
please refer to the approved blueprint [1] discussed with the
cross-project team.
[1] http://specs.openstack.org/openstack/openstack-specs/specs/return-request-id.html
Implements: blueprint return-request-id-to-caller
Change-Id: Ic6b557895707f30869219bd5096c4ef7785cf7dc
Pypy is a supported python interpretor for python-cinderclient,
but I don't think it's necessary to run all unit tests with it
for everyone. We do have the gate-python-cinderclient-pypy test
to validate there are no incompatibilities.
Pypy is also not available by default, so it is an extra step for
someone to know to install and set up the pypy environment before
they can run tox without failures.
Change-Id: I15e315415574dfe8cf8a3d5f7f968a082b81b165
In output of cinder show command, below fields contains extra 'u'
character being unicode:
1. volume_image_metadata
2. metadata
In output of "cinder credentials", below field contains extra 'u'
1. roles
In output of "cinder qos-create", below field contains extra 'u'
1. specs
In output of "cinder qos-list", below field contains extra 'u'
1. specs
In output of "cinder extra-specs-list", below field contains extra 'u'
1. extra_specs
In output of "cinder qos-show", below field contains extra 'u'
1. specs
Change-Id: I8be32f117ddc29b087ee872ff065c175dd70b372
Closes-Bug: #1538413
Closes-Bug: #1538415
Added request_ids attribute to resource object for all the volume,
volume_types, volume_type_access and volume_snapshots APIs by
updating following APIs:
volumes: delete, update, force_delete, reset_state, extend,
migrate_volume, retype, update_readonly_flag, manage, unmanage,
promote, reenable, get_pools, initialize_connection,
terminate_connection, get_encryption_metadata
volume_types: delete
volume_type_access: add_project_access remove_project_access
volume_snapshots: delete and update
Returning list with request_ids as attribute in case of
'delete_metadata' and 'delete_image_metadata' APIs.
These changes are required to return 'request_id' from client to
log request_id mappings of cross projects.
For more details on how request_id will be returned to the caller,
please refer to the approved blueprint [1] discussed with the
cross-project team.
[1] http://specs.openstack.org/openstack/openstack-specs/specs/return-request-id.html
DocImpact
'request-ids' will be returned as an attribute with response object.
User can access it using 'res.request_ids' where 'res' is a
response object.
Change-Id: Icc4565291220278a65e6910a840fba623b750cc4
Partial-Implements: blueprint return-request-id-to-caller
ManagerWithFind's find() and findall() function is exposed to users
as ManagerWithFind is parent class of VolumeManager, SnapshotManager,
etc.
When the find() and findall() function is called by users, they should
also return request_ids to users.
Change-Id: I87dca61f96ff9cf4dc9a443a46d7f559e8b3026f
Closes-Bug: 1545975
This patch follows the same approach as other OpenStack python
clients, by adding a safe header method to hash sensitive information.
Change-Id: I980ea7411b1e7f6d47d0a75d58de87b0f944d0d9
Closes-bug: #1516689
Added request_ids attribute to resource object for all the
cgsnapshots, consistencygroups, qos_specs, quota_classes,
quotas and services APIs by updating following APIs:
cgsnapshots: delete, update
consistencygroups: delete, update, create
qos_specs: delete, associate, disassociate, disassociate_all
quota_classes: update
quotas: update
services: enable, disable, disable_log_reason
These changes are required to return 'request_id' from client to
log request_id mappings of cross projects.
For more details on how request_id will be returned to the caller,
please refer to the approved blueprint [1] discussed with the
cross-project team.
[1] http://specs.openstack.org/openstack/openstack-specs/specs/return-request-id.html
DocImpact
'request-ids' will be returned as an attribute with response object.
User can access it using 'res.request_ids' where 'res' is a
response object.
Change-Id: I7b399512fcec9ecd31938656deb60e325bb76ad4
Partial-Implements: blueprint return-request-id-to-caller
Added request_ids attribute to resource object for all the
volume_backups, volume_encryption_types and volume_transfers
APIs by updating following APIs:
volume_backups: reset_state, delete, export_record, import_record
volume_transfers: delete
volume_encryption_types: list
Returning list with request_ids as attribute in case of 'list' API
for volume_encryption_types.
These changes are required to return 'request_id' from client to log
request_id mappings of cross projects.
For more details on how request_id will be returned to the caller,
please refer to the approved blueprint [1] discussed with the
cross-project team.
[1] http://specs.openstack.org/openstack/openstack-specs/specs/return-request-id.html
DocImpact
'request-ids' will be returned as an attribute with response object.
User can access it using 'res.request_ids' where 'res' is a
response object.
Change-Id: I2197ca38f6c9a8b0ced5c82d29676b49c9700b09
Partial-Implements: blueprint return-request-id-to-caller
Updated TupleWithMeta class to make it consistent with other Meta
classes in order to avoid confusion. Also made provision to call
TupleWithMeta with a tuple containing one or more elements.
For more details on how request_id will be returned to the caller,
please refer to the approved blueprint [1] discussed with the
cross-project team.
[1] http://specs.openstack.org/openstack/openstack-specs/specs/return-request-id.html
Change-Id: I5a79a4ed8cb4dc83ea3b64499df191750462100d
Partial-Implements: blueprint return-request-id-to-caller
While "cinder snapshot-delete" and "cinder delete" allow multiple resources to be deleted in a single command, "cinder backup-delete" request can only delete one backup at a time. Adding this capability to backups in cinderclient. Enables "cinder backup-delete" to delete multiple backups in a single command.
With this change the command can be run as below:
cinder backup-delete <backup> [<backup>...]
DocImpact
Closes-Bug: #1543056
Implements: blueprint cli-backup-multiple-deletes
Change-Id: I767710bda3b7c358c6525c9a9f074010084e411d
1. Wrong use of 'noqa'. "# flake8: noqa" option disables all checks
for the whole file.
2. Remove exclusion of 'tools' and '*openstack/common*' in flake8 and
fix the violations.
Change-Id: I153e992ffd6a80e70a99d7066c503c34326c93ab
Closes-bug: #1540254
We found in a recent review that one of my debug
print statements was accidentally let in an
earlier patch. This patch removes my debug code.
Change-Id: I1d1baaed4362d499b1c141f0eba36dfe883d0e3a
