b891c9980f
This prevents a job reporting 'success' when the appropriate python interpreter cannot be found, when actually it didn't run at all. Also change the default envlist to use generic 'py3' instead of a specific version which might not be present. Also change zuul config so the python-cinderclient-functional-py36 job runs on centos-8-stream nodes, where py36 should be available. And change bindep.txt to specify the correct package name for centos-8. Jeremy Stanley has given a more thorough explanation of why this is a good change: http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014810.html This isn't a theoretical issue. If you look at recent python-cinderclient-functional-py36 job results (for example, [0]), you'll see that Zuul reported 'success', but on a closer look, you'll see that no tests were run. [0] https://zuul.opendev.org/t/openstack/build/1bfc80638086405f8b29905cdd6f71be/log/job-output.txt#25470 Change-Id: I2e2aa24e1592b66b287c84eda97b5079c40a36ec
124 lines
3.4 KiB
INI
124 lines
3.4 KiB
INI
[tox]
|
|
distribute = False
|
|
envlist = py3,pep8
|
|
minversion = 3.18.0
|
|
skipsdist = True
|
|
# this allows tox to infer the base python from the environment name
|
|
# and override any basepython configured in this file
|
|
ignore_basepython_conflict=true
|
|
|
|
[testenv]
|
|
basepython = python3
|
|
usedevelop = True
|
|
setenv =
|
|
VIRTUAL_ENV={envdir}
|
|
OS_TEST_PATH=./cinderclient/tests/unit
|
|
OS_STDOUT_CAPTURE=1
|
|
OS_STDERR_CAPTURE=1
|
|
OS_TEST_TIMEOUT=60
|
|
passenv = *_proxy *_PROXY
|
|
|
|
deps =
|
|
-c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
|
|
-r{toxinidir}/requirements.txt
|
|
-r{toxinidir}/test-requirements.txt
|
|
commands = find . -type f -name "*.pyc" -delete
|
|
stestr run {posargs}
|
|
stestr slowest
|
|
allowlist_externals = find
|
|
|
|
[testenv:pep8]
|
|
commands =
|
|
flake8
|
|
doc8
|
|
|
|
[testenv:pylint]
|
|
deps =
|
|
-c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
|
|
-r{toxinidir}/requirements.txt
|
|
pylint==2.6.0
|
|
commands = bash tools/lintstack.sh
|
|
allowlist_externals = bash
|
|
|
|
[testenv:venv]
|
|
commands = {posargs}
|
|
|
|
[testenv:cover]
|
|
setenv =
|
|
{[testenv]setenv}
|
|
PYTHON=coverage run --source cinderclient --parallel-mode
|
|
commands =
|
|
stestr run {posargs}
|
|
coverage combine
|
|
coverage html -d cover
|
|
coverage xml -o cover/coverage.xml
|
|
|
|
[testenv:docs]
|
|
deps =
|
|
-c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
|
|
-r{toxinidir}/doc/requirements.txt
|
|
commands = sphinx-build -W -b html doc/source doc/build/html
|
|
|
|
[testenv:pdf-docs]
|
|
deps =
|
|
{[testenv:docs]deps}
|
|
commands =
|
|
{[testenv:docs]commands}
|
|
sphinx-build -W -b latex doc/source doc/build/pdf
|
|
make -C doc/build/pdf
|
|
allowlist_externals =
|
|
make
|
|
cp
|
|
|
|
[testenv:releasenotes]
|
|
deps =
|
|
-c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
|
|
-r{toxinidir}/doc/requirements.txt
|
|
commands = sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html
|
|
|
|
[testenv:functional]
|
|
commands = stestr run {posargs}
|
|
setenv =
|
|
{[testenv]setenv}
|
|
OS_TEST_PATH = ./cinderclient/tests/functional
|
|
OS_VOLUME_API_VERSION = 3
|
|
# must define this here so it can be inherited by the -py3* environments
|
|
OS_CINDERCLIENT_EXEC_DIR = {envdir}/bin
|
|
|
|
# The OS_CACERT environment variable should be passed to the test
|
|
# environments to specify a CA bundle file to use in verifying a
|
|
# TLS (https) server certificate.
|
|
passenv = OS_*
|
|
|
|
[testenv:functional-py36]
|
|
setenv = {[testenv:functional]setenv}
|
|
passenv = {[testenv:functional]passenv}
|
|
commands = {[testenv:functional]commands}
|
|
|
|
[testenv:functional-py37]
|
|
setenv = {[testenv:functional]setenv}
|
|
passenv = {[testenv:functional]passenv}
|
|
commands = {[testenv:functional]commands}
|
|
|
|
[testenv:functional-py38]
|
|
setenv = {[testenv:functional]setenv}
|
|
passenv = {[testenv:functional]passenv}
|
|
commands = {[testenv:functional]commands}
|
|
|
|
[flake8]
|
|
show-source = True
|
|
ignore = H404,H405,E122,E123,E128,E251,W504
|
|
exclude = .venv,.git,.tox,dist,doc,*lib/python*,*egg,build
|
|
application-import-names = cinderclient
|
|
import-order-style = pep8
|
|
|
|
[doc8]
|
|
ignore-path=.tox,*.egg-info,doc/src/api,doc/source/drivers.rst,doc/build,.eggs/*/EGG-INFO/*.txt,doc/source/configuration/tables,./*.txt,releasenotes/build,doc/source/cli/details.rst
|
|
extension=.txt,.rst,.inc
|
|
|
|
[testenv:lower-constraints]
|
|
deps =
|
|
-c{toxinidir}/lower-constraints.txt
|
|
-r{toxinidir}/test-requirements.txt
|
|
-r{toxinidir}/requirements.txt
|