openstack
/
python-glanceclient
Code Issues Proposed changes

Hide stderr noise in test output 

Previously, some tests caused the usage options for glance to be printed out to
stderr. This patch redirects the stderr output for those unnecessarily verbose
test functions.

Change-Id: I781d35a16a97c9c093cb17288ebd96d3e1a2e4e9
Closes-Bug: #1334655
This commit is contained in:
Louis Taylor 2014-08-17 20:39:03 +00:00
parent 1dfce5301c
commit 69361a146e
1 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
tests/v1/test_shell.py
View File

@ -22,6 +22,8 @@ import subprocess
import tempfile
import testtools
import mock
from glanceclient import exc
from glanceclient import shell
@ -263,42 +265,50 @@ class ShellInvalidEndpointandParameterTest(utils.TestCase):
self.run_command,
'member-delete <IMAGE_ID> <TENANT_ID>')
def test_image_create_invalid_size_parameter(self):
@mock.patch('sys.stderr')
def test_image_create_invalid_size_parameter(self, __):
self.assertRaises(
SystemExit,
self.run_command, 'image-create --size 10gb')
def test_image_create_invalid_ram_parameter(self):
@mock.patch('sys.stderr')
def test_image_create_invalid_ram_parameter(self, __):
self.assertRaises(
SystemExit,
self.run_command, 'image-create --min-ram 10gb')
def test_image_create_invalid_min_disk_parameter(self):
@mock.patch('sys.stderr')
def test_image_create_invalid_min_disk_parameter(self, __):
self.assertRaises(
SystemExit,
self.run_command, 'image-create --min-disk 10gb')
def test_image_update_invalid_size_parameter(self):
@mock.patch('sys.stderr')
def test_image_update_invalid_size_parameter(self, __):
self.assertRaises(
SystemExit,
self.run_command, 'image-update --size 10gb')
def test_image_update_invalid_min_disk_parameter(self):
@mock.patch('sys.stderr')
def test_image_update_invalid_min_disk_parameter(self, __):
self.assertRaises(
SystemExit,
self.run_command, 'image-update --min-disk 10gb')
def test_image_update_invalid_ram_parameter(self):
@mock.patch('sys.stderr')
def test_image_update_invalid_ram_parameter(self, __):
self.assertRaises(
SystemExit,
self.run_command, 'image-update --min-ram 10gb')
def test_image_list_invalid_min_size_parameter(self):
@mock.patch('sys.stderr')
def test_image_list_invalid_min_size_parameter(self, __):
self.assertRaises(
SystemExit,
self.run_command, 'image-list --size-min 10gb')
def test_image_list_invalid_max_size_parameter(self):
@mock.patch('sys.stderr')
def test_image_list_invalid_max_size_parameter(self, __):
self.assertRaises(
SystemExit,
self.run_command, 'image-list --size-max 10gb')