351 Commits

Author SHA1 Message Date
Jenkins
cd11833cff Merge "Fix regression bug after removing posixpath in http.py" 2013-10-09 17:46:01 +00:00
Jenkins
5ec5e7baec Merge "Fix getting header in redirect processing" 2013-10-09 17:36:54 +00:00
Jenkins
ad12bcf23d Merge "Fix default value for a header" 2013-10-09 05:06:39 +00:00
Chang Bo Guo
7bf27252e5 Fix misused assertTrue in unit tests
Refactored unit tests to use assertEqual instead of assertTrue
where needed.

Closes-Bug: #1226374

Change-Id: I5f3b582e19f3461a04b5df05960095779ec8aa1a
2013-10-08 19:04:08 -07:00
eddie-sheffield
32d9c42816 Add CLI for V2 image create, update, and upload
Provides command line support for image-create, image-update,
and image-upload using the Glance V2 API. This includes building
help text for create and update based on the image jsonschema
as fetched from the server.

Also fixes bug caused by default warlock patch generation not
matching what Glance expects when updating a core property
which had not originally been set when the image was created.

Related to bp glance-client-v2

Change-Id: I841f9e3d05802f4b794cb6f4849abe03ff0324d9
2013-10-02 13:22:55 -04:00
Yang Yu
a0715e966d Fix regression bug after removing posixpath in http.py
After removing posixpath.normpath(url) in http.py, the code has a
regression bug that the url like 'http://example.com:80/test' can
not work. The code urlparse.urljoin() can not work as '%s%s' %
(self.endpoint_path, url).

Fixes bug #1230032

Change-Id: Ie7266fc3a067b92dfeed169086b4bf6a87dedbd6
2013-09-28 21:47:09 -05:00
Russell Bryant
50266eec2b Fix getting header in redirect processing
The code for processing an HTTP redirect included an incorrect method of
getting the Location header from an HTTPResponse.  It needs to use the
getheader() method on the response, instead.  This patch fixes that and
includes a unit test that covers this code path.

Change-Id: I0952fabad581b020dee07bdc4007b55b47c906aa
Closes-Bug: #1231524
2013-09-26 11:45:06 -04:00
Russell Bryant
4718635811 Fix default value for a header
This code specified None as the default value, but it would raise an
exception if that was ever returned.  An empty string causes the code to
work as intended.

This came up while I was writing a unit test for another bug fix.

Change-Id: I658bb8a9b5124f281988fb60b645182ea0ccf99f
Related-bug: #1231524
2013-09-26 11:45:05 -04:00
Jenkins
7a4a8a0979 Merge "Support glance client can get ipv6 image url correctly" 2013-09-25 20:01:58 +00:00
Jenkins
360a29a763 Merge "Use openstack-images-v2.1-json-patch for update method" 2013-09-19 17:55:45 +00:00
Dazhao
061da46202 Support glance client can get ipv6 image url correctly
This patch is for fix bug 1208784. In openstack ipv6 environment,
if the os image url is not provided, need use the provided host
to generate literal ipv6 image url.

Fixes bug 1208784

Change-Id: Icb71241a639db02d079348f086bd7bd5f0412609
2013-09-06 13:58:24 +08:00
Fei Long Wang
897ae3d795 Enable query image by tag
This patch will enable Glance client to query images by user
defined tags.

Implement bp image-query-by-tag
Implement bp glance-client-v2

Change-Id: I6f54630c5b7c9c567d85485ad4289284e5486814
2013-08-28 14:13:27 +08:00
Gabe Westmaas
b6e117f151 Fix glanceclient usage inconsistences for options
Enumerated options should have the same format for all enumerated options.

This commit moves all options to the {option1,option2} format.

fixes bug: #1155171

Change-Id: I8e0ecf3896c76021cb027cbbbb3b5564a04aacec
2013-08-25 01:14:07 +00:00
Mark J. Washenberger
b15c57c4a2 Add 0.11.0 doc notes
Change-Id: Ic76e872e78ec77b731ad9dced833803da3fa9aca
2013-08-22 23:55:52 -07:00
Ghe Rivero
3307549a0f Use openstack-images-v2.1-json-patch for update method
image.patch returns a JSON schema Draft 10 (application/openstack-images-v2.1-json-patch)
while the glaceclient update method specify a Content-Type header
application/openstack-images-v2.0-json-patch with correspond to a JSON schemea Draft 4.

Fixes bug 1206095
Change-Id: I8c5a96f0e117a81b5b527a96ef45758fc69b518d
2013-08-23 06:52:08 +00:00
Jenkins
835638fd8a Merge "Don't use posixpath for URLs" 2013-08-22 21:12:47 +00:00
Jenkins
fe9a62b5b5 Merge "Allow single-wildcard SSL common name matching" 2013-08-22 21:12:36 +00:00
Brian Waldon
683e40fd31 Allow single-wildcard SSL common name matching
Fix bug 1212463

Change-Id: I168601fd9847497c2261c77ce6c856bca187c6c8
2013-08-21 17:57:38 +00:00
Dean Troyer
53d3a0e129 Revert "removed deprecated parameter --public"
While trunk devstack was updated for this, stable/folsom and stable/grizzly
are not and grenade is now broken.  I'm not sure how long --public was
undocumented but it may be that certain cli args may need to remain deprecated
but supported for longer than we wish.

This reverts commit ce8636b6b3c4b606483cfb2bc405d86224f309bc

Change-Id: I91d4884e470c8fcc611dae62a30fa22d08dbec03
2013-08-19 14:46:28 -05:00
Jenkins
20bd548d71 Merge "removed deprecated parameter --public" 2013-08-19 15:34:56 +00:00
eddie-sheffield
7e4ba229c3 \Allow removal of properties using glance v2 api
This adds support to the glance client library for removing
properties from an image. Properties to be removed must be
explicitly listed. There is no equivalent of the 'purge_props'
functionality in v1.

Also beefed up testing around create since some of the
functionality is the same as update.

Fixes bug 1206472

Change-Id: I16f4c39cdfc8a0cd07bede600461b7a289fbb080
2013-08-13 14:13:27 -04:00
Jenkins
3de64660a9 Merge "Raise warlock requirement" 2013-08-12 22:15:33 +00:00
Jenkins
14a9d27796 Merge "Updated from global requirements" 2013-08-12 17:14:42 +00:00
Monty Taylor
1f2eef510f Updated from global requirements
Change-Id: I2e2bd3a38458e1307bcc0410da74dc76c0a5987a
2013-08-10 10:49:11 -07:00
Jenkins
0c2d2a982d Merge "Cast image_id to string before calling urllib.quote" 2013-08-09 20:34:10 +00:00
Mark J. Washenberger
eb47b55dbd Revert 02116565d358a4fa254217779fef82b14b38d8ca
A patch slipped in that modified the default image list limit in a
backwards-incompatible way. This change reverts that patch, but
preserves some of the formatting improvements.

Change-Id: I17ae5024896ca7b1064be66b9e47653e953771d6
2013-08-08 22:31:40 -07:00
Mark J. Washenberger
5cdbcdf3fc Add 0.10.0 docs update
Change-Id: Ib2e75abc7d696f89d97918738bfc960cf3d1da5b
2013-08-08 19:20:39 -07:00
mouad benchchaoui
1d7da740b2 Show a pretty progressbar when uploading and downloading an image.
Add a new module that contain generic wrapper for file and iterator, which
are used to wrap image to upload and the request body iterator in upload and
download cases repectively, to show and advance a pretty progress bar when this
laters are consumed, The progress bar is triggered by adding a --progress command
line argument to commands: image-create, image-download or image-update.

Change-Id: I2ba42fd0c58f4fa087adb568ec3f08246cae3759
bug fix: LP#1112309
blueprint: progressbar-when-uploading
2013-08-08 15:40:15 +02:00
Zhi Yan Liu
ec1dc92a2a Raise warlock requirement
Glance PATCH API need use new 'require' condition for schema to validate
income requests.

Raise warlock requirement to >=1.0.1,<2 as older warlock requires a too
old jsonschema to be useful.

See bug #1202391 for details.

Change-Id: I0ac148850a5b1254bf0827c7de2db1464a6703d8
Signed-off-by: Zhi Yan Liu <zhiyanl@cn.ibm.com>
2013-08-08 12:22:41 +08:00
Justin Santa Barbara
f629692917 Cast image_id to string before calling urllib.quote
We can't pass a string in; see Bug #1178233

Change-Id: I040c667e122d792fdcb47ee172463339068af48c
2013-08-07 11:17:01 -07:00
Justin Santa Barbara
a30981e7f0 Don't use posixpath for URLs
Use URL functions instead.

Fixes bug #1208618

Change-Id: I27bb29a6422200a1a522c50335e5d93d495ec429
2013-08-05 14:42:19 -07:00
Jenkins
43e71e3993 Merge "Changes to allow image upload with V2 api" 2013-07-31 19:10:12 +00:00
eddie-sheffield
e827c37a05 Changes to allow image upload with V2 api
Related to bp glance-client-v2

Change-Id: I72a1d2825dd5c1ff4890e8be477cb4447d59f136
2013-07-31 12:28:24 -04:00
Jenkins
5c4fb2f7a1 Merge "Fix test assertions & test cases for V2 Shell Unit test" 2013-07-31 15:22:04 +00:00
Jenkins
937b65b513 Merge "Enable client library V2 to create an image." 2013-07-30 22:08:19 +00:00
Jenkins
2d86c5dcde Merge "Provide glance CLI man page." 2013-07-30 20:42:08 +00:00
Jenkins
e0e6030a09 Merge "Allow v1 client to list all users' images" 2013-07-30 17:31:08 +00:00
Jenkins
e34dc38a70 Merge "Add v1 client side owner based filtering" 2013-07-30 17:31:06 +00:00
Christian Berendt
ce8636b6b3 removed deprecated parameter --public
As noted by bcwaldon the parameter can be removed after updating
Devstack. Should be done after merging the following change:

https://review.openstack.org/#/c/39323/

Change-Id: I8d0f7ab4cccccf022446374a31e03ac913cfb136
2013-07-30 19:12:59 +02:00
Flaper Fesp
fd0e117579 Encode error messages before sending them to stdout
When an error with non-ascii characters is caught by glanceclient, it
fails at printing it and exists with a UnicodeEncodedError. This patch
encodes errors' messages using strutils before sending them to stdout.

Fixes bug: #1200206

Change-Id: I4dabcd76ffb258840bd6a66ad23c030f34960e86
2013-07-29 09:30:44 +02:00
Stuart McLaren
bb47812765 Allow v1 client to list all users' images
Add a '--all-tenants' option to the image-list command.  This adds
'is_public=None' to the query string passed to the server, and for an
admin user results in a listing of all images present on the server
irrespective of owner or public values.

Addresses bug 1201787.

Change-Id: I38dd0752a31ebea84f16b786d205e82eba1a96bc
2013-07-26 11:01:52 +00:00
Stuart McLaren
12feedb2cf Add v1 client side owner based filtering
Add the --owner option to the v1 client's image-list command to support
filtering images based on the owner (tenant id).

Allows administrators to more easily list a particular user's images.

Note that this is far less efficient than v2 server-side owner based filtering.

Addresses bug 1201765.

Change-Id: I4ffa522b96c91e659c87f5452f2f1f44e47e806b
2013-07-26 11:00:32 +00:00
eddie-sheffield
92e4ee201a Enable client library V2 to create an image.
Adds support for creating an image to the client library only, not the CLI.
Replaced reference to deprecated BaseException.message

Related to bp glance-client-v2

Change-Id: I8e3d09d89493368d22f7b1f69f79ebd2518e289d
2013-07-25 14:45:00 -04:00
Jakub Ruzicka
d1aded801f Provide glance CLI man page.
Provide basic but hopefully useful man page.

Also update OpenStack LCC to OpenStack Foundation in docs.

Resolves: bug 1193111
Implements blueprint: clients-man-pages
Change-Id: I9502b3d5ca75149d747d523934a6401e435924b7
2013-07-25 12:46:14 -04:00
Venkatesh Sampath
060a3fe2c0 Fix test assertions & test cases for V2 Shell Unit test
Fixes bug 1195674

Change-Id: I46c10040ea10415498dd1eed69e45139cfa37eb4
2013-07-25 08:11:58 +05:30
Jenkins
8d7411d78b Merge "HTTPS response issues" 2013-07-24 22:11:08 +00:00
Jenkins
49a1207266 Merge "Fix SSL certificate CNAME checking" 2013-07-22 21:50:07 +00:00
David Peraza
5d90740f33 HTTPS response issues
Fixes bug 1179392

glanceclient.common.http.HTTPClient.get_connection_kwargs method
explicitly sets the timeout to be a float, while struc.pack is
still using LL as the format string which means 2 Long Integers.
Setting format string to fL which mean a float followed by Long
Integer.

Also, Bad file descriptor error is caused by socket being closed
to soon. Added a close() implementation to VerifiedHTTPSConnection
which will remove reference to socket before returning call to
base HTTPConnection.close(). This will avoid socket to be closed
before response body is read. Socket will close when response
close is called.

Change-Id: I3a973da3b962c7572ae0f61f6996bdd1f0048339
2013-07-22 15:33:38 +00:00
Jenkins
093064caa8 Merge "Increase default page_size value" 2013-07-19 09:45:42 +00:00
Jenkins
46ce865506 Merge "Pass all identity headers received to glance" 2013-07-18 17:45:33 +00:00