openstack/python-heatclient
Code Issues Proposed changes

Remove None for dict.get()

Browse Source 
Because If no default value is specified it defaults to None already.

Change-Id: I1ca522c7eebb2171d1a3efd35680ce42b89237b5
This commit is contained in:
zhang-jinnan
2014-02-19 20:53:57 +08:00
parent 5458fe691e
commit 3aa86e98cf
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
heatclient/common/utils.py
View File

@@ -123,7 +123,7 @@ def env(*vars, **kwargs):
returns the default defined in kwargs.
"""
for v in vars:
value = os.environ.get(v, None)
value = os.environ.get(v)
if value:
return value
return kwargs.get('default', '')

4
heatclient/openstack/common/apiclient/exceptions.py
View File

@@ -422,8 +422,8 @@ def from_response(response, method, url):
else:
if hasattr(body, "keys"):
error = body[body.keys()[0]]
kwargs["message"] = error.get("message", None)
kwargs["details"] = error.get("details", None)
kwargs["message"] = error.get("message")
kwargs["details"] = error.get("details")
elif content_type.startswith("text/"):
kwargs["details"] = response.text