openstack/python-ironicclient
Code Issues Proposed changes

Avoid string interpolation in logging calls

Browse Source 
It's better to delegate the string formatting to the logging module
because it will be interpolate the string only if that log level is
enabled, saving few CPU cycles.

Change-Id: I7cee482de3e9505a353624337befc1e1b7b33416
This commit is contained in:
Luong Anh Tuan 2016-09-26 16:52:01 +07:00 committed by Lucas Alvares Gomes
parent 229824c2ca
commit 316d69ef25
4 changed files with 8 additions and 8 deletions

4
ironicclient/osc/v1/baremetal_chassis.py

@ -151,7 +151,7 @@ class ListBaremetalChassis(command.Lister):
return parser
def take_action(self, parsed_args):
self.log.debug("take_action(%s)" % parsed_args)
self.log.debug("take_action(%s)", parsed_args)
client = self.app.client_manager.baremetal
columns = res_fields.CHASSIS_RESOURCE.fields
@ -176,7 +176,7 @@ class ListBaremetalChassis(command.Lister):
labels = resource.labels
params['fields'] = columns
self.log.debug("params(%s)" % params)
self.log.debug("params(%s)", params)
data = client.chassis.list(**params)
data = oscutils.sort_items(data, parsed_args.sort)

2
ironicclient/osc/v1/baremetal_driver.py

@ -33,7 +33,7 @@ class ListBaremetalDriver(command.Lister):
return parser
def take_action(self, parsed_args):
self.log.debug("take_action(%s)" % parsed_args)
self.log.debug("take_action(%s)", parsed_args)
client = self.app.client_manager.baremetal
labels = ['Supported driver(s)', 'Active host(s)']

4
ironicclient/osc/v1/baremetal_node.py

@ -497,7 +497,7 @@ class ListBaremetalNode(command.Lister):
return parser
def take_action(self, parsed_args):
self.log.debug("take_action(%s)" % parsed_args)
self.log.debug("take_action(%s)", parsed_args)
client = self.app.client_manager.baremetal
columns = res_fields.NODE_RESOURCE.fields
@ -532,7 +532,7 @@ class ListBaremetalNode(command.Lister):
labels = resource.labels
params['fields'] = columns
self.log.debug("params(%s)" % params)
self.log.debug("params(%s)", params)
data = client.node.list(**params)
data = oscutils.sort_items(data, parsed_args.sort)

6
ironicclient/osc/v1/baremetal_port.py

@ -77,7 +77,7 @@ class CreateBaremetalPort(command.ShowOne):
return parser
def take_action(self, parsed_args):
self.log.debug("take_action(%s)" % parsed_args)
self.log.debug("take_action(%s)", parsed_args)
baremetal_client = self.app.client_manager.baremetal
if parsed_args.local_link_connection_deprecated:
@ -341,7 +341,7 @@ class ListBaremetalPort(command.Lister):
return parser
def take_action(self, parsed_args):
self.log.debug("take_action(%s)" % parsed_args)
self.log.debug("take_action(%s)", parsed_args)
client = self.app.client_manager.baremetal
columns = res_fields.PORT_RESOURCE.fields
@ -373,7 +373,7 @@ class ListBaremetalPort(command.Lister):
labels = resource.labels
params['fields'] = columns
self.log.debug("params(%s)" % params)
self.log.debug("params(%s)", params)
data = client.port.list(**params)
data = oscutils.sort_items(data, parsed_args.sort)