- Extend the driver-list command with --type argument, which, if supplied,
limits the driver list to only classic drivers (classic value) or
hardware types (dynamic value), and --detail to show detailed info
of drivers.
- Extend the output of the driver-show command with more info of driver.
Change-Id: I5f72c47805ae9f761250f500098bfef4d502e419
Partial-Bug: #1524745
This cleans up the driver-related code so that the fields and labels
used for driver resources are in v1/resource_fields.py. This makes
it consistent with the other resources (node, port, etc).
Change-Id: I4d546d1ad3be997a23be4e2d9c919644bf8ce804
This moves duplicated information to a new v1/utils.py file:
- list of HTTP codes
- list of boot devices
- provision-related information
Change-Id: I4a11627359213770dbc8aa037fcf95ed7bfd0870
Add the key_value_pairs_to_dict() method, which takes a list
of key=value string pairs and generates a dictionary from that.
Code is refactored to use this method.
Change-Id: Ie4ada3354ff0afa66398804a715d09dd05695393
This commits add the following:
* Ability to set target_raid_config for a node using
node-set-target-raid-config.
* Display target_raid_config and raid_config in node-show.
* Display logical disk properties for a driver using
driver-raid-logical-disk-properties.
NOTE: Client still defaults to version 1.9, so
'--ironic-api-version 1.15' (or above) should be
added to the CLI to use the feature as RAID can be
triggered only with manual cleaning which uses the
ironic-api-version 1.15.
Co-Authored-By: Nisha Agarwal <agarwalnisha1980@gmail.com>
Closes_bug: 1526400
Change-Id: Id7bb8a242838029e4cc3715d18b27fb1d5cd4dfa
Add a json option to list and show commands to return the JSON
response body from the Ironic API without formatting it.
Change-Id: Ic21c8ce1cc211816e309b4a00b6e89a0a8bf6a9d
Closes-Bug: #1436440
According to the latest agreement in Oslo team, apiclient and
clituils will be removed from Oslo incubator. We should keep
the local copy by ourselfs:
1. rename openstack/common/apiclient to common/apiclient
2. Because Ironic only use base.py and exception.py, so delete others.
3. rename openstack/common/cliutils.py to common/clituils.py
4. Delete openstack/common/_i18n becuase we have common/i18n.py
5. Delete openstack folder because it is empty
6. Add related unit tests and add oslotest to test-requirements.
Change-Id: I9eecd0457e86e82e65db1d0bc9a4c5c0ed4bbf74
The iteritems() of Python 2 dictionaries has been renamed to items()
to provide compatibility with Python 3.
Change-Id: I6f32c4e00abb19a9316c5e1d014df26b0c6d35f9
This is basically a revert of commit:
af741ec2236619880fa902d68aef4a6ae6cef534
It was decided that only files that need to have the line:
# -*- coding: utf-8 -*-
Should have the line[1] as a general principle
This patch removes the 'utf-8' coding line from files that consist
entirely of ASCII characters.
[1]
http://eavesdrop.openstack.org/meetings/ironic/2015/ironic.2015-04-20-17.00.html
Partial-bug: #1325193
Change-Id: I88c1c37f7b580aa805eae9d4a1e66d33302a325f
Fix PEP8 E126,E127,E128 errors, which were the only ones remaining.
Fix PEP8 errors:
E126: continuation line over-indented for hanging indent
E127: continuation line over-indented for visual indent
E128: continuation line under-indented for visual indent
Remove the ignore= entries for flake8 in tox.ini
Change-Id: I919551121d85d2aab528f4fa5ecdb3cfd940557a
This modifies the CLI so that the argument names, metavar names
and help strings are more consistent.
Argument names that consist of more than one word are now separated
by hyphens instead of underscores. Existing argument names with
underscores are still supported but not displayed via help. The new
argument names are: http_method -> http-method, chassis_uuid -> chassis,
driver_info -> driver-info, node_uuid -> node.
Metavars are only used in the help strings displayed to the user. For
consistency, they are lowercased with hyphens to separate the
words. (Using spaces might make someone think that more than one argument
is needed.)
Help strings were updated. Among other things, they are treated like
sentences with the first letter in upper case, and a period at the end.
Closes-Bug: #1420318
Change-Id: If05d51b09d787ccfbf6f6d35d8e752d42f673601
Extend the vendor_passthru() library methods and clients to support
issuing different HTTP methods on the vendor endpoints.
Implements: blueprint extended-vendor-passthru
Change-Id: I32a4990ed3db0bc73ce845b9b4119d87ab2e1503
The vendor_passthru() method for the node and driver library was
expecting a **kwargs, that isn't helpful because you don't know exactly
how much parameters it expects, what are the parameters etc... This
patch is changing it since the parameters are well defined (we knew what
parameters we were expecting there).
Change-Id: Idb2002eb76e76f6e1b67a6ea1a7d31f41573abdd
CLI help text for driver-list says "List drivers".
But it will list only the enabled drivers.
Hence the help text has been changed to reflect the same.
Change-Id: Ib68537b69dd0455558656710e8d7df7f2a03ff1f
Closes-Bug: #1298628
After switch to cliutils in https://review.openstack.org/72418
field_labels argument is no longer respected in print_list.
This patch updates cliutils to version introduced in
https://review.openstack.org/#/c/113978 and fixes usage
of the newly-introduced field_labels argument to print_list.
Change-Id: I4c5ca149816e4476f170b30de6855dec747522dd
Closes-Bug: #1342391
Add 'driver-properties <driver_name>' command. This returns a table
listing the properties of the specified driver, including name
and description.
Eg:
$ ironic driver-properties pxe_ipmitool
+--------------------+----------------------------------------------+
| Property | Description |
+--------------------+----------------------------------------------+
| ipmi_address | IP address or hostname of the node. Required.|
| ipmi_password | password. Optional. |
| ipmi_priv_level | privilege level; default is ... Optional. |
| ipmi_terminal_port | node's UDP port ... required for console... |
| ipmi_username | username; default is NULL user. Optional. |
| pxe_deploy_kernel | UUID (from Glance) of the deployment... |
| pxe_deploy_ramdisk | UUID (from Glance) of the ramdisk... |
+--------------------+----------------------------------------------+
If this feature is not available in Ironic, it returns
"Not Found (HTTP 404)".
If driver_name doesn't exist, it returns "The driver '<driver-name>' is
unknown. (HTTP 404)".
Change-Id: Id125fe4c1771dc5bb5b57d528940f2ba1c85866a
Blueprint: get-required-driver-info
This commit adds support for calling vendor-passthru
methods for nodes and drivers.
Change-Id: I73dd6c74f4b069e297cbf2175ffbba39fc1d6df6
Closes-Bug: 1330777
While not strictly necessary for files containing only ASCII
characters, adding a line with "coding: utf-8" can guard against
future SyntaxError's in case someone inserts a Unicode literal.
This commit adds such lines to all .py files. The syntax used by this
commit works with Python (of course). It also works with Emacs, which
will recognize the special "-*-" marker and use the "coding" variable
to correctly decode the file, even in an environment where UTF-8 is
not the default file encoding.
Existing coding lines were normalized to match the new lines added.
Partial-bug: #1325193
Change-Id: I58bf93fea711fd25890356a397e594bd820c99e3
This patch:
- removes unused method `common.utils:pretty_choice_list`;
- removes unused method `common.utils:find_resource`;
- removes unused method `common.utils:exit`;
- adds alias to `cliutils:args` in `common.utils`;
- adds alias to `cliutils:env` in `common.utils`;
- reuses method `print_list` from `cliutils`;
- reuses method `print_dict` from `cliutils`.
Related to blueprint common-client-library-2
Change-Id: I42318c6947509d4338309d03e722d822182bbc5d
Now that the Ironic API supports getting individual drivers via
/v1/drivers/<driver_name>, a new 'driver-show' command is added
to the client.
Change-Id: Ia18ba75a9814f127b2db0ccbcb3f5b0f44045c7a
The commit https://review.openstack.org/#/c/60216/ returns the name of the
drivers and also a list of active conductors that supports each driver,
this patch makes the necessary changes to expose that information on
the driver-list command.
Change-Id: I9183b40422f6dc3193570703d25d47b6e8edde06
