4d966622ef
According to the latest agreement in Oslo team, apiclient and clituils will be removed from Oslo incubator. We should keep the local copy by ourselfs: 1. rename openstack/common/apiclient to common/apiclient 2. Because Ironic only use base.py and exception.py, so delete others. 3. rename openstack/common/cliutils.py to common/clituils.py 4. Delete openstack/common/_i18n becuase we have common/i18n.py 5. Delete openstack folder because it is empty 6. Add related unit tests and add oslotest to test-requirements. Change-Id: I9eecd0457e86e82e65db1d0bc9a4c5c0ed4bbf74
138 lines
5.1 KiB
Python
138 lines
5.1 KiB
Python
# Copyright 2012 OpenStack Foundation
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from oslotest import base as test_base
|
|
import six
|
|
|
|
from ironicclient.common.apiclient import exceptions
|
|
|
|
|
|
class FakeResponse(object):
|
|
json_data = {}
|
|
|
|
def __init__(self, **kwargs):
|
|
for key, value in six.iteritems(kwargs):
|
|
setattr(self, key, value)
|
|
|
|
def json(self):
|
|
return self.json_data
|
|
|
|
|
|
class ExceptionsArgsTest(test_base.BaseTestCase):
|
|
|
|
def assert_exception(self, ex_cls, method, url, status_code, json_data,
|
|
error_msg=None, error_details=None,
|
|
check_description=True):
|
|
ex = exceptions.from_response(
|
|
FakeResponse(status_code=status_code,
|
|
headers={"Content-Type": "application/json"},
|
|
json_data=json_data),
|
|
method,
|
|
url)
|
|
self.assertTrue(isinstance(ex, ex_cls))
|
|
if check_description:
|
|
expected_msg = error_msg or json_data["error"]["message"]
|
|
expected_details = error_details or json_data["error"]["details"]
|
|
self.assertEqual(ex.message, expected_msg)
|
|
self.assertEqual(ex.details, expected_details)
|
|
self.assertEqual(ex.method, method)
|
|
self.assertEqual(ex.url, url)
|
|
self.assertEqual(ex.http_status, status_code)
|
|
|
|
def test_from_response_known(self):
|
|
method = "GET"
|
|
url = "/fake"
|
|
status_code = 400
|
|
json_data = {"error": {"message": "fake message",
|
|
"details": "fake details"}}
|
|
self.assert_exception(
|
|
exceptions.BadRequest, method, url, status_code, json_data)
|
|
|
|
def test_from_response_unknown(self):
|
|
method = "POST"
|
|
url = "/fake-unknown"
|
|
status_code = 499
|
|
json_data = {"error": {"message": "fake unknown message",
|
|
"details": "fake unknown details"}}
|
|
self.assert_exception(
|
|
exceptions.HTTPClientError, method, url, status_code, json_data)
|
|
status_code = 600
|
|
self.assert_exception(
|
|
exceptions.HttpError, method, url, status_code, json_data)
|
|
|
|
def test_from_response_non_openstack(self):
|
|
method = "POST"
|
|
url = "/fake-unknown"
|
|
status_code = 400
|
|
json_data = {"alien": 123}
|
|
self.assert_exception(
|
|
exceptions.BadRequest, method, url, status_code, json_data,
|
|
check_description=False)
|
|
|
|
def test_from_response_with_different_response_format(self):
|
|
method = "GET"
|
|
url = "/fake-wsme"
|
|
status_code = 400
|
|
json_data1 = {"error_message": {"debuginfo": None,
|
|
"faultcode": "Client",
|
|
"faultstring": "fake message"}}
|
|
message = six.text_type(
|
|
json_data1["error_message"]["faultstring"])
|
|
details = six.text_type(json_data1)
|
|
self.assert_exception(
|
|
exceptions.BadRequest, method, url, status_code, json_data1,
|
|
message, details)
|
|
|
|
json_data2 = {"badRequest": {"message": "fake message", "code": 400}}
|
|
message = six.text_type(json_data2["badRequest"]["message"])
|
|
details = six.text_type(json_data2)
|
|
self.assert_exception(
|
|
exceptions.BadRequest, method, url, status_code, json_data2,
|
|
message, details)
|
|
|
|
def test_from_response_with_text_response_format(self):
|
|
method = "GET"
|
|
url = "/fake-wsme"
|
|
status_code = 400
|
|
text_data1 = "error_message: fake message"
|
|
|
|
ex = exceptions.from_response(
|
|
FakeResponse(status_code=status_code,
|
|
headers={"Content-Type": "text/html"},
|
|
text=text_data1),
|
|
method,
|
|
url)
|
|
self.assertTrue(isinstance(ex, exceptions.BadRequest))
|
|
self.assertEqual(ex.details, text_data1)
|
|
self.assertEqual(ex.method, method)
|
|
self.assertEqual(ex.url, url)
|
|
self.assertEqual(ex.http_status, status_code)
|
|
|
|
def test_from_response_with_text_response_format_with_no_body(self):
|
|
method = "GET"
|
|
url = "/fake-wsme"
|
|
status_code = 401
|
|
|
|
ex = exceptions.from_response(
|
|
FakeResponse(status_code=status_code,
|
|
headers={"Content-Type": "text/html"}),
|
|
method,
|
|
url)
|
|
self.assertTrue(isinstance(ex, exceptions.Unauthorized))
|
|
self.assertEqual(ex.details, '')
|
|
self.assertEqual(ex.method, method)
|
|
self.assertEqual(ex.url, url)
|
|
self.assertEqual(ex.http_status, status_code)
|