openstack/python-keystoneclient
Code Issues Proposed changes

Fix tests passing user, project, and token

Browse Source 
The tests were creating httpclient.HTTPClient() using username,
token, and project, but if you pass a token then username and
project are going to be ignored since there's no need to auth.

Make the tests more understandable by removing the ignored and
useless parameters.

bp deprecations

Change-Id: Ide3f4be4dd00db89f551d014876625cff296f6a7
This commit is contained in:
Brant Knudson 2015-07-24 15:21:53 -05:00
parent 9f17732308
commit 0b745909a6
3 changed files with 4 additions and 12 deletions
keystoneclient/tests/unit
test_base.py
v2_0
utils.py
v3
utils.py

8
keystoneclient/tests/unit/test_base.py

@ -36,9 +36,7 @@ class BaseTest(utils.TestCase):
self.assertEqual(base.getid(TmpObject), 4)
def test_resource_lazy_getattr(self):
self.client = client.Client(username=self.TEST_USER,
token=self.TEST_TOKEN,
tenant_name=self.TEST_TENANT_NAME,
self.client = client.Client(token=self.TEST_TOKEN,
auth_url='http://127.0.0.1:5000',
endpoint='http://127.0.0.1:5000')
@ -85,9 +83,7 @@ class ManagerTest(utils.TestCase):
def setUp(self):
super(ManagerTest, self).setUp()
self.client = client.Client(username=self.TEST_USER,
token=self.TEST_TOKEN,
tenant_name=self.TEST_TENANT_NAME,
self.client = client.Client(token=self.TEST_TOKEN,
auth_url='http://127.0.0.1:5000',
endpoint='http://127.0.0.1:5000')
self.mgr = base.Manager(self.client)

4
keystoneclient/tests/unit/v2_0/utils.py

@ -78,9 +78,7 @@ class TestCase(UnauthenticatedTestCase):
def setUp(self):
super(TestCase, self).setUp()
self.client = client.Client(username=self.TEST_USER,
token=self.TEST_TOKEN,
tenant_name=self.TEST_TENANT_NAME,
self.client = client.Client(token=self.TEST_TOKEN,
auth_url=self.TEST_URL,
endpoint=self.TEST_URL)

4
keystoneclient/tests/unit/v3/utils.py

@ -129,9 +129,7 @@ class TestCase(UnauthenticatedTestCase):
def setUp(self):
super(TestCase, self).setUp()
self.client = client.Client(username=self.TEST_USER,
token=self.TEST_TOKEN,
tenant_name=self.TEST_TENANT_NAME,
self.client = client.Client(token=self.TEST_TOKEN,
auth_url=self.TEST_URL,
endpoint=self.TEST_URL)