openstack/python-keystoneclient
Code Issues Proposed changes

Correct use of noqa

Browse Source 
The use of "#flake8: noqa" disables hacking checks for the entire
file. Switched to use of "# noqa" and fixed hacking problems.

Change-Id: I18785fb18bdce88e61e2451960e55aed0863c285
This commit is contained in:
Brant Knudson
2014-10-27 16:20:44 -05:00
parent 20f488d45e
commit 3b766c5143
4 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
keystoneclient/exceptions.py
View File

@@ -16,8 +16,7 @@
Exception definitions. Exception definitions.
""" """
#flake8: noqa from keystoneclient.openstack.common.apiclient.exceptions import * # noqa
from keystoneclient.openstack.common.apiclient.exceptions import *
# NOTE(akurilin): This alias should be left here to support backwards # NOTE(akurilin): This alias should be left here to support backwards
# compatibility until we are sure that usage of these exceptions in # compatibility until we are sure that usage of these exceptions in
@@ -29,7 +28,7 @@ HTTPError = HttpError
class CertificateConfigError(Exception): class CertificateConfigError(Exception):
"""Error reading the certificate""" """Error reading the certificate."""
def __init__(self, output): def __init__(self, output):
self.output = output self.output = output
msg = 'Unable to load certificate.' msg = 'Unable to load certificate.'
@@ -37,7 +36,7 @@ class CertificateConfigError(Exception):
class CMSError(Exception): class CMSError(Exception):
"""Error reading the certificate""" """Error reading the certificate."""
def __init__(self, output): def __init__(self, output):
self.output = output self.output = output
msg = 'Unable to sign or verify data.' msg = 'Unable to sign or verify data.'
@@ -71,7 +70,8 @@ class MissingAuthPlugin(ClientException):
class NoMatchingPlugin(ClientException): class NoMatchingPlugin(ClientException):
"""There were no auth plugins that could be created from the parameters """There were no auth plugins that could be created from the parameters
provided.""" provided.
"""
class InvalidResponse(ClientException): class InvalidResponse(ClientException):

3
keystoneclient/v2_0/__init__.py
View File

@@ -1,5 +1,4 @@
# flake8: noqa from keystoneclient.v2_0.client import Client # noqa
from keystoneclient.v2_0.client import Client
__all__ = [ __all__ = [

4
keystoneclient/v3/__init__.py
View File

@@ -1,5 +1,5 @@
# flake8: noqa
from keystoneclient.v3.client import Client from keystoneclient.v3.client import Client # noqa
__all__ = [ __all__ = [

2
keystoneclient/v3/contrib/federation/__init__.py
View File

@@ -10,4 +10,4 @@
# License for the specific language governing permissions and limitations # License for the specific language governing permissions and limitations
# under the License. # under the License.
from keystoneclient.v3.contrib.federation.core import * # flake8: noqa from keystoneclient.v3.contrib.federation.core import * # noqa