openstack/python-keystoneclient
Code Issues Proposed changes

Clean arguments in test_federation.*.test_create()

Browse Source 
This applies to test_federation.IdentityProviderTests.test_create() and
test_federation.MappingTests.test_create()

Change-Id: Ie88c959626520fcec4ee64ffc73a8fc845c5a6d3
This commit is contained in:
Marek Denis
2015-03-16 10:00:52 +01:00
committed by Steve Martinelli
parent cfad7da20e
commit 7e63af0c4e
1 changed files with 6 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
keystoneclient/tests/unit/v3/test_federation.py
View File

@@ -71,14 +71,9 @@ class IdentityProviderTests(utils.TestCase, utils.CrudTests):
self.assertRaises(TypeError, getattr(self.manager, f_name),
*args)
def test_create(self, ref=None, req_ref=None):
ref = ref or self.new_ref()
# req_ref argument allows you to specify a different
# signature for the request when the manager does some
# conversion before doing the request (e.g. converting
# from datetime object to timestamp string)
req_ref = (req_ref or ref).copy()
def test_create(self):
ref = self.new_ref()
req_ref = ref.copy()
req_ref.pop('id')
self.stub_entity('PUT', entity=ref, id=ref['id'], status_code=201)
@@ -108,16 +103,11 @@ class MappingTests(utils.TestCase, utils.CrudTests):
uuid.uuid4().hex])
return kwargs
def test_create(self, ref=None, req_ref=None):
ref = ref or self.new_ref()
def test_create(self):
ref = self.new_ref()
manager_ref = ref.copy()
mapping_id = manager_ref.pop('id')
# req_ref argument allows you to specify a different
# signature for the request when the manager does some
# conversion before doing the request (e.g. converting
# from datetime object to timestamp string)
req_ref = (req_ref or ref).copy()
req_ref = ref.copy()
self.stub_entity('PUT', entity=req_ref, id=mapping_id,
status_code=201)