openstack/python-keystoneclient
Code Issues Proposed changes

Fix incorrect assertTrue usage

Browse Source 
Several self.assertTrue(len(returned_list)) statements exist,
which don't make any sense as we're testing an integer length
as a boolean.  Instead test the returned list length matches
the list passed in to stub the request.

Change-Id: I713c3a6afcc93ebb2a8f7ffde45aade2154ebf2c
This commit is contained in:
Steven Hardy
2014-01-09 15:17:59 +00:00
parent 5d6c42dde8
commit 9bc1817185
4 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
keystoneclient/tests/v3/test_groups.py
View File

@@ -45,7 +45,7 @@ class GroupTests(utils.TestCase, utils.CrudTests):
status=200, entity=ref_list)
returned_list = self.manager.list(user=user_id)
self.assertTrue(len(returned_list))
self.assertEqual(len(ref_list), len(returned_list))
[self.assertTrue(isinstance(r, self.model)) for r in returned_list]
@httpretty.activate
@@ -58,7 +58,7 @@ class GroupTests(utils.TestCase, utils.CrudTests):
status=200, entity=ref_list)
returned_list = self.manager.list(domain=domain_id)
self.assertTrue(len(returned_list))
self.assertTrue(len(ref_list), len(returned_list))
[self.assertTrue(isinstance(r, self.model)) for r in returned_list]
self.assertEqual(httpretty.last_request().querystring,

4
keystoneclient/tests/v3/test_projects.py
View File

@@ -45,7 +45,7 @@ class ProjectTests(utils.TestCase, utils.CrudTests):
entity=ref_list)
returned_list = self.manager.list(user=user_id)
self.assertTrue(len(returned_list))
self.assertEqual(len(ref_list), len(returned_list))
[self.assertTrue(isinstance(r, self.model)) for r in returned_list]
@httpretty.activate
@@ -57,7 +57,7 @@ class ProjectTests(utils.TestCase, utils.CrudTests):
entity=ref_list)
returned_list = self.manager.list(domain=domain_id)
self.assertTrue(len(returned_list))
self.assertEqual(len(ref_list), len(returned_list))
[self.assertTrue(isinstance(r, self.model)) for r in returned_list]
self.assertEqual(httpretty.last_request().querystring,

2
keystoneclient/tests/v3/test_users.py
View File

@@ -64,7 +64,7 @@ class UserTests(utils.TestCase, utils.CrudTests):
entity=ref_list)
returned_list = self.manager.list(group=group_id)
self.assertTrue(len(returned_list))
self.assertEqual(len(ref_list), len(returned_list))
[self.assertTrue(isinstance(r, self.model)) for r in returned_list]
@httpretty.activate

2
keystoneclient/tests/v3/utils.py
View File

@@ -239,7 +239,7 @@ class CrudTests(object):
body=jsonutils.dumps(self.encode(ref_list)))
returned_list = self.manager.list(**filter_kwargs)
self.assertTrue(len(returned_list))
self.assertEqual(len(ref_list), len(returned_list))
[self.assertTrue(isinstance(r, self.model)) for r in returned_list]
@httpretty.activate