openstack/python-keystoneclient
Code Issues Proposed changes

Cleanup exception logging

Browse Source 
LOG.exception() already prints the exception, so passing the
exception to it isn't useful. Pass a message instead.

Change-Id: If5b5be1e275a4688a04ba4ccc582149a3a5f2bd2
This commit is contained in:
Brant Knudson
2014-10-27 17:17:39 -05:00
parent b71a0a22c5
commit a1088d019d
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
keystoneclient/generic/client.py
View File

@@ -19,7 +19,7 @@ from six.moves.urllib import parse as urlparse
from keystoneclient import exceptions from keystoneclient import exceptions
from keystoneclient import httpclient from keystoneclient import httpclient
from keystoneclient.i18n import _ from keystoneclient.i18n import _, _LE
_logger = logging.getLogger(__name__) _logger = logging.getLogger(__name__)
@@ -124,8 +124,8 @@ class Client(httpclient.HTTPClient):
return self._check_keystone_versions(resp['location']) return self._check_keystone_versions(resp['location'])
else: else:
raise exceptions.from_response(resp, "GET", url) raise exceptions.from_response(resp, "GET", url)
except Exception as e: except Exception:
_logger.exception(e) _logger.exception(_LE('Failed to detect available versions.'))
def discover_extensions(self, url=None): def discover_extensions(self, url=None):
"""Discover Keystone extensions supported. """Discover Keystone extensions supported.
@@ -168,8 +168,8 @@ class Client(httpclient.HTTPClient):
else: else:
raise exceptions.from_response( raise exceptions.from_response(
resp, "GET", "%sextensions" % url) resp, "GET", "%sextensions" % url)
except Exception as e: except Exception:
_logger.exception(e) _logger.exception(_LE('Failed to check keystone extensions.'))
@staticmethod @staticmethod
def _get_version_info(version, root_url): def _get_version_info(version, root_url):