openstack/python-keystoneclient
Code Issues Proposed changes

Use assertIsNone(...) instead of assertEqual(None, ...)

Browse Source 
Refer to:http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises

[H203] Use assertIs(Not)None to check for None (off by default) Unit
test assertions tend to give better messages for more specific assertions.
As a result, assertIsNone(...) is preferred over assertEqual(None, ...)
and assertIs(None, ...)

Change-Id: I4e60f3f7f3557080669b98cb48627acc40a72606
This commit is contained in:
chenaidong1
2016-12-08 14:56:39 +08:00
parent 2b9d1554cc
commit a9ebec4fbd
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
keystoneclient/tests/unit/v2_0/test_client.py
View File

@@ -218,4 +218,4 @@ class KeystoneClientTest(utils.TestCase):
# authenticated # authenticated
sess = auth_session.Session() sess = auth_session.Session()
cl = client.Client(session=sess) cl = client.Client(session=sess)
self.assertEqual(None, cl.service_catalog) self.assertIsNone(cl.service_catalog)

2
keystoneclient/tests/unit/v3/test_client.py
View File

@@ -268,4 +268,4 @@ class KeystoneClientTest(utils.TestCase):
# authenticated # authenticated
sess = auth_session.Session() sess = auth_session.Session()
cl = client.Client(session=sess) cl = client.Client(session=sess)
self.assertEqual(None, cl.service_catalog) self.assertIsNone(cl.service_catalog)