openstack/python-keystoneclient
Code Issues Proposed changes

Follow up patch for add domain functional tests

Browse Source 
This patch fixes comments left by the review
I74bff2728c09e6aafaced97a7836f51e58a81786.

Change-Id: Ic74e8fbde2455280f5affaafb8d989a6b98feb75
This commit is contained in:
Nisha Yadav
2016-06-21 15:44:29 +05:30
parent 15a93d8bfb
commit cf45fff4f1
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
keystoneclient/tests/functional/v3/client_fixtures.py
View File

@@ -19,12 +19,11 @@ RESOURCE_NAME_PREFIX = 'keystoneclient-functional-'
class Base(fixtures.Fixture):
def __init__(self, client, domain_id):
def __init__(self, client, domain_id=None):
super(Base, self).__init__()
self.client = client
self.domain_id = domain_id
self.ref = None
self.entity = None

6
keystoneclient/tests/functional/v3/test_domains.py
View File

@@ -54,10 +54,10 @@ class DomainsTestCase(base.V3ClientTestCase):
self.check_domain(domain_ret)
def test_list_domains(self):
domain_one = fixtures.Domain(self.client, self.project_domain_id)
domain_one = fixtures.Domain(self.client)
self.useFixture(domain_one)
domain_two = fixtures.Domain(self.client, self.project_domain_id)
domain_two = fixtures.Domain(self.client)
self.useFixture(domain_two)
domains = self.client.domains.list()
@@ -70,7 +70,7 @@ class DomainsTestCase(base.V3ClientTestCase):
self.assertIn(domain_two.entity, domains)
def test_update_domain(self):
domain = fixtures.Domain(self.client, self.project_domain_id)
domain = fixtures.Domain(self.client)
self.useFixture(domain)
new_description = uuid.uuid4().hex