openstack/python-keystoneclient
Code Issues Proposed changes

Fix test_request_no_token_dummy cms dependency.

Browse Source 
* tests/test_auth_token_middleware.py: test_request_no_token_dummy has a
dependency on the keystone.common.cms module importing subprocess prior
to running. The cms._ensure_subprocess() function does this. Call this
function in the base test class's setUp method to ensure subprocess is
imported before symbols from that module are needed. Doing this in the
base setUp will ensure that this works for any additional tests with the
same dependency.

This fix is needed because testr runs tests in non deterministic order
which means that each test needs to be able to run on its own (eg in its
own process without any other tests running first) and they need to run
without interfering any other tests (each test must properly clean up
after itself). Prior to this commit test_request_no_token_dummy would
fail when executed on its own.

Closes-Bug: #1209300
Change-Id: I3cf669b94ed77ad0cd729ead0b4162a3f1b8819f
This commit is contained in:
Clark Boylan
2013-08-07 09:24:58 -07:00
parent 4e9af1f5a2
commit fb7aae4e96
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/test_auth_token_middleware.py
View File

@@ -643,6 +643,12 @@ class BaseAuthTokenMiddlewareTest(testtools.TestCase):
self.fake_http = fake_http or FakeHTTPConnection
self.set_middleware(self.fake_app, self.fake_http,
expected_env, self.conf)
# self.middleware.verify_signed_token will call
# _ensure_subprocess, but we need
# cms.subprocess.CalledProcessError to be imported first.
# Explicitly call _ensure_subprocess to make sure the import
# happens before we need it regardless of test order.
cms._ensure_subprocess()
self.response_status = None
self.response_headers = None