currently there is no release history for keystoneclient, though
sometimes the commits are lacking context, this automated approach
is far better than nothing.
Change-Id: Ibb865b4830cbe1e2e99688103d26f1378d2c32b1
The SAML plugin handles redirects in a custom manner but currently only
checks for the 302 redirect code. This doesn't cover the mod_auth_mellon
case which responds with a 303.
Also handle the 303 redirect case.
Change-Id: Idab5f381fcbfb8c561184845d3aa5c8aab142ecd
Closes-Bug: #1501918
Using a mutable type implies that it's acceptable for the set of
publicly-accessible attributes to be mutated at runtime, which defeats
their intended purpose of documenting the public interface. Tuples are
immutable.
Change-Id: Ib3ab93224ba240040b08ece481ef5ba620c3f658
Creating an HTTPClient without a session is deprecated and
the ServiceCatalog's region_name parameter is also deprecated.
This follows suite with the following commits to update tests
to handle deprecation warnings:
803eb235d50daad27074198effc98ca536f1550f
42bd016e1f0e011ba745dba243e62401298e324c
Change-Id: I1c5a3dc2c8448873696262ca951c58666c692a61
Closes-Bug: #1499790
In _http_log_response method of session.py module,
list "string_parts' is created as below.
string_parts = ['RESP:']
string_parts.append('[%s]' % response.status_code)
Could be rewritten as
string_parts = [
'RESP:',
'[%s]' % response.status_code
]
TrivialFix
Change-Id: I83d04a71e030f3904c84cead4659c230393631db
Dictionary creation could be rewritten as a dictionary literal.
for example:
token_values = {}
token_values['user_id'] = access.get('user', {}).get('id')
could be rewritten as
token_values = {'user_id': access.get('user', {}).get('id')}
TrivialFix
Change-Id: I0c5677b527d440b8faded31bf4d9d62805391ae3
The .pot file was named incorrectly and in the wrong location so the
traslations were not getting generated.
Change-Id: Iafd2b7f06dd840fa0505729a9fc898e7e281c50c
Closes-Bug: 1493484
A common case is for Nova (or other service) to create a service
authentication plugin from a configuration file and then have many
greenlet threads that want to reuse that authentication. If a token
expires then many threads all try and fetch a new token to use and can
step over each other.
I was hoping for a way to put a lock in so that all plugins were thread
safe however fixing it for identity plugins solves almost all real world
situations and anyone doing non-identity plugins will have to manage
threads themselves.
Change-Id: Ib6487de7de638abc69660c851bd048a8ec177109
Closes-Bug: #1493835
Recently, the error message in _process_communicate_handle_oserror()
has been i18n'ed, which caused the regression as another code path
appended a string to it, which causes the TypeError to be raised.
Fix it by using string formatting instead of '+' to force it
to convert to string before concatenating.
Closes-Bug: 1421652
Change-Id: I7229b46888f798ac4a69c140ab389afed49b8c3c
The mapping for ConnectionError to ConnectionRefused have been
remove in a recent cleanup to move all exception to
keystoneclient.exceptions
related commit: 26534dadb1d0be00b87b632a038839ab1c18cfe4
Adding the mapping back for backward compatability.
Change-Id: I6f4627b9cd68615b509d17910fe2c1605e89fc26
Closes-Bug: #1492600
The comments indicated that creating a Discover without a
session is deprecated, but there was no warning generated.
Also, updated the Discover() parameter docstrings with the
standard deprecation info (e.g., in what release it's
deprecated and when we might remove it).
bp deprecations
Change-Id: I1d42b74aa72c15b95ac3c365b40d8c622869ed7e
We should sanitize the response body before logging to make sure we
aren't leaking through credentials like in the case of the response from
the os-initialize_connection volume API.
Closes-Bug: #1490693
Change-Id: Ifd95d3fb624b4636fb72cc11762af62e00a026a0
The deprecation text should say when the property was deprecated
and when we expect to remove it.
bp deprecations
Change-Id: I9f1af56d03f0251a7cf3f4a4130928bb0780aece
httpclient's USER_AGENT constant wasn't properly deprecated since
the deprecation was only a comment. Proper deprecation requires use
of warnings/debtcollector and documentation, but since this is a
module symbol there's no way to put out a warning, so it's just
documentation in this case.
bp deprecations
Change-Id: I02c77c690a31eea40935d2756748382abec86867
The comments indicated that creating a HTTPClient without a
session is deprecated, but there was no warning generated.
bp deprecations
Change-Id: I44796cbff95a7bbdd6e7a58e5cfb8360bdae5477
The ; separator allows providing parameters to a type not separating
type options. This means that in strict type checks like those performed
by mod_auth_mellon the check for accept type fails.
Change-Id: Ieeaa74b304921daef68497fec77cc6629ab2f0a2
Closes-Bug: #1488722
On Windows, the 'socket' python module does not contain the
attributes TCP_KEEPCNT or TCP_KEEPINTVL, causing services
consuming the library to malfunction.
Adds conditionals for adding the mentioned socket attributes
to the socket options.
socket.SIO_KEEPALIVE_VALS cannot be added as a socket option
for Windows, as there is another way entirely to enable that
option.
Change-Id: I2e9746ae65400bbd23c3b48dfc3167de9eb66494
Partial-Bug: #1483696
