openstack/python-magnumclient
Code Issues Proposed changes

Increase unit test coverage for module baymodels

Browse Source 
Adds extra tests to fully cover list function
in baymodels module. Corrects typo mistakes in function names.

Change-Id: I551f429d677e641994550b16304829bd70a42740
This commit is contained in:
Vipul Nayyar
2016-07-19 12:33:41 +05:30
parent 63505b62c9
commit 5d96100d6a
1 changed files with 22 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
magnumclient/tests/v1/test_baymodels.py
View File

@@ -116,6 +116,13 @@ fake_responses = {
UPDATED_BAYMODEL,
),
},
'/v1/baymodels/detail':
{
'GET': (
{},
{'baymodels': [BAYMODEL1, BAYMODEL2]},
),
},
'/v1/baymodels/?limit=2':
{
'GET': (
@@ -176,7 +183,7 @@ class BayModelManagerTest(testtools.TestCase):
self.assertEqual(expect, self.api.calls)
self.assertThat(baymodels, matchers.HasLength(2))
def _test_baymode_list_with_fileters(
def _test_baymodel_list_with_filters(
self, limit=None, marker=None,
sort_key=None, sort_dir=None,
detail=False, expect=[]):
@@ -187,11 +194,19 @@ class BayModelManagerTest(testtools.TestCase):
self.assertEqual(expect, self.api.calls)
self.assertThat(baymodels_filter, matchers.HasLength(2))
def test_baymodel_list_with_detail(self):
expect = [
('GET', '/v1/baymodels/detail', {}, None),
]
self._test_baymodel_list_with_filters(
detail=True,
expect=expect)
def test_baymodel_list_with_limit(self):
expect = [
('GET', '/v1/baymodels/?limit=2', {}, None),
]
self._test_baymode_list_with_fileters(
self._test_baymodel_list_with_filters(
limit=2,
expect=expect)
@@ -199,7 +214,7 @@ class BayModelManagerTest(testtools.TestCase):
expect = [
('GET', '/v1/baymodels/?marker=%s' % BAYMODEL2['uuid'], {}, None),
]
self._test_baymode_list_with_fileters(
self._test_baymodel_list_with_filters(
marker=BAYMODEL2['uuid'],
expect=expect)
@@ -208,7 +223,7 @@ class BayModelManagerTest(testtools.TestCase):
('GET', '/v1/baymodels/?limit=2&marker=%s' % BAYMODEL2['uuid'],
{}, None),
]
self._test_baymode_list_with_fileters(
self._test_baymodel_list_with_filters(
limit=2, marker=BAYMODEL2['uuid'],
expect=expect)
@@ -216,7 +231,7 @@ class BayModelManagerTest(testtools.TestCase):
expect = [
('GET', '/v1/baymodels/?sort_dir=asc', {}, None),
]
self._test_baymode_list_with_fileters(
self._test_baymodel_list_with_filters(
sort_dir='asc',
expect=expect)
@@ -224,7 +239,7 @@ class BayModelManagerTest(testtools.TestCase):
expect = [
('GET', '/v1/baymodels/?sort_key=uuid', {}, None),
]
self._test_baymode_list_with_fileters(
self._test_baymodel_list_with_filters(
sort_key='uuid',
expect=expect)
@@ -232,7 +247,7 @@ class BayModelManagerTest(testtools.TestCase):
expect = [
('GET', '/v1/baymodels/?sort_key=uuid&sort_dir=desc', {}, None),
]
self._test_baymode_list_with_fileters(
self._test_baymodel_list_with_filters(
sort_key='uuid', sort_dir='desc',
expect=expect)