Using "python setup.py check -r -s" method of checking the package has
been deprecated with the new recommendation to build the sdist and
wheel, then running "twine check" against the output.
Luckily, there is already a job that covers this that only runs when the
README, setup.py, or setup.cfg files change, making running this in the
pep8 job redundant. This is covered by the test-release-openstack-python3
that is defined in the publish-to-pypi-python3 template.
More details can be found in this mailing list post:
http://lists.openstack.org/pipermail/openstack-dev/2018-October/136136.html
Change-Id: I19830446d21b989542b54511bc05f885b7a8ff60
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
python3.5 was the only supported python3 version
on Xenial, now that we have Bionic Beaver nodes
that support python3.7, lets switch to testing
with python3.7 in addition with python3.6 in
Stein and beyond.
See ML discussion here [1] for context.
[1] http://lists.openstack.org/pipermail/openstack-dev/2018-October/135632.html
Change-Id: Ia9868f39ff788e02850fae756820f7c1388bde0a
Depends-On: I4b2149cf7033f16a37cd185e5f19ab2e7e837cdf
Story: #2004073
Task: #27427
Quotes around {posargs} cause the entire string to be combined into one
arg that gets passed to stestr. This prevents passing multiple args
(e.g. '--concurrency=16 some-regex')
Change-Id: I6a18fa58d85f0d75befedba4bac5cc3c116da73c
IETF RFC 3986 classifies "~" as a reserved character [1],
however until python3.7 [2], python's url parsing
used to encode this character.
urllib has seen a lot of churn in various python
releases, and hence we were using a six wrapper
to shield ourselves, however, this backwards-incompatible
change in encoding norms forces us to deal with
the problem at our end.
Manila's API accepts "~" in both, its encoded
or un-encoded forms. So, let's stop encoding it
within manilaclient, regardless of the version
of python running it.
[1] https://tools.ietf.org/html/rfc3986.html
[2] https://docs.python.org/3/library/urllib.parse.html#url-quoting
Closes-Bug: #1785283
Change-Id: I6df5d543ae94ed1fa966c8019a52e9fca19e387e
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: Ic98a865e5d8f2e5467dff62a648046818dc502e3
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Use openstack-tox-cover template, this runs the cover job
in the check queue only.
Use openstack-lower-constraints-jobs template.
Remove jobs that are part of the templates.
Change-Id: I91226a370592a013368d6472b921968cf801e8a9
Replace it with program-output from
sphinxcontrib-programoutput
Depends-On: https://review.openstack.org/595480
Change-Id: I9b14af568996cc1aaefaeb4d94fe36163c6cbbf2
This is a mechanically generated patch to switch the documentation
jobs to use the new PTI versions of the jobs as part of the
python3-first goal.
See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html
Change-Id: Ib160926c1e827b47747283d02a97324aaa194693
Story: #2002586
Task: #24309
This is a mechanically generated patch to complete step 1 of moving
the zuul job settings out of project-config and into each project
repository.
Because there will be a separate patch on each branch, the branch
specifiers for branch-specific jobs have been removed.
Because this patch is generated by a script, there may be some
cosmetic changes to the layout of the YAML file(s) as the contents are
normalized.
See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html
Change-Id: Ie7b283ee1735b4e91538f092846a7b8d368151e3
Story: #2002586
Task: #24309
Manila's ci scripts disable configuring the
default share and share group types if testing
with the dummy driver.
We want to continue using the the default types
mechanism in python-manilaclient, until we decide
not to.
Change-Id: I14544bea728286eeb33461e724d991fe556a4269
Closes-Bug: #1787292
Previously manila list --sort_key name command sort on
the basis of id instead of name. This PS will fix the
issue and sort the list in terms of name key.
Change-Id: If96162b5269a5a385de9c72c4cef2b335e5c24ff
Closes-Bug: #1777849
Closes-Bug: #1779935
https://review.openstack.org/#/c/573474 introduced a
problematic pinned requirement for docutils==0.11
which can't be supported across the various distros
that we need to support.
Change the requirement from strict equality to
greater-than-or-equal.
Change-Id: I92fcf6a516339a660395e5cd48e0a496158447e8
When we use manila client to create a share type or share group
type, the is_default value is always empty, this patch is to fix
this issue.
Depends-On: Ia8bcb632591fc0b5438847b22ec59c2039ecf5f1
Change-Id: Ib264d8422fe57701f990cbbf7ea5d1e90b8b0008
Closes-bug: #1743941
Now only share have metadata property.
We should support it for access rule as well.
Depends-On: https://review.openstack.org/#/c/570708/
Change-Id: I41b2882ecd16ed03bece05a7a77a387c9077bf5c
Partly-Implements: bp metadata-for-access-rule
1. Fix manila pool-list --column reports nothing for
capabilities
2. Format the result of manila pool-list --detail
Change-Id: I09bab5a3eaa28e6773afdfc2ac0b99295d725cc1
Closes-bug: #1717940
The unicode() built-in does not exist under Python 3 so use
six.text_type, which is set correctly to str or unicode, instead.
Change-Id: I4e2a4b10dfaa8703525df7d5a6892487698657da
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: I81fd5d0161c6ed1b789cd62c3a882fe375c9a2a2
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Currently, we only allow $manila help subcomand to print
subcomands info, if we are using $manila subcomand --help,
it will print all the subcomands info, that is not what we
want, this change is to allow '--help' to print subcomands
info. finally we can see the following comands are equals:
$ manila --help list
$ manila list --help
$ manila help list
Change-Id: I926defd6c5d3b8d87b038e2c63db694b40a88359
Close-bug: #1771097
auth.py, client.py, fake_client.py are unused in manilaclient,
delete these files to increase the test coverage from 77% to 80%
Change-Id: I734b79f6aa24b4b002047c74a5ef76d19700f200
os-testr has moved over to use stestr instead of testr. While this
is usually compatible with existing settings, there is a warning
that is emitted when .stestr.conf is not present. It is usually
able to fall back to parsing the .testr.conf file, but to be more
correct and to prevent future problems we should update the config.
Change-Id: I10446c539aaf9edd8b52b17776e08c12757def31
Depends-On: I98a296d009e64d6afab02a53bd1af878f78c4321
Since manila server allows filter search extra_specs and is_public,
so it's better to add this in manila client as well.
Change-Id: Ie85a7c09d4d7c6ddc31adb5125feea265ad8fced
Depends-On: Id577ae9d08dc0fae3dcac78d98ec0456f8378417
Partially-Implements: blueprint support-filter-search-for-share-type
The wrap @testtools.skipUnless cause the base class
SnapshotAccessReadBase to be the <type 'function'>,
However, it should be <type 'type'>, this cause the
functional test unbale to import the test module.
Closes-bug: #1769633
Change-Id: I98a296d009e64d6afab02a53bd1af878f78c4321