749 Commits

Author SHA1 Message Date
Sean McGinnis
b7a3e1f8ba Remove setup.py check from pep8 job
Using "python setup.py check -r -s" method of checking the package has
been deprecated with the new recommendation to build the sdist and
wheel, then running "twine check" against the output.

Luckily, there is already a job that covers this that only runs when the
README, setup.py, or setup.cfg files change, making running this in the
pep8 job redundant. This is covered by the test-release-openstack-python3
that is defined in the publish-to-pypi-python3 template.

More details can be found in this mailing list post:

http://lists.openstack.org/pipermail/openstack-dev/2018-October/136136.html

Change-Id: I19830446d21b989542b54511bc05f885b7a8ff60
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2018-10-30 11:10:20 -05:00
Zuul
cc6fadbc96 Merge "Add unit-test for availability_zones.AvailabilityZone repr()" 1.25.0 2018-10-17 14:33:10 +00:00
Zuul
1d01348219 Merge "Don't quote {posargs} in tox.ini" 2018-10-17 14:22:05 +00:00
Goutham Pacha Ravi
646262af93 Change python3.5 job to python3.7 job on Stein+
python3.5 was the only supported python3 version
on Xenial, now that we have Bionic Beaver nodes
that support python3.7, lets switch to testing
with python3.7 in addition with python3.6 in
Stein and beyond.

See ML discussion here [1] for context.

[1] http://lists.openstack.org/pipermail/openstack-dev/2018-October/135632.html

Change-Id: Ia9868f39ff788e02850fae756820f7c1388bde0a
Depends-On: I4b2149cf7033f16a37cd185e5f19ab2e7e837cdf
Story: #2004073
Task: #27427
2018-10-12 21:25:47 +00:00
Zuul
c7548b2aff Merge "Stop encoding "~" in query parameters" 2018-10-10 14:17:31 +00:00
Vieri
156a71d2dc Don't quote {posargs} in tox.ini
Quotes around {posargs} cause the entire string to be combined into one
arg that gets passed to stestr. This prevents passing multiple args
(e.g. '--concurrency=16 some-regex')

Change-Id: I6a18fa58d85f0d75befedba4bac5cc3c116da73c
2018-10-09 13:57:09 +00:00
Goutham Pacha Ravi
80ec2919ca Stop encoding "~" in query parameters
IETF RFC 3986 classifies "~" as a reserved character [1],
however until python3.7 [2], python's url parsing
used to encode this character.

urllib has seen a lot of churn in various python
releases, and hence we were using a six wrapper
to shield ourselves, however, this backwards-incompatible
change in encoding norms forces us to deal with
the problem at our end.

Manila's API accepts "~" in both, its encoded
or un-encoded forms. So, let's stop encoding it
within manilaclient, regardless of the version
of python running it.

[1] https://tools.ietf.org/html/rfc3986.html
[2] https://docs.python.org/3/library/urllib.parse.html#url-quoting

Closes-Bug: #1785283
Change-Id: I6df5d543ae94ed1fa966c8019a52e9fca19e387e
2018-10-08 17:15:33 -07:00
Alexander Pugachev
522b712a15 Add unit-test for availability_zones.AvailabilityZone repr()
The method was not covered.

Change-Id: I2fb3e9cc33201363087ba33876fe36dd515b9123
Partial-Bug: #1364800
2018-10-05 10:46:38 +01:00
Zuul
d1b616af8d Merge "fix tox python3 overrides" 2018-10-02 16:57:06 +00:00
Zuul
81a8bf7881 Merge "Drop 'clidoc' from sphinx extensions" 2018-10-02 13:22:48 +00:00
Doug Hellmann
e15fe1b772 fix tox python3 overrides
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.

We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.

We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.

Change-Id: Ic98a865e5d8f2e5467dff62a648046818dc502e3
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2018-09-26 18:56:01 -04:00
Andreas Jaeger
4c2c1d87af Use templates for cover and lower-constraints
Use openstack-tox-cover template, this runs the cover job
in the check queue only.

Use openstack-lower-constraints-jobs template.

Remove jobs that are part of the templates.

Change-Id: I91226a370592a013368d6472b921968cf801e8a9
2018-09-07 15:28:33 +02:00
Goutham Pacha Ravi
d146a345c7 Drop 'clidoc' from sphinx extensions
Replace it with program-output from
sphinxcontrib-programoutput

Depends-On: https://review.openstack.org/595480
Change-Id: I9b14af568996cc1aaefaeb4d94fe36163c6cbbf2
2018-08-23 19:21:34 -07:00
Goutham Pacha Ravi
781a428cda add python 3.6 unit test job
This is a mechanically generated patch to add a unit test job running
under Python 3.6 as part of the python3-first goal.

See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html

Change-Id: Iada32717417b085e75a99404f279bbe2b30bcfc9
Story: #2002586
Task: #24309
2018-08-20 18:50:25 +00:00
Goutham Pacha Ravi
d338cda7b8 switch documentation job to new PTI
This is a mechanically generated patch to switch the documentation
jobs to use the new PTI versions of the jobs as part of the
python3-first goal.

See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html

Change-Id: Ib160926c1e827b47747283d02a97324aaa194693
Story: #2002586
Task: #24309
2018-08-20 18:50:20 +00:00
Goutham Pacha Ravi
567ae71c1c import zuul job settings from project-config
This is a mechanically generated patch to complete step 1 of moving
the zuul job settings out of project-config and into each project
repository.

Because there will be a separate patch on each branch, the branch
specifiers for branch-specific jobs have been removed.

Because this patch is generated by a script, there may be some
cosmetic changes to the layout of the YAML file(s) as the contents are
normalized.

See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html

Change-Id: Ie7b283ee1735b4e91538f092846a7b8d368151e3
Story: #2002586
Task: #24309
2018-08-20 18:50:18 +00:00
Zuul
4132b2186a Merge "Fix sort options --sort-key and --sort-dir in list command." 2018-08-16 21:39:19 +00:00
Goutham Pacha Ravi
e7fa7cd158 Fix functional tests
Manila's ci scripts disable configuring the
default share and share group types if testing
with the dummy driver.

We want to continue using the the default types
mechanism in python-manilaclient, until we decide
not to.

Change-Id: I14544bea728286eeb33461e724d991fe556a4269
Closes-Bug: #1787292
2018-08-16 04:48:44 +00:00
deepak_mourya
7b816ceb03 Fix sort options --sort-key and --sort-dir in list command.
Previously manila list --sort_key name command sort on
the basis of id instead of name. This PS will fix the
issue and sort the list in terms of name key.

Change-Id: If96162b5269a5a385de9c72c4cef2b335e5c24ff
Closes-Bug: #1777849
Closes-Bug: #1779935
2018-08-08 05:39:42 +00:00
deepak_mourya
6d4e4a80c3 Fix type-show command with name
This Patch will fix the type-show command
with name.

Change-Id: I86976221995c2ed3ce43041c0f7bfd8cd13e4d0d
Closes-Bug: #1782672
2018-08-06 04:34:51 +00:00
Zuul
649030eff9 Merge "Replace unicode with six.text_type" 2018-08-02 12:58:46 +00:00
Zuul
32e1fa93c5 Merge "Update reno for stable/rocky" 2018-08-02 12:16:14 +00:00
Tom Barron
7facff7cb9 Loosen docutils requirement pin
https://review.openstack.org/#/c/573474 introduced a
problematic pinned requirement for docutils==0.11
which can't be supported across the various distros
that we need to support.

Change the requirement from strict equality to
greater-than-or-equal.

Change-Id: I92fcf6a516339a660395e5cd48e0a496158447e8
2018-07-27 17:55:15 -04:00
443c26596f Update reno for stable/rocky
Change-Id: Ic3dc37467b35cba040068a0db646509fe4662b4c
2018-07-27 13:13:22 +00:00
lijunbo
ecbe1f961c Fix is_default value is empty issue when create
When we use manila client to create a share type or share group
type, the is_default value is always empty, this patch is to fix
this issue.

Depends-On: Ia8bcb632591fc0b5438847b22ec59c2039ecf5f1
Change-Id: Ib264d8422fe57701f990cbbf7ea5d1e90b8b0008
Closes-bug: #1743941
1.24.0
2018-07-26 19:59:53 -07:00
Zuul
106c2753c6 Merge "Support metadata for access rule resource" 2018-07-21 19:10:08 +00:00
zhongjun2
1aa12eb2f8 Support metadata for access rule resource
Now only share have metadata property.
We should support it for access rule as well.

Depends-On: https://review.openstack.org/#/c/570708/
Change-Id: I41b2882ecd16ed03bece05a7a77a387c9077bf5c
Partly-Implements: bp metadata-for-access-rule
2018-07-20 08:01:44 +00:00
junboli
a94c76df1c Fix using column reports nothing for capabilities
1. Fix manila pool-list --column reports nothing for
   capabilities
2. Format the result of manila pool-list --detail

Change-Id: I09bab5a3eaa28e6773afdfc2ac0b99295d725cc1
Closes-bug: #1717940
2018-07-19 10:47:13 +08:00
Vu Cong Tuan
bfeb995fb9 Replace unicode with six.text_type
The unicode() built-in does not exist under Python 3 so use
six.text_type, which is set correctly to str or unicode, instead.

Change-Id: I4e2a4b10dfaa8703525df7d5a6892487698657da
2018-07-05 11:22:39 +07:00
wu.chunyang
270266b791 Add release note link in README
TrivialFix

Change-Id: I38f119e50b111c634729af72a3843978743d3fe7
2018-06-28 11:51:23 +00:00
Zuul
d024c55f57 Merge "Fix allow the use of blank in user group name to access the share" 2018-06-25 18:11:55 +00:00
Zuul
067a4f669e Merge "fix tox python3 overrides" 2018-06-25 18:11:48 +00:00
Zuul
8ffe276b60 Merge "Remove PyPI downloads" 2018-06-20 14:21:09 +00:00
Zuul
d3e6463390 Merge "Delete unused files to increase test coverage" 2018-06-20 07:35:32 +00:00
Zuul
e1b864d0d4 Merge "Increase coverage test" 2018-06-20 07:01:08 +00:00
junboli
f09bb609ce Add check to the flake8 job
Follow up recommendation of [1].
[1] http://lists.openstack.org/pipermail/openstack-dev/2018-June/131233.html

Change-Id: I76dc4f9ec1b71a5bd4ce1d551d2c96cb98448c3a
2018-06-08 09:09:19 +08:00
Chen
71ce15e492 Remove PyPI downloads
According to official site,
https://packaging.python.org/guides/analyzing-pypi-package-downloads/
PyPI package download statistics is no longer maintained and thus
should be removed.

Change-Id: I4b5ac033e57f486d710c394a51e012fa8adabab3
2018-06-07 22:38:41 +08:00
Doug Hellmann
fe0d78ca2e fix tox python3 overrides
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.

We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.

We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.

Change-Id: I81fd5d0161c6ed1b789cd62c3a882fe375c9a2a2
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2018-06-06 17:58:18 -04:00
junboli
b0b08cc650 allow '--help' to print subcomands info
Currently, we only allow $manila help subcomand to print
subcomands info, if we are using $manila subcomand --help,
it will print all the subcomands info, that is not what we
want, this change is to allow '--help' to print subcomands
info. finally we can see the following comands are equals:

$ manila --help list
$ manila list --help
$ manila help list

Change-Id: I926defd6c5d3b8d87b038e2c63db694b40a88359
Close-bug: #1771097
1.23.0
2018-05-23 10:33:49 +08:00
junboli
b7f21d9d7d Delete unused files to increase test coverage
auth.py, client.py, fake_client.py are unused in manilaclient,
delete these files to increase the test coverage from 77% to 80%

Change-Id: I734b79f6aa24b4b002047c74a5ef76d19700f200
2018-05-21 20:49:25 +08:00
junboli
d6ea79fa64 Increase coverage test
Add manila v2 limit unittest to increase coverage
test.

Change-Id: I0c8e0fa78bac8ec87e5bc3235d7e66d7b2a3a864
Partial-Bug: #1364800
2018-05-21 18:51:25 +08:00
Zuul
a5b63f32a1 Merge "Support filter search for share type API" 2018-05-14 12:49:54 +00:00
Zuul
4ef6ae8b08 Merge "Mark functional tests passwords as secrets" 2018-05-08 21:56:09 +00:00
Zuul
a66d95d8d3 Merge "Switch to use stestr instead of testr" 2018-05-08 16:08:48 +00:00
junboli
73315f2a89 Switch to use stestr instead of testr
os-testr has moved over to use stestr instead of testr. While this
is usually compatible with existing settings, there is a warning
that is emitted when .stestr.conf is not present. It is usually
able to fall back to parsing the .testr.conf file, but to be more
correct and to prevent future problems we should update the config.

Change-Id: I10446c539aaf9edd8b52b17776e08c12757def31
Depends-On: I98a296d009e64d6afab02a53bd1af878f78c4321
2018-05-07 22:24:34 +08:00
junboli
50a1ef6e65 Support filter search for share type API
Since manila server allows filter search extra_specs and is_public,
so it's better to add this in manila client as well.

Change-Id: Ie85a7c09d4d7c6ddc31adb5125feea265ad8fced
Depends-On: Id577ae9d08dc0fae3dcac78d98ec0456f8378417
Partially-Implements: blueprint support-filter-search-for-share-type
2018-05-07 21:55:08 +08:00
junboli
9dad727aef Fix failed to import test module
The wrap @testtools.skipUnless cause the base class
SnapshotAccessReadBase to be the <type 'function'>,
However, it should be <type 'type'>, this cause the
functional test unbale to import the test module.

Closes-bug: #1769633
Change-Id: I98a296d009e64d6afab02a53bd1af878f78c4321
2018-05-07 03:58:49 +08:00
Zuul
4197a71623 Merge "Trivial: Update pypi url to new url" 2018-05-01 16:14:33 +00:00
Vladyslav Drok
66ef564036 Mark functional tests passwords as secrets
Just in case these values are being logged somewhere.

Change-Id: I6126b5b362dd2b89292d348ae58639d087d5a63b
2018-04-25 14:27:43 +00:00
Vladyslav Drok
2af3e1e539 Remove fake_client module as it is unused
Change-Id: Id42cbd2ed767f3a0118fc4591ad059b3edccc97b
2018-04-25 14:27:01 +00:00