844 Commits

Author SHA1 Message Date
kuangcx
b8305862d7 Remove install unnecessary package
The docs  requirements migrated to doc/requirements.txt
we need not install things from requirements.txt.

Change-Id: Ice2f40eb8856bb5869b621725e5918560d843e06
2020-09-25 11:04:46 +08:00
3cac584e70 Add Python3 wallaby unit tests
This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for wallaby.

See also the PTI in governance [1].

[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html

Change-Id: I47ec3b6d5cdc8228d0f6e2353a0e6eafe2aa7b76
2020-09-11 15:46:01 +00:00
550251c14c Update master for stable/victoria
Add file to the reno documentation build to show release notes for
stable/victoria.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/victoria.

Change-Id: I74a9a463774bad1dffa09bb810625539f703c834
Sem-Ver: feature
2020-09-11 15:45:56 +00:00
Zuul
c267433c2d Merge "Add commands for share server migration" 2020-09-11 14:24:19 +00:00
Zuul
3b56d6fe7a Merge "Implement the first half of OSC share snapshots commands" 2020-09-10 18:56:57 +00:00
Maari Tamm
f4ca71be0d Implement the first half of OSC share snapshots commands
In this patch we add openstack commands for:
share snapshot create
share snapshot delete
share snapshot show
share snapshot set
share snapshot unset
share snapshot list

Partially-implements bp openstack-client-support

Change-Id: Idfe2033016f333da0169fd032ff95bf868099f70
2020-09-10 16:52:34 +00:00
Zuul
405ca1333e Merge "Implement OSC share quota commands" 2020-09-10 15:52:06 +00:00
Felipe Rodrigues
edf064a335 Add commands for share server migration
Implements the commands for performing the share server migration.
They are: share-server-migration-reset-task-state,
share-server-migration-complete, share-server-migration-cancel,
share-server-migration-start, share-server-migration-check
and share-server-migration-get-progress.

Co-Authored-By: Daniel Tapia <danielarthurt@gmail.com>
Co-Authored-By: Andre Beltrami <debeltrami@gmail.com>
Co-Authored-By: Douglas Viroel <viroel@gmail.com>

Change-Id: Id829a375d828a4808306fd1a42bc7548721feb19
Partially-implements: bp share-server-migration
Depends-On: Ic0751027d2c3f1ef7ab0f7836baff3070a230cfd
Depends-On: I46a0cee0a4625d950f02fa7a5bf612de926451b5
2020-09-10 07:40:32 -03:00
Goutham Pacha Ravi
399c0c4fb5 Add noqa markup to intentionally redefined methods
Testing has migrated to focal and python3.8;
and we get F811 errors on the microversioned
and hence redefined methods

E.g.:
F811 redefinition of unused 'list' from line 37
Closes-Bug: #1886298

Change-Id: I065b15f9b81036727ce9bdeae5f34c473d14d10c
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
2020-09-09 13:18:02 -07:00
Maari Tamm
beb8409e7f Implement OSC share quota commands
In this patch we add openstack commands for:
share quota set
share quota show
share quota delete

Change-Id: I3520feec09a6c491f436809a5f620efce1b1f8c2
Partially-implements: bp openstack-client-support
2020-09-09 16:16:58 +00:00
silvacarloss
afcedeb840 Graduate share replication feature
Removes the experimental mentions from share replication feature
commands.

Partially-implements: bp graduate-share-replication-feature
Depends-On: Idf8af1c96df373fbcbb4024db490cb4dab42faf7
Change-Id: Ie7f823dfc86f4d8e4545228dab48cd5cb26a257c
2020-09-08 21:04:05 +00:00
Ghanshyam Mann
a68aaab172 [goal] Migrate testing to ubuntu focal
As per victoria cycle testing runtime and community goal[1]
we need to migrate upstream CI/CD to Ubuntu Focal(20.04).

Fixing:
- bug#1886298
Bump the lower constraints for required deps which added python3.8
support in their later version.

- noqa for pep8 F811 check.

Closes-Bug: #1886298

Story: #2007865
Task: #40194

[1] https://governance.openstack.org/tc/goals/selected/victoria/migrate-ci-cd-jobs-to-ubuntu-focal

Change-Id: Id8300f4dbde7e59b8d6275b0671328e35670312c
2020-09-06 00:49:59 +00:00
Maari Tamm
b4c06ef1d1 Improve OSC test coverage
In this patch we add some unit tests for exception cases
to improve overall test coverage. Tests added:
test_share_set_visibility_exception
test_share_set_property_exception
test_share_unset_name_exception
test_share_unset_property_exception

Change-Id: I7604da8943dca8f3eada7c5ac1311086772f41a5
Partially-implements: bp openstack-client-support
2020-08-04 10:03:54 +00:00
Zuul
9881dfc77c Merge "Use unittest.mock instead of third party lib" 2020-07-16 19:24:11 +00:00
Maari Tamm
8b74211d76 Add initial documentation for OSC
This patch creates initial documentation for OSC, with
general plugin information and a few examples.
New commands, that are implemented, should be then
referenced in doc/source/cli/osc/v2/index.rst

Change-Id: I6fa9fcb3cf41a2992a4b5c7b38c54825106e9ce5
Partially-implements: bp openstack-client-support
2020-07-03 20:27:53 +00:00
Maari Tamm
126c82a2ae Implement OSC share resize command
In this patch we add the 'openstack share resize' command.
This command combines 'manila shrink' and 'manila extend' commands
into one and can be used to change the size of a share.

usage: openstack share resize <share> <new-size>

Change-Id: I052977f689ad4c1e9fb5f63d773519cd880c5b6c
Partially-implements: bp openstack-client-support
2020-06-30 19:25:46 +00:00
Goutham Pacha Ravi
d65d7f05a7 Migrate functional job to native zuulv3
The manilaclient functional test job
"manilaclient-dsvm-neutron-functional"
is currently broken due to a change to its
parent job in the devstack repository.

Instead of investing to fix that legacy style
job, we'd be better off rewriting it to be
in native zuulv3 style, i.e., without the
use of the deprecated devstack-gate project.

- Introduce a new job "python-manilaclient-functional"
  which replaces "manilaclient-dsvm-neutron-functional"
  but preserves the testing done by the latter.
- The new job runs on a minimal devstack (keystone,
  neutron, manila, mysql and rabbit) and uses an ansible
  role introduced to setup test configuration.
- Add a "bindep.txt" file to call out test system
  dependencies, and install them via the new job.
- Cleanup the old job, the associated devstack gate
  hooks and playbooks.

Change-Id: I3b67f3b566bdadf1cc228f885b7253435a4507b5
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
2020-06-30 17:25:46 +00:00
Goutham Pacha Ravi
2d4df937d5 Use unittest.mock instead of third party lib
mock was adopted into standard python
in version 3.3 [1]. Since python-manilaclient
no longer supports python2.7, we can use the inbuilt
mock package rather than the third party
lib.

Also fix some issues with imports that
weren't following our import conventions
of grouping imports [3]

[1] https://docs.python.org/3/library/unittest.mock.html
[2] http://lists.openstack.org/pipermail/openstack-discuss/2020-March/013281.html
[3] https://docs.openstack.org/hacking/latest/user/hacking.html#imports

Change-Id: I3e199e1a117ddf7739fce8858694a801a26ed08f
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
2020-06-22 17:26:26 -07:00
Zuul
9613c7fd26 Merge "Switch to newer openstackdocstheme and reno versions" 2020-05-22 21:42:56 +00:00
Andreas Jaeger
1721e2871d Switch to newer openstackdocstheme and reno versions
Switch to openstackdocstheme 2.2.1 and reno 3.1.0 versions. Using
these versions will allow especially:
* Linking from HTML to PDF document
* Allow parallel building of documents
* Fix some rendering problems

Update Sphinx version as well.

Remove docs requirements from lower-constraints, they are not needed
during install or test but only for docs building.

openstackdocstheme renames some variables, so follow the renames
before the next release removes them. A couple of variables are also
not needed anymore, remove them.

Set openstackdocs_pdf_link to link to PDF file. Note that
the link to the published document only works on docs.openstack.org
where the PDF file is placed in the top-level html directory. The
site-preview places the PDF in a pdf directory.

Set openstackdocs_auto_name to use 'project' as name.

Change pygments_style to 'native' since old theme version always used
'native' and the theme now respects the setting and using 'sphinx' can
lead to some strange rendering.

See also
http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014971.html

Change-Id: I1d02403727831c29f3a38cfc11949325614ac7d0
2020-05-22 17:23:00 +00:00
Zuul
6b4de51a64 Merge "TrivialFix: Remove unnecessary future imports" 2020-05-20 06:31:44 +00:00
Ghanshyam Mann
96ef4f5cf1 Fix hacking min version to 3.0.1
flake8 new release 3.8.0 added new checks and gate pep8
job start failing. hacking 3.0.1 fix the pinning of flake8 to
avoid bringing in a new version with new checks.

Though it is fixed in latest hacking but 2.0 and 3.0 has cap for
flake8 as <4.0.0 which mean flake8 new version 3.9.0 can also
break the pep8 job if new check are added.

To avoid similar gate break in future, we need to bump the hacking min
version.

- http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014828.html

Change-Id: Ibe524fb12fe41de8a825e7b06647afb6c463deba
2020-05-12 19:32:36 -05:00
Goutham Pacha Ravi
33a2ea9e97 TrivialFix: Remove unnecessary future imports
print_function has been available since python 3.0.0
We can drop its import from __future__

Change-Id: I5f8c45c85ba66d29dc89ee6c0589044e413a549c
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
2020-05-05 08:44:02 -07:00
Zuul
2dc01fc3d3 Merge "Replace "tenant" terminology with "project"" 2020-04-29 16:56:04 +00:00
Goutham Pacha Ravi
3c88e82871 [ussuri][goal] Change contributor guide
- Add a top level CONTRIBUTING.rst for
  repo browsers
- Refactor existing contributor guide
- Add a contributor/contributing.rst file
  with links back to relevant manila
  documentation.
- Rearrange some things in the main doc
  index file to make things prettier.

Change-Id: I68ea17a71c4ea1e7aac5bea1ec8b95344cb256b7
Story: #2007236
Task: #39553
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
2020-04-24 16:49:52 -07:00
Sean McGinnis
3d4f0ba07d
Add py38 package metadata
Now that we are running the Victoria tests that include a
voting py38, we can now add the Python 3.8 metadata to the
package information to reflect that support.

Change-Id: Id0c402a1a9fb3375bf7ba07dbcc4ee7a108e1dc4
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2020-04-24 10:30:35 -05:00
Goutham Pacha Ravi
cdff009da1 Drop install_command usage in tox
Use the default value provided by tox:

https://tox.readthedocs.io/en/latest/config.html#conf-install_command

See discussion on the openstack-discuss ML [1]
for the complete context.

[1] http://lists.openstack.org/pipermail/openstack-discuss/2020-April/014237.html

Change-Id: I6344f44fb955d631a4f0a13fa53ecc19826c7ea6
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
2020-04-22 18:25:56 -07:00
4cfef05a61 Add Python3 victoria unit tests
This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for victoria.

See also the PTI in governance [1].

[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html

Change-Id: I1276998fa0577fce0b1fe793e08a76aab14358ce
2020-04-10 18:11:34 +00:00
cbdaf8089e Update master for stable/ussuri
Add file to the reno documentation build to show release notes for
stable/ussuri.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/ussuri.

Change-Id: I1df78551c90cd3578a558409c0cc308b9b4e8f84
Sem-Ver: feature
2020-04-10 18:11:32 +00:00
silvacarloss
3371c54303 Remove experimental flag from share groups commands
- Removed all experimental mentions from share group feature
  commands.

Depends-On: I080683541d527657f01008d43529fc53c19a09cd
Change-Id: I585c9c845851fcd581e08b0084fc2528b85cd632
Partially-Implements: bp graduate-share-groups-feature
2020-04-09 22:04:54 +00:00
andrebeltrami
8d2718da8c Update the python manila client api version
This patch updates the python manila client
api version in order to consider the changes
implemented in the view of shares and share
replicas. A new field called ``progress`` was
added and will show the progress of the
create share from snapshot operation.

Partially-implements: bp create-share-from-snapshot-in-another-pool-or-backend

Depends-On: Iab13a0961eb4a387a502246e5d4b79bc9046e04b

Change-Id: Id73f6facca03e8490846b68c404593f16e95f8bd
2020-04-09 00:46:28 -03:00
Zuul
b7b7d9a02f Merge "Add new share replica quotas to the CLI" 2020-04-08 14:45:57 +00:00
silvacarloss
a0cbed52ed Add new share replica quotas to the CLI
- Added support to two new quotas for share replicas, being
  `share_replicas` and `replica_gigabytes`.

Depends-On: I8ba7bc6f167c28d6c169b2187d0e1bda7cad3f69
Partially-Implements: bp limit-share-replicas-per-share
Change-Id: I700adc0cb64e03ef66cf7123601a406891d526f2
2020-04-08 03:35:33 +00:00
Goutham Pacha Ravi
2a88672968 Replace "tenant" terminology with "project"
This change affects all the help text and
provides command line aliases to the usage
of "tenant" on the manila v2 shell.

Change-Id: Ia0b0a675257ebabecb7dd571a5417d8ad981254b
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
2020-04-07 08:08:47 -07:00
Andreas Jaeger
9004a32d33 Cleanup py27 support
Make a few cleanups:
- Remove python 2.7 stanza from setup.py
- Add requires on python >= 3.6 to setup.cfg so that pypi and pip
  know about the requirement
- Remove obsolete sections from setup.cfg: Wheel is not needed for python
  3 only repo
- Update requirements, no need for python_version anymore
- Remove old variables from conf.py, update openstackdocstheme
  requirement.
- Remove hacking and friends from lower-constraints, they are
  not needed in installed system.

Change-Id: I179d61545169f3d329c746c88dd4d38035d4075d
2020-04-04 11:30:07 +02:00
Zuul
1e3f4002e4 Merge "Support query user message by timestamp" 2020-04-03 20:37:36 +00:00
haixin
4c87b940d9 Support query user message by timestamp
add created_since and created_before to message-list API.

Depends-On: I3d94bac4304c236f275abe7ce31432b0e2384247
Change-Id: I91d00888d71aa3bc4a8c9aaa4d2a3e9d23d19286
Partially-Implements: blueprint query-user-message-by-timestamp
2020-04-01 09:49:19 +08:00
Andreas Jaeger
7cf94c6527 Update hacking for Python3
The repo is Python 3 now, so update hacking to version 3.0 which
supports Python 3.

Fix found problems.

Change-Id: I78ee32da2b158abda1ca4438c23c5245dd8849b2
2020-03-30 10:04:29 +00:00
Maari Tamm
e3652b9c1c Implement OSC share type commands
In this patch we add openstack commands for:
share type create
share type delete
share type set
share type unset
share type list
share type show
share type access create
share type access list
share type access delete

These commands can be used to replace all “manila type-” commands.
“openstack share type set” combines “manila type-key” with
“manila type-update” commands and can be used to set name, description,
visibility and extra specs.

Change-Id: I10cb6ea800908ebbe48eae7ba8c18680249ff1d2
Partially-implements: bp openstack-client-support
2020-03-09 09:18:46 +00:00
Maari Tamm
9fc3723de8 Implement OSC share access rules commands
In this patch we add openstack commands for:
share access create
share access delete
share access list
share access show
share access set
share access unset

These commands can be used to replace all 'manila access-...' commands.
'manila access-metadata' is replaced by:
'openstack share access set --property <key=value>' and
'openstack share access unset --property <key>'

Change-Id: Id2bd92bcb629905c7db12951d6e4ebe2d5b4d916
Partially-implements: bp openstack-client-support
2020-03-03 02:10:28 +00:00
Maari Tamm
134f07af6d Add functional tests for OSC
In this patch we create the base for osc functional testing
and add tests for 'openstack share' commands that are currently
implemented.

Change-Id: I3732229e4a61182a80f6f35ad7050075db84f6ce
Partially-implements: bp openstack-client-support
2020-02-28 08:26:05 +00:00
Zuul
3beec44af2 Merge "Implement osc share set/unset commands" 2020-02-20 13:44:54 +00:00
Maari Tamm
1729888857 Implement osc share set/unset commands
In this patch set we add the implementation
for openstack share set and openstack share unset command.
These commands are used to change share properties
and replace the manila update and manila metadata commands.

Partially-implements: bp openstack-client-support
Change-Id: Ic09802fa5dc9c7f0180341397c2740ac0cadbcd4
2020-02-19 07:58:58 +00:00
Spyros Trigazis
d9e6f2787f OSC Fix list for all projects
The manila api accepts all_tenants as a parametes
in the API. Users can send --all-projects via OSC
and the client translates to all_tenants.

Change-Id: I5f9e685659160e676e70281e8f258a19b6133bfa
Partially-implements: bp openstack-client-support
Signed-off-by: Spyros Trigazis <spyridon.trigazis@cern.ch>
2020-02-17 11:37:01 +01:00
Victoria Martinez de la Cruz
6bccfc0d6e Put osc unit tests with all other unit tests
Having osc in an upper level module meant that
all osc unit tests were not being run.

We had two options: either create a new job purely
for osc unit tests or put all tests on the same module.

The latter made more sense for simplicity reasons (KISS)

Change-Id: Iabf76d8ac7ef886d736f3e30d466fe3f992287da
2020-02-03 13:39:48 +00:00
Victoria Martinez de la Cruz
ee78e6486a Fix osc delete share and show share tests
Delete one share, force delete one share,
delete many shares and show share unit tests
were broken. Those failures were not caught up
because we were not running tests on our gate.

This patch set fix those tests. The dependeny will
add osc unit tests to main python jobs

Change-Id: I14fe8601b0a9b82d55473a38916b13ded38f4bc5
2020-01-31 18:28:00 +00:00
Zuul
cb6d195988 Merge "[OSC] Init OpenStack Client implementation" 2019-12-19 21:30:24 +00:00
Zuul
0d918d1495 Merge "[ussuri][goal] Drop python2.7 support" 2019-12-13 10:52:34 +00:00
Goutham Pacha Ravi
424fb56f4b [ussuri][goal] Drop python2.7 support
As per the official python support timeline
set forth by the OpenStack TC [1][2], OpenStack
Train (in our case, python-manilaclient 1.29.x
series) is the last release that will support
python2.7.

[1] https://governance.openstack.org/tc/resolutions/20180529-python2-deprecation-timeline.html
[2] https://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html

Change-Id: I5b4dc1853d7e4f8f736dd2a22eb08bcfdeac3411
2019-12-08 21:04:14 -08:00
Goutham Pacha Ravi
ac5ca461e8 [OSC] Init OpenStack Client implementation
Add an OSC plugin for manila, the subcommand
chosen is "share". Add initial commands parser
for create, delete, list and show shares.

Also initializes basic unit testing structure for
the added commands.

Co-Authored-By: Soledad Kuczala <sol.kuczala@gmail.com>
Co-Authored-By: Victoria Martinez de la Cruz <victoria@redhat.com>

Partially-implements: bp openstack-client-support
Change-Id: I90a36f4332796675ea808e0c2a0f5ce32709624a
2019-11-21 09:56:38 +00:00