openstack/python-mistralclient
Code Issues Proposed changes

Update task columns info

Browse Source 
There are two execution_ids, workflow_execution_id and
task_execution_id. To avoid misread, we need this change.

Change-Id: I4ab23f729a634a4ab5af6bfe5adbd042a51ffd43
Signed-off-by: pengdake <19921207pq@gmail.com>
This commit is contained in:
pengdake
2018-05-14 10:42:20 +08:00
parent 8cc76487fd
commit 5dc9935f7e
2 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mistralclient/commands/v2/tasks.py
View File

@@ -33,7 +33,7 @@ class TaskFormatter(object):
('name', 'Name'), ('name', 'Name'),
('workflow_name', 'Workflow name'), ('workflow_name', 'Workflow name'),
('workflow_namespace', 'Workflow namespace'), ('workflow_namespace', 'Workflow namespace'),
('workflow_execution_id', 'Execution ID'), ('workflow_execution_id', 'Workflow Execution ID'),
('state', 'State'), ('state', 'State'),
('state_info', 'State info'), ('state_info', 'State info'),
('created_at', 'Created at'), ('created_at', 'Created at'),

12
mistralclient/tests/functional/cli/v2/cli_tests_v2.py
View File

@@ -61,7 +61,7 @@ class SimpleMistralCLITests(base.MistralCLIAuth):
self.assertTableStruct( self.assertTableStruct(
tasks, tasks,
['ID', 'Name', 'Workflow name', 'Execution ID', 'State'] ['ID', 'Name', 'Workflow name', 'Workflow Execution ID', 'State']
) )
def test_cron_trigger_list(self): def test_cron_trigger_list(self):
@@ -1101,7 +1101,8 @@ class TaskCLITests(base_v2.MistralClientTestBase):
fetched_task, fetched_task,
'Workflow namespace' 'Workflow namespace'
) )
task_execution_id = self.get_field_value(fetched_task, 'Execution ID') task_execution_id = self.get_field_value(fetched_task,
'Workflow Execution ID')
self.assertEqual(created_task_id, fetched_task_id) self.assertEqual(created_task_id, fetched_task_id)
self.assertEqual('', fetched_task_wf_namespace) self.assertEqual('', fetched_task_wf_namespace)
@@ -1127,7 +1128,8 @@ class TaskCLITests(base_v2.MistralClientTestBase):
fetched_task, fetched_task,
'Workflow namespace' 'Workflow namespace'
) )
task_execution_id = self.get_field_value(fetched_task, 'Execution ID') task_execution_id = self.get_field_value(fetched_task,
'Workflow Execution ID')
self.assertEqual(created_task_id, fetched_task_id) self.assertEqual(created_task_id, fetched_task_id)
self.assertEqual(namespace, created_wf_namespace) self.assertEqual(namespace, created_wf_namespace)
@@ -1148,7 +1150,7 @@ class TaskCLITests(base_v2.MistralClientTestBase):
self.assertTableStruct( self.assertTableStruct(
tasks, tasks,
['ID', 'Name', 'Workflow name', 'Execution ID', 'State'] ['ID', 'Name', 'Workflow name', 'Workflow Execution ID', 'State']
) )
self.assertEqual(2, len(tasks)) self.assertEqual(2, len(tasks))
@@ -1163,7 +1165,7 @@ class TaskCLITests(base_v2.MistralClientTestBase):
self.assertTableStruct( self.assertTableStruct(
tasks, tasks,
['ID', 'Name', 'Workflow name', 'Execution ID', 'State'] ['ID', 'Name', 'Workflow name', 'Workflow Execution ID', 'State']
) )
self.assertEqual(1, len(tasks)) self.assertEqual(1, len(tasks))