openstack/python-mistralclient
Code Issues Proposed changes

Clean imports in code

Browse Source 
In some part in the code we import objects. In the Openstack style guidelines
they recommend to import only modules. [1]: "Do not import objects, only modules".

[1] https://docs.openstack.org/hacking/0.10.3/

Change-Id: I90ae12639be39b72bac7907cbd71182f44dae02d
This commit is contained in:
Nguyen Hung Phuong
2018-02-21 17:45:25 +07:00
parent a3a16823a6
commit 8857acc614
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
mistralclient/tests/unit/v2/test_cli_action_execs.py
View File

@@ -18,7 +18,7 @@ import copy
import json import json
import sys import sys
from six import StringIO import six
import mock import mock
@@ -160,7 +160,7 @@ class TestCLIActionExecutions(base.BaseCommandTest):
# Redirect the stderr so it doesn't show during tox # Redirect the stderr so it doesn't show during tox
_stderr = sys.stderr _stderr = sys.stderr
sys.stderr = StringIO() sys.stderr = six.StringIO()
for state in states: for state in states:
self.assertRaises( self.assertRaises(

3
mistralclient/tests/unit/v2/test_cli_tasks.py
View File

@@ -21,7 +21,6 @@ import mock
from mistralclient.api.v2 import tasks from mistralclient.api.v2 import tasks
from mistralclient.commands.v2 import tasks as task_cmd from mistralclient.commands.v2 import tasks as task_cmd
from mistralclient.commands.v2.tasks import TaskFormatter
from mistralclient.tests.unit import base from mistralclient.tests.unit import base
TASK_DICT = { TASK_DICT = {
@@ -62,7 +61,7 @@ class TestCLITasksV2(base.BaseCommandTest):
self.assertEqual([EXPECTED_TASK_RESULT], result[1]) self.assertEqual([EXPECTED_TASK_RESULT], result[1])
self.assertEqual( self.assertEqual(
self.client.tasks.list.call_args[1]["fields"], self.client.tasks.list.call_args[1]["fields"],
TaskFormatter.COLUMN_FIELD_NAMES task_cmd.TaskFormatter.COLUMN_FIELD_NAMES
) )
def test_list_with_workflow_execution(self): def test_list_with_workflow_execution(self):