openstack/python-neutronclient
Code Issues Proposed changes

Do not check stderr output from shell

Browse Source 
The output from shell commands may contain warning messages which are
not errors. There are cases where there is nothing neutronclient can
do to avoid, for example, depecration messages.

The ShellTest.shell() already checks for SystemExit result codes, so
asserting that stderr is empty is not needed.

Change-Id: Ibeabf474194b2d38273d76117a3a2f3bee5f7286
This commit is contained in:
Henry Gessau
2016-08-17 04:44:32 -04:00
parent 618bc69660
commit a16135029a
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
neutronclient/tests/unit/test_shell.py
View File

@@ -102,7 +102,6 @@ class ShellTest(testtools.TestCase):
self.assertThat(
help_text,
matchers.MatchesRegex(required))
self.assertFalse(stderr)
def test_bash_completion(self):
required = '.*os_user_domain_id.*'
@@ -110,7 +109,6 @@ class ShellTest(testtools.TestCase):
self.assertThat(
bash_completion,
matchers.MatchesRegex(required))
self.assertFalse(stderr)
def test_help_on_subcommand(self):
required = [
@@ -120,7 +118,6 @@ class ShellTest(testtools.TestCase):
self.assertThat(
stdout,
matchers.MatchesRegex(r, re.DOTALL | re.MULTILINE))
self.assertFalse(stderr)
def test_help_command(self):
required = 'usage:'
@@ -128,11 +125,9 @@ class ShellTest(testtools.TestCase):
self.assertThat(
help_text,
matchers.MatchesRegex(required))
self.assertFalse(stderr)
def test_bash_completion_in_outputs_of_help_command(self):
help_text, stderr = self.shell('help')
self.assertFalse(stderr)
completion_cmd = "bash-completion"
completion_help_str = ("Prints all of the commands and options "
"for bash-completion.")
@@ -146,7 +141,6 @@ class ShellTest(testtools.TestCase):
'.*help',
'.*--dns-nameserver']
help_text, stderr = self.shell('neutron bash-completion')
self.assertFalse(stderr)
for r in required:
self.assertThat(help_text,
matchers.MatchesRegex(r, re.DOTALL | re.MULTILINE))