openstack/python-neutronclient
Code Issues Proposed changes

Remove incorrect super() call

Browse Source 
extension.ShowExt.get_parser called super() with the *parent* class,
skipping the parent's own get_parser.  This is quite surprising without
any additional comments to explain the situation.

The only difference between the two get_parsers is the string that
appears in the usage help text (EXT_ALIAS vs EXTENSION).  Rather than
improve the above super() call, this change removes the specialised
ShowExt.get_parser() implementation entirely since it appears the
generic version is sufficient.

Change-Id: I76b901d6a27fbe6f103baf2f03ea17912123a46b
This commit is contained in:
Angus Lees 2014-08-12 15:36:54 +10:00
parent 03c6d6a98e
commit e254392e7d
1 changed files with 0 additions and 9 deletions

9
neutronclient/neutron/v2_0/extension.py

@ -15,7 +15,6 @@
# #
from neutronclient.neutron import v2_0 as cmd_base from neutronclient.neutron import v2_0 as cmd_base
from neutronclient.openstack.common.gettextutils import _
class ListExt(cmd_base.ListCommand): class ListExt(cmd_base.ListCommand):
@ -30,11 +29,3 @@ class ShowExt(cmd_base.ShowCommand):
resource = "extension" resource = "extension"
allow_names = False allow_names = False
def get_parser(self, prog_name):
parser = super(cmd_base.ShowCommand, self).get_parser(prog_name)
cmd_base.add_show_list_common_argument(parser)
parser.add_argument(
'id', metavar='EXT-ALIAS',
help=_('The extension alias.'))
return parser