assertEqual expects that the arguments provided to it should be
(expected, observed).If a particluar order is kept as a convention,
then it helps to provide a cleaner message to the developer if Unit Tests
fail. There are several Unit Test files where the arguments for assertEqual
have been swapped. This commit fixes the issue in python-neutronclient.
Additionally instead of using assertEqual(True,xxx), assertTrue(xxx) should
be used. The same has been fixed in this patch.
Partial-Bug: #1259292
Related-Bug: #1259292
Change-Id: I83ec45af75f61f8005a60efc8176db0df5cfbe9a
We have a hacking rule H105 (Don't use author tags) now
and the same policy has been applied to other neutron repos.
Change-Id: I1a1a35bbfaad6bbe229b9b12cf6cfb405b6ed516
It is a common pattern to add
class XXXCommand(NeutronCommand):
log = logging.getLogger(__name__ + '.<command name>').
So introduce a metaclass to do that automatically in order to simplify
the code a bit.
Closes-Bug: #1258028
Change-Id: I7908e3e2c0f3f04d9e57360f6ba22e153d0d35bd
