Similar to change I10b1bd6d but for help on an argument rather than the
command itself.
Closes-Bug: #1304570
Change-Id: I4f08ffb6af248ccd7446012765d17c41567f4b38
In nova https://review.openstack.org/#/c/39998/ expose an API to delete
a service. Both in V1.1 and V3.
This patch make novaclient support it.
Change-Id: I4aaabc866b464c046b46eda68734f37223c6d6a0
Implements: blueprint support-delete-service
Prior to this patch, novaclient was handling sessions in an inconsistent
manner.
Every time we created a client instance, it would use a global
connection pool, which made it difficult to use in a process that is
meant to be forked.
Obviously sessions like the ones provided by the requests library that
will automatically cause connections to be kept alive should not be
implicit. This patch moves the novaclient back to the age of a single
session-less request call by default, but also adds two more
resource-reuse friendly options that a user needs to be explicit about.
The first one is that both v1_1 and v3 clients can now be used as
context managers,. where the session will be kept open (and thus the
connection kept-alive) for the duration of the with block. This is far
more ideal for a web worker use-case as the session can be made
request-long.
The second one is the per-instance session. This is very similar to what
we had up until now, except it is not a global object so forking is
possible as long as each child instantiates it's own client. The session
once created will be kept open for the duration of the client object
lifetime.
Please note: client instances are not thread safe. As can be seen from
above forking example - if you wish to use threading/multiprocessing,
you *must not* share client instances.
DocImpact
Related-bug: #1247056
Closes-Bug: #1297796
Co-authored-by: Nikola Dipanov <ndipanov@redhat.com>
Change-Id: Id59e48f61bb3f3c6223302355c849e1e99673410
The 'nova rebuild' command did not print the adminPass returned by the
server. This is because it discards the instance information returned
by the rebuild action and fetchs the information again. This would lose
the adminPass and it would not be printed for the user.
This patch reuses the instance information returned by the rebuild action
which ensures that the adminPass is printed by the shell.
Change-Id: I144bfa298bef529c78ca04042cd37a763537f09e
Closes-bug: 1302696
It's not used by novaclient anymore and isn't used by any other
openstack common code either.
Change-Id: I96ebf030d0a96436a8a75c6937c354003ee32c58
Closes-bug: 1280033
The method tests rebuilds with and without passwords, but the tests are
independent and should be in two seperate tests.
Also, remove duplication of the rebuild with password test from
test_rebuild_preserve_ephemeral
Change-Id: I40d0376fabf319dbe703d593de8fb4cdcf0aeab1
When getting floatingips with Nova API, the results will be filtered
with the 'tenant_id'.
So, we can only get the floatingips belonging to the tenant of the current
context.
When ceilometer invokes novaclient to list floatingips, it will get an
empty list because the tenant is 'service'.
we should allow an admin user to index all tenants's floatingip by adding a
parameter 'all_tenants'.
This patch provides CLI support
Change-Id: I35a2155401247d49017bf3c03341b082cb87750d
Closes-bug: #1262124
Switch to using network_utils for splitting the URL. The code
in oslo-incubator supports ipv6 urls
HEAD of oslo-incubator is bb52a3fc49f033b9f36238231ca56e754a78cf4b
Updated openstack-common.conf to pick up the new dependency from
oslo-incubator
Change-Id: Ifa3dec384e85942a191260d17e8141030d31ff84
Closes-Bug: #1298137
reservation_id, min_count, max_count are never specified by any callers.
Remove the arguments and the code that checks the values.
Change-Id: I3794fd1eabbfb999c422c701af1ff64cd667313f
oslo-incubator HEAD was 2eab986ef3c43f8d1e25065e3cbc1307860c25c7
This change brings in a few minor updates to python3 and a bug fix
for deep copy failure in gettextutils.
Change-Id: Id360f3b43d1ad2f67b328206990dd6bdb53c1cd7
Python 3 changed the map built-in to return an iterable instead of a list.
When tested in a boolean context, this always returns True, even if it
would not return anything when iterated.
Instead of the usage being printed, this error was printed:
ERROR: 'Namespace' object has no attribute 'func'
Use list comprehension instead to ensure that an iterable isn't returned
Change-Id: Ie15f2fa8ee93ab26490e371133fa0f944430737b
Closes-bug: 1295356
servers.Server represents various object now, and some of them may
don't have attribute 'name', for example, the interface_list() result
object. It will cause AttributeError when we try to format string with
such object, so I add a check for the 'name' attribute in __repr__
method, it will use 'unknown-name' instead when 'name' is not found.
Change-Id: If4757d5d73721774543d58a4cc875710a6013f34
Closes-Bug: #1280453
When running nova boot --poll, any error states that occur will be
seen but, an exit code of 0 will be returned indicating success.
This would be problematic for scripts looking to see if an
operation completed successfully.
To fix this, an exception is raised after the nova api indicates to the
poll code that the vm is in an error state. The exceptions signals the shell
main function to exit with code 1.
Change-Id: I48f6b1c82e2f8b221dda898dcb804b0196018505
Fixes-Bug: #1292669
If a server error is returned that has an unknown code, novaclient will
end up printing something similar to:
ClientException: <attribute 'message' of 'exceptions.BaseException' objects>
Setting a message for ClientException will ensure that something more
useful than that is printed.
Change-Id: I43a2a33017f9a5c1b79d7fd8af4153e91d296f7b
Closes-bug: 1295293
Currently, when the CLI encounters an exception, only the exception
message is shown. However, the name of the exception can be quite
informative as well.
For instance, an error message might read "Cannot do xyz", which
simply indicates the operation was unsucessful. However, the attached
exception name (HTTPNotImplemented, for instance) indicates the
*reason* that the call was unsuccessful.
Change-Id: I0298477bd9d40d98c95bb797c68c47dbc952b345
A recent release of setuptools appears to have introduced a bug that
causes the pypy gate tests to fail. This applies a temporary workaround
that should restore pypy testing while the root cause of the problem is
researched.
Change-Id: I66597e40c1d2e57cca1292844d228af85214197d
Partial-Bug: 1290562
When nova uses neutron, IPv6 addresses may be allocated. This ensures
those addresses are supported.the patch to modify nova is
https://review.openstack.org/#/c/74252/
Change-Id: I2468d3bcaca9122e5d3f9c98044d57f623630dc3
Closes-bug: #1267685