These were deprecated in Newton:
aaebeb05a03e34281a091dc6dfc4672b01cdfbbb
Since this is the last of the deprecated contrib extensions,
we can also deprecate the 'only_contrib' parameter from the
novaclient.client.discover_extensions method.
Change-Id: Ie2e3fdc4e044f6eb304724d16a7d0f1f7ba705fd
These were all deprecated in Newton with change:
87c1b5311b2e641564305a4753b989b6498775b1
So now we can remove them.
Change-Id: Ic74a989b8a6565cc52ab82440fab8605a4b78e6b
Currently only py27 and py35 (not py34) is tested in the gate, so
py34 should no longer be part of the tox environment or part of the
PyPi classifier.
Change-Id: I81058c5df47c4dae3c331d0030141896b6a9f1bb
The name and availability_zone arguments to aggregate update were
replaced by optional parameters in change
I778ab7ec54a376c60f19dcc89fe62fcab6e59e42. However, the '--name' and
'name' arguments in the parser would conflict, resulting in only the
deprecated argument working. Thus, attempting to update the name
on an aggregate using --name would end up doing a PUT with no new
name provided.
Note that there were unit tests for this, but they were not catching
this problem. So, this removes those tests and adds functional tests
to poke it.
Change-Id: Ifef6fdc1a737dd219712a4525d4e34afd3fbd80c
Closes-Bug: #1673789
With pbr 2.0 and Sphinx 1.5, the setting for treat sphinx warnings as
errors is setting warning-is-error in build_sphinx section. Migrate the
setting from the old warnerrors one.
There are only three related fixes required.
Change-Id: I84b020c18a8a1c7c11a35bacd61523bbb094abe4
If you pass incorrect formatted metadata to the 'boot', 'rebuild'
and 'image-create' apis returns following error:
ERROR (ValueError): dictionary update sequence element #0 has
length 1; 2 is required
Caught the ValuError and raised argparse.ArgumentTypeError with
proper error message.
Closes-Bug: #1668549
Change-Id: I14a30b93f4a916fc04610f9e475c12eb352e38c5
Currently, Tags(list) and Metadata(dict) fields of instance will
firstly transformed to str using jsondump first when display. And
cannot be correctly transfomed and displayed afterwards.
This patch adds ensure_ascii=False to the transform function thus
those fields can be correctly tranformed and displayed afterwards.
Change-Id: Ib4e7a34f3b19db89280cc73053acbac8c8816f85
Closes-Bug: #1669683
Since pbr already landed and the old version of hacking seems not
work very well with pbr>=2, we should update it to match global
requirement.
Partial-Bug: #1668848
Change-Id: Idc1755ccd8d477ffd1ff0febf586238249f45c60
This is a follow up patch, that adds a release note
about cell_name argument deprecation for migration-list
Change-Id: Ia3c21c7697e2c64025d35c23ed32fecff9c076df
Related-bug: #1668743
Change adf7d1e48c619579c2fc430229173264db45033e removed the
deprecated network proxy CLIs but missed a couple of functional
tests. These were caught because the mitaka functional job runs
nova-network which actually runs these tests, but is non-voting.
The functional jobs that run on master are using neutron and skip
these tests.
Change-Id: I5f66905a315cb36f094e30e673629893cf4bdc49
Closes-Bug: #1669043
This patch adds deprecation warning for usage of
cell_name argument in migration_list command.
Change-Id: I54468682d5391668a513e708e26bc3c165c95ca1
Related-bug: #1668743
The following warning is emitted for every nova command using devstack,
stable/ocata.
site-packages/novaclient/client.py:278:
UserWarning: The 'tenant_id' argument is deprecated in Ocata and
its use may result in errors in future releases. As 'project_id'
is provided, the 'tenant_id' argument will be ignored.
See the following commit for related changes:
Clarify meaning of project_id var
9bbe5a87b7df62a7962debba5db7c96555da6761
Change-Id: Ifa5ed16f10a43c9961e98b03fc0535e12d7977ba
In Newton we deprecated the various network-related resource
commands which were either for nova-network or were proxy
APIs to Neutron, because of the 2.36 microversion which deprecated
those APIs.
This removes the deprecated commands. Because of the size of this
change, the deprecated python API binding removals will come in a
separate change.
Change-Id: I6ecca49e7208f9dc0969bf377930a729c4b407b8
We deprecated the image proxy commands and APIs in Newton
due to the 2.36 microversion. We said after Ocata 15.0.0 we
would remove these, which we can do now in Pike.
Note that the list() method on the ImageManager has to be
moved to the GlanceManager since we still need to list images
for the --image-with option on the boot command. The _match_image
method in the shell has to be updated for a glance v2 response
where custom metadata properties are flat in the image body.
This needs to be released with a major version bump.
Change-Id: I2d9fd0243d42538bd1417a42357c17b09368d2a5
We have no functional testing for creating a server
using the --image-with option, which is going to be
impacted when we remove our deprecated code for the
image proxy API in Nova.
This adds a functional test for that flow which
creates a server, snapshots the server with a meta
key/value, then creates a second server using
--image-with and specifying the same meta key/value
set on the snapshot image.
Change-Id: I30017380d3e8dba6f1a50dfdda5eb4802b498bb4
There was a change in the openstacksdk 0.9.11 which
python-openstackclient uses to create networks in a devstack
run with Neutron. Because of this change, the admin tenant
has access to both the 'public' and 'private' network setup
in devstack which before used to just be the 'public' network,
which exposed a bug in the novaclient functional testing where
the admin user is attempting to create a server but not
specify a specific network to use, but multiple networks
are available to the admin (it can list multiple networks).
In this case the networks are the standard public and private
networks that are created in devstack. Since a network isn't
specified when creating the server, the nova API fails with a
409 error because it can't determine which network to use.
This patch fixes the testing in novaclient by checking to see
if there are multiple networks available and if so, specifies
one for the legacy BDM tests that weren't specifying a network
ID (those tests don't really care about the networking).
The auto-network test is skipped if there are multiple networks
available because passing in a specific network would defeat
the purpose of that test.
Change-Id: I22ee148581a94b153cf7e733563cfafaa56b1ffd
Closes-Bug: #1654806
In case of token authentication is used pass relevant parameters
to Token authenticator.
Co-Authored-By: Andrey Kurilin <andr.kurilin@gmail.com>
Change-Id: I9a04d89016a834fe96f1b77e91011f7fa4fdda51
Closes-Bug: #1654183
In the recent release of keystoneauth1 2.18.0 provision is made to log
x-openstack-request-id for session client. Once this new library is synced
in openstack projects, the x-openstack-request-id will be logged twice
on the console if session client is used.
For example,
$ nova --debug list
DEBUG (session:640) GET call to compute for
http://10.232.48.204:8774/v2.1/servers/detail used request id
req-b6aeff56-0408-44ed-80ba-cd7b950a8f21
DEBUG (client:85) GET call to compute for
http://10.232.48.204:8774/v2.1/servers/detail used request id
req-b6aeff56-0408-44ed-80ba-cd7b950a8f21
Above log will be logged twice on the console.
Removed logging of x-openstack-request-id in case of SessionClient as it
is already logged in keystoneauth1.
Depends-On: I492b331ff3da8d0b91178bf0d5fe1d3702f15bd7
Closes-Bug: #1657351
Change-Id: I9ba6a9e498fbcb027f45499d27ece966c52580ba
To be able to create profiling traces for Nova, client should be
able to send special HTTP header that contains trace info.
This patch is also important to be able to make cross project
traces. (Typical case heat calls nova via python client, if
profiler is initialized in heat, nova client will add extra
header, that will be parsed by special osprofiler middleware in nova
api.)
Security considerations: trace information is signed by one of the
HMAC keys that are set in nova.conf. So only person who knows HMAC key
is able to send proper header.
oslo-spec: https://review.openstack.org/#/c/103825/
Based on: https://review.openstack.org/#/c/105089/
Co-Authored-By: Dina Belova <dbelova@mirantis.com>
Co-Authored-By: Roman Podoliaka <rpodolyaka@mirantis.com>
Co-Authored-By: Tovin Seven <vinhnt@vn.fujitsu.com>
Partially implements: blueprint osprofiler-support-in-nova
Depends-On: I82d2badc8c1fcec27c3fce7c3c20e0f3b76414f1
Change-Id: I56ce4b547230e475854994c9d2249ef90e5b656c
Some help strings miss spaces and thus get displayed like "willbe" or
"biggerthan" - add missing spaces.
Change-Id: I560738dd46b3088a6e528a1a24fb2dbea495dcc7
Heat wants to use 'novaclient.v2.servers.
ServerManager._console' method to simplify the
implementation of retrieving server console.
It's better to change the method to public for
public use.
The patch changes:
1. add public method named get_console_url() for class
'novaclient.v2.servers.Server'
2. rename _console() to get_console_url() for class
'novaclient.v2.servers.ServerManager'
Change-Id: I3d1485468d1d0a79d4002981ebe05b6cdf2332e7
Closes-Bug: #1651677
Our users always want to add/remove multiple tags easily, but currently we
can only add/remove a single tag to a server via Nova CLI. This patch
allows user to add or delete server tags in one hit.
Change-Id: I4dc6e5cb30b99857970965cd180e116afba1fc7d
Currently, the coverage test job doesn't provide any test result
to developer, we could enable coverage report in console output
to let the developer know the coverage status when running coverage
test job.
Change-Id: I12764de112e948129e21732faae03562649522fc
This adds support for the v2.41 microversion which returns
the aggregate uuid in os-aggregates responses. With this
change, CLI requests with microversion >= 2.41 will show
the aggregate UUID in the table output.
Depends-On: I4112ccd508eb85403933fec8b52efd468e866772
Part of blueprint return-uuid-from-os-aggregates-api
Change-Id: I71aeec07c7c442fe82e2bb3f75f49de6ced22e77
