image functions deprecated after v2.35 but we didn't pin the
version for them, so when use 2.37 by default won't work.
https://review.openstack.org/#/c/392523/ fixed others but
unfortunately list function is missing
test_readonly_nova.py was removed as it's only for 2.35 check
while through this patch, >2.35 can be used
Change-Id: Ia1157dcb68971c5f64f7ab068fc647f25cd265e4
Related-Bug: 1638506
Closes-Bug: 1650617
This max limit config option was moved to the api group in
Ida4ee57d6e1822e35e3198f6d3a89410e211d57d. Update the command line help
to reflect those changes.
Change-Id: I171940443918329b2c987b507f354d33b7e7db0c
1.As mentioned in [1], we should avoid using
six.iteritems to achieve iterators. We can
use dict.items instead, as it will return
iterators in PY3 as well. And dict.items/keys
will more readable. 2.In py2, the performance
about list should be negligible, see the link [2].
[1] https://wiki.openstack.org/wiki/Python3
[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html
Change-Id: I6289f46344876d19d9a6793875f896cedc85a01c
The Nova API allows user filter flavors by minDisk and minRam,
but that is not implemented in the current novaclient yet.
This patch introduce '--min-disk' and '--min-ram' options to support
it. In addition, We also append '--sort-key' and '--sort-dir' to
the flavor-list subcommand to support sort the result list.
Change-Id: I3849cc2d73057170dc224fa86b724f5141ca9a23
Closes-Bug: #1647867
The following files have been removed in
I09a6501603667350f49b1b1fa130353a6d5272a2.
* novaclient/v2/volume_types.py
* novaclient/v2/volume_snapshots.py
But doc/source/conf.py has not been fixed.
So fix it.
And return parameter format in novaclient/v2/hosts.py
is fixed.
Change-Id: Icd3c5aed776df291141b8c3df4d64aa234e4ed88
Closes-Bug: #1648007
When booting instance with block_device_mapping provided,
in the current implementation, the "destination_type" is
allowed to be None, and this lead to un-sync between Nova
and Cinder: Nova will have a bdm in its record while the
volume is still in "available" status in cinder.
Also we should check source_type here
This patch adds a check for source_type and
destination_type, source_type shoud be within
'volume', 'image', 'snapshot' or 'blank';
When empty destination_type is provided, it
will be assigned to an default value according
to source_type, if it is provided with a wrong
value, command error will raise and information
will shown.
Change-Id: If6c7d8ed58a94d262ac6c300e75aca4cdf99ff1d
partial-bug: #1644725
novaclient can't process the resource if the name is 'help',
like 'nova show help', 'nova flavor-show help', 'nova delete help',
etc. We should encourage user to use 'nova help xxxx' to show
subcommand usage, rather than 'nova xxxx help`.
Change-Id: I65204a908dc2378b6264297ddd87fcb8912a5770
Closes-Bug: #1641048
I changed asserts with more specific assert methods.
e.g.: from assertTrue(sth == None) to assertIsNone(*) or
assertTrue(isinstance(inst, type)) to assertIsInstace(inst, type) or
assertTrue(not sth) to assertFalse(sth).
The code gets more readable, and a better description will be shown on fail.
Change-Id: I8be876e0d2a1ea5d6f8454ca973e2d874d10283d
This reverts commit f47393dbbfbf36616a8d28348d93e1368763b8c3.
The 2.39 microversion has not been merged in Nova, and this
change is missing a functional test to show the support added
here, which if present would have required a depends-on to the
Nova change for the 2.39 support. So this needs to come back
out until it's ready.
Change-Id: I6b6990b9a4e1e7cfea1d2aabe5f2464614440360
Optional parameters 'limit' and 'marker' were added to the GET
/os-simple-tenant-usage and GET os-simple-tenant-usage/{tenant_id}
endpoints.
/os-simple-tenant-usage?limit={limit}&marker={instance_uuid}
/os-simple-tenant-usage/{tenant_id}?limit={limit}&marker={instance_uuid}
Implements blueprint paginate-simple-tenant-usage
Change-Id: I9e96d31ede323f1c2aed4271a4fcab720cc9507b
All extensions from novaclient.v2.contrib should be not be extensions in
case of api version >=2.0;<=3.0 (historically, they are turned on by default
for cli layer), so let's move it from contrib dir and turn on by default.
Change-Id: I4ef4e44cf970947dad33110ce658a133e4f2893e
This is basically a copy of the template used in oslo.messaging
under change 78f113780510b741bc974c69eb9b0718cd657c1d.
Change-Id: I8be883215f27abb58d15b85e8542cbdf32000bac
The keypair, hypervisor, and flavor CLIs all incorrectly say that they
support a special -1 case for the 'limit' parameter. I suspect this was
just copied from the servers help text by mistake.
Change-Id: I57fb3444d54232f0718424c00c07a28b29473d19
Closes-Bug: #1645489
The 'load_entry_point' method has not been used
since Ia649db257c416ca054977812ecb3f1a8044fa584.
TrivialFix
Change-Id: If477b0bb753c1a8bed2ebb440ac43f55805a0744
Server id should be always str type not int, but currently in our unit test,
we still use int type. It may harmless in current test cases, but **there's a
potential danger** in future. For example, we may compare server id in our
code, in our test will be 1234 == "1234" which certainly return false but it's
not our expected result and yields a false positive. it trouble me a lot to run
unit test to solve 'bp show-server-all-tenants'. I re-check many times and
completely certain work well but fail to unit test. Honestly I almost couldn't
find any advantage to use int type. So I think the id should be change to str
in fake servers to fit real server uuid type.
Change-Id: I6b27d9c1629656dcc9b18497187c79ca96f6cd67
Closes-Bug: #1642113
The description of service.list is unprecise.
The service.list gets a list of services,
not to get cpu/memory/hdd info for host.
Change-Id: If5994be2f9e67766f7e2a9d786c32f0569b16b3c
image functions deprecated after v2.35 but we didn't pin the
version for them, so when use 2.37 by default won't work.
Change-Id: I450917f7fcbfe0a3ea7921c82af9863e80cb40a1
Closes-Bug: 1638506
Commit 984d00919ffe5ac5d41edb194740f6f33ca3e78f in nova added
microversion 2.38: "Return HTTP 400 on list for invalid status". This
microversion doesn't otherwise require changes in python-novaclient.
Change-Id: Ia1afe22130258b0efc7f869230ce45a43f8dc60e
Now that there is a passing gate job, we can claim
support for Python 3.5 in the classifier.
This patch also adds the convenience py35 venv.
Change-Id: Ic80a40692726b05f0f9d174f6ba7e7040f30db38
The support for non-keystone auth systems and plugins
was deprecated with 1f11840dd84f3570330d1fcd53d1e8eea5ff7922
back in the 3.1.0 release in mitaka.
Now that we're working on shoring up the support for
keystone auth sessions in the client and eventually moving
to remove support for the non-session HTTPClient, we should
also remove the support to load non-keystone auth plugins.
The whole concept of non-keystone auth systems/plugins is
a legacy artifact and is a barrier to interoperability which
is a goal of nova and OpenStack in general.
Change-Id: Ia649db257c416ca054977812ecb3f1a8044fa584
