openstack
/
python-octaviaclient
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review+2

(1 comment)

Patch-set: 2
Label: Code-Review=+2, 2fc7695162b68a7f52348086623328240c23d5e9
This commit is contained in:
Gerrit User 34429 2023-09-25 12:42:53 +00:00 committed by Gerrit Code Review
parent 173ea25672
commit abd082965a
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
ef954db9ac29daa91ff9410c9ae657818bc3b3da
View File

@ -16,6 +16,23 @@
"message": "Thanks for this optimization. I read the discussion about this on IRC and it seems the actual problem here is not that octaviaclient sets these values to False, but that users do a pip install without defining the version that matches with the Zed release. Users will still see the new HSTS fields in the client\u0027s help page and will still be able to set these flags and provoke API errors as seen, so this seems to be a workaround only.\n\nSo, I wonder if it\u0027s not better to simply tell users to install the correct version for Zed, ie. to do a `pip install python-octaviaclient\u003c3.3.0`.",
"revId": "ef954db9ac29daa91ff9410c9ae657818bc3b3da",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "146de83c_edfef85f",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 34429
},
"writtenOn": "2023-09-25T12:42:53Z",
"side": 1,
"message": "+2 although I wouldn\u0027t even consider this a bug.",
"revId": "ef954db9ac29daa91ff9410c9ae657818bc3b3da",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}