openstack/python-openstackclient
Code Issues Proposed changes

Refactor module functional test

Browse Source 
Combine "test_module_list_no_options" and "test_module_list_with_all_option"
into one test, and modify the test for "--all' option.

Change-Id: If4e7a73502a888c50de17ec19ef7e8d02dd23f1d
This commit is contained in:
zhiyong.dai
2016-11-27 21:07:34 +08:00
parent 46d1df0adf
commit 3258664c7a
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
openstackclient/tests/functional/common/test_module.py
View File

@@ -29,12 +29,15 @@ class ModuleTest(base.TestCase):
'os_client_config',
'keystoneauth1']
def test_module_list_no_options(self):
json_output = json.loads(self.openstack('module list -f json'))
def test_module_list(self):
# Test module list
cmd_output = json.loads(self.openstack('module list -f json'))
for one_module in self.CLIENTS:
self.assertIn(one_module, json_output.keys())
self.assertIn(one_module, cmd_output.keys())
for one_module in self.LIBS:
self.assertNotIn(one_module, cmd_output.keys())
def test_module_list_with_all_option(self):
json_output = json.loads(self.openstack('module list --all -f json'))
for one_module in (self.CLIENTS + self.LIBS):
self.assertIn(one_module, json_output.keys())
# Test module list --all
cmd_output = json.loads(self.openstack('module list --all -f json'))
for one_module in self.CLIENTS + self.LIBS:
self.assertIn(one_module, cmd_output.keys())