openstack/python-openstackclient
Code Issues Proposed changes

volume: fix volume service set call

Browse Source 
The command line operation could never work due to the incorrect call of
the openstacksdk API. This is updated to make it work and report errors
back to the user.

Closes-Bug: #2116969
Change-Id: I87cc410853c03b00dd1549d67cb1b9a8145bcfaa
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
This commit is contained in:
Doug Goldstein
2025-07-15 13:20:44 -05:00
parent ffa37bab12
commit 51ecb5f984
3 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
openstackclient/volume/v2/service.py
View File

@@ -126,7 +126,7 @@ class SetService(command.Command):
volume_client = self.app.client_manager.sdk_connection.volume volume_client = self.app.client_manager.sdk_connection.volume
service = volume_client.find_service( service = volume_client.find_service(
host=parsed_args.host, service=parsed_args.service parsed_args.service, ignore_missing=False, host=parsed_args.host
) )
if parsed_args.enable: if parsed_args.enable:

2
openstackclient/volume/v3/service.py
View File

@@ -133,7 +133,7 @@ class SetService(command.Command):
volume_client = self.app.client_manager.sdk_connection.volume volume_client = self.app.client_manager.sdk_connection.volume
service = volume_client.find_service( service = volume_client.find_service(
host=parsed_args.host, service=parsed_args.service parsed_args.service, ignore_missing=False, host=parsed_args.host
) )
if parsed_args.enable: if parsed_args.enable:

5
releasenotes/notes/volume-service-set-fix-345a8bc84267f743.yaml Normal file
View File

@@ -0,0 +1,5 @@
---
fixes:
- |
The 'volume service set' command could not work due to a bad API call.
[Bug `2116969 <https://bugs.launchpad.net/bugs/2116969>`_]