openstack/python-openstackclient
Code Issues Proposed changes

Merge "Use assertRaises() to check if an exception is raised"

Browse Source
This commit is contained in:
Jenkins 2016-02-15 17:14:42 +00:00 committed by Gerrit Code Review
commit 5543857381
3 changed files with 19 additions and 29 deletions
openstackclient/tests
compute/v2
test_server.py
network/v2
test_network.pytest_router.py

9
openstackclient/tests/compute/v2/test_server.py

@ -143,11 +143,10 @@ class TestServerCreate(TestServer):
verifylist = [
('server_name', self.new_server.name),
]
try:
# Missing required args should bail here
self.check_parser(self.cmd, arglist, verifylist)
except utils.ParserException:
pass
# Missing required args should bail here
self.assertRaises(utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
def test_server_create_minimal(self):
arglist = [

16
openstackclient/tests/network/v2/test_network.py

@ -106,11 +106,9 @@ class TestCreateNetworkIdentityV3(TestNetwork):
arglist = []
verifylist = []
try:
# Missing required args should bail here
self.check_parser(self.cmd, arglist, verifylist)
except tests_utils.ParserException:
pass
# Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
def test_create_default_options(self):
arglist = [
@ -545,11 +543,9 @@ class TestShowNetwork(TestNetwork):
arglist = []
verifylist = []
try:
# Missing required args should bail here
self.check_parser(self.cmd, arglist, verifylist)
except tests_utils.ParserException:
pass
# Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
def test_show_all_options(self):
arglist = [

23
openstackclient/tests/network/v2/test_router.py

@ -63,10 +63,9 @@ class TestCreateRouter(TestRouter):
arglist = []
verifylist = []
try:
self.check_parser(self.cmd, arglist, verifylist)
except tests_utils.ParserException:
pass
# Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
def test_create_default_options(self):
arglist = [
@ -303,11 +302,9 @@ class TestSetRouter(TestRouter):
('distributed', False),
]
try:
# Argument parse failing should bail here
self.check_parser(self.cmd, arglist, verifylist)
except tests_utils.ParserException:
pass
# Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
def test_set_nothing(self):
arglist = [self._router.name, ]
@ -353,11 +350,9 @@ class TestShowRouter(TestRouter):
arglist = []
verifylist = []
try:
# Missing required args should bail here
self.check_parser(self.cmd, arglist, verifylist)
except tests_utils.ParserException:
pass
# Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
def test_show_all_options(self):
arglist = [