openstack/python-openstackclient
Code Issues Proposed changes

Add support for showing limits of a specific project

Browse Source 
Looks like the option to show limits of a specific project was
missing. This resulted in always using the authenticated project.

Change-Id: I512a05df20860ffb52af34f3b64c9eb81dae8c61
Closes-Bug: 1438379
This commit is contained in:
Steve Martinelli 2015-04-03 02:26:22 -04:00
parent d5f2c50c0f
commit 77e3fbae1a
2 changed files with 38 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
doc/source/command-objects/limits.rst
View File

@ -16,6 +16,8 @@ Show compute and volume limits
os limits show
--absolute [--reserved] | --rate
[--project <project>]
[--domain <domain>]
.. option:: --absolute
@ -28,3 +30,11 @@ Show compute and volume limits
.. option:: --reserved
Include reservations count [only valid with :option:`--absolute`]
.. option:: --project <project>
Show limits for a specific project (name or ID) [only valid with --absolute]
.. option:: --domain <domain>
Domain that owns --project (name or ID) [only valid with --absolute]

29
openstackclient/common/limits.py
View File

@ -21,6 +21,7 @@ import logging
from cliff import lister
from openstackclient.common import utils
from openstackclient.identity import common as identity_common
class ShowLimits(lister.Lister):
@ -49,6 +50,18 @@ class ShowLimits(lister.Lister):
action="store_true",
default=False,
help="Include reservations count [only valid with --absolute]")
parser.add_argument(
'--project',
metavar='<project>',
help='Show limits for a specific project (name or ID)'
' [only valid with --absolute]',
)
parser.add_argument(
'--domain',
metavar='<domain>',
help='Domain that owns --project (name or ID)'
' [only valid with --absolute]',
)
return parser
def take_action(self, parsed_args):
@ -57,7 +70,21 @@ class ShowLimits(lister.Lister):
compute_client = self.app.client_manager.compute
volume_client = self.app.client_manager.volume
compute_limits = compute_client.limits.get(parsed_args.is_reserved)
project_id = None
if parsed_args.project is not None:
identity_client = self.app.client_manager.identity
if parsed_args.domain is not None:
domain = identity_common.find_domain(identity_client,
parsed_args.domain)
project_id = utils.find_resource(identity_client.projects,
parsed_args.project,
domain_id=domain.id).id
else:
project_id = utils.find_resource(identity_client.projects,
parsed_args.project).id
compute_limits = compute_client.limits.get(parsed_args.is_reserved,
tenant_id=project_id)
volume_limits = volume_client.limits.get()
if parsed_args.is_absolute: