openstack/python-openstackclient
Code Issues Proposed changes

Fix port command for SDK >0.9.10

Browse Source 
The port functional test can not be passed in my local environment.
When 'dns_assignment' is None, the port create, show command will
fail because parameter for 'utils.format_list_of_dicts' can not be
None.

Change-Id: Iebf16fb7ca681660c2b9ee7839a0629f38c6a38a
This commit is contained in:
jiahui.qiang
2017-01-09 10:43:27 +08:00
parent 4d3cfb9142
commit 8e277c64fb
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
openstackclient/network/v2/port.py
View File

@@ -35,6 +35,10 @@ def _format_admin_state(state):
return 'UP' if state else 'DOWN'
def _format_dns_assignment(dns_assignment):
return utils.format_list_of_dicts(dns_assignment) \
if dns_assignment else None
_formatters = {
'admin_state_up': _format_admin_state,
'is_admin_state_up': _format_admin_state,
@@ -43,7 +47,7 @@ _formatters = {
'binding_vif_details': utils.format_dict,
'binding:profile': utils.format_dict,
'binding:vif_details': utils.format_dict,
'dns_assignment': utils.format_list_of_dicts,
'dns_assignment': _format_dns_assignment,
'extra_dhcp_opts': utils.format_list_of_dicts,
'fixed_ips': utils.format_list_of_dicts,
'security_group_ids': utils.format_list,