openstack/python-openstackclient
Code Issues Proposed changes

Merge "identity: in service set command, don't pass the enable option when it is None" into stable/2024.2

Browse Source
This commit is contained in:
Zuul
2024-10-02 17:26:48 +00:00
committed by Gerrit Code Review
parent 54b4f45829 25bc3bbc07
commit e648750a11
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
openstackclient/identity/v3/service.py
View File

@@ -225,7 +225,8 @@ class SetService(command.Command):
kwargs['name'] = parsed_args.name
if parsed_args.description:
kwargs['description'] = parsed_args.description
kwargs['is_enabled'] = parsed_args.is_enabled
if parsed_args.is_enabled is not None:
kwargs['is_enabled'] = parsed_args.is_enabled
identity_client.update_service(service.id, **kwargs)

3
openstackclient/tests/unit/identity/v3/test_service.py
View File

@@ -311,7 +311,6 @@ class TestServiceSet(identity_fakes.TestIdentityv3):
# Set expected values
kwargs = {
'type': self.service.type,
'is_enabled': None,
}
self.identity_sdk_client.update_service.assert_called_with(
self.service.id, **kwargs
@@ -338,7 +337,6 @@ class TestServiceSet(identity_fakes.TestIdentityv3):
# Set expected values
kwargs = {
'name': self.service.name,
'is_enabled': None,
}
self.identity_sdk_client.update_service.assert_called_with(
self.service.id, **kwargs
@@ -365,7 +363,6 @@ class TestServiceSet(identity_fakes.TestIdentityv3):
# Set expected values
kwargs = {
'description': self.service.description,
'is_enabled': None,
}
self.identity_sdk_client.update_service.assert_called_with(
self.service.id, **kwargs