390 Commits

Author SHA1 Message Date
Dean Troyer
d20c863ebc osc-lib: exceptions
Use osc-lib directly for exceptions.

Leave openstackclient.common.exceptions for deprecation period.

Change-Id: Iea3e862302372e1b31ccd27f69db59b4953ca828
2016-06-13 10:50:01 -05:00
Jenkins
84506a6b71 Merge "Fix compute service set command" 2016-06-08 05:03:47 +00:00
sunyajing
565499577f Fix compute service set command
add ``Binary name`` to help msg of compute service set command.

Change-Id: I5ed3824ec5bede250ce41f187835e8901b5e11fd
2016-06-08 03:07:16 +00:00
Jenkins
19c54b61c1 Merge "Refactor SetService --enable/disable option" 2016-06-06 21:56:55 +00:00
Jenkins
9504b7973e Merge "Add newline to strings in stdout/stderr.write()" 2016-06-06 13:06:47 +00:00
Jenkins
275753bacc Merge "fix keypair help msg" 2016-06-06 08:45:13 +00:00
sunyajing
5b317936cb fix keypair help msg
keypair delete and keypair show commands cannot work on keypair ID

Change-Id: I958fcd2ed184706b28d63cc9c73a8b566e86a16c
Closes-Bug:#1588701
2016-06-06 06:50:13 +00:00
Lu lei
54e81a9984 Add newline to strings in stdout/stderr.write()
Function stdout/stderr.write() can't break line automatically.

Change-Id: I903c2d1cc1a669adb6be5aa4eb783d3b9943e685
2016-06-06 13:54:55 +08:00
sunyajing
6de7bf0abc modify server group
make column_headers equal to columns, to keep code consistence

Change-Id: Ia96b398ad822fc5fac3753e28709c370165bda8a
2016-06-06 11:47:59 +08:00
Jenkins
93db7f58ed Merge "Support multiple argument for compute agent delete command" 2016-06-05 04:36:26 +00:00
Tang Chen
ac1d86c343 Refactor SetService --enable/disable option
This patch changes the following:

1. --enable/disable option should follow the rules
   in the doc below:
   http://docs.openstack.org/developer/python-openstackclient/command-options.html#boolean-options

2. "--disable-resion" is specified but not "--disable",
   an exception is raised instead of igoring
   "--disable-reason" option.

Change-Id: I92e9234111e661bfe7119a8e19389a87c874ab0c
2016-06-04 22:42:46 +08:00
Dean Troyer
eef2054109 Move server image create command to its own resource file.
Change-Id: If37e82072bd7a32b81bfb1a8bb048f018dd5b04f
2016-06-03 09:19:57 -05:00
Huanxuan Ao
95d5d9f761 Fix some missing i18n support problems in compute
Found and Fix some missing i18n support problems in compute/client.py

Change-Id: I54374f4eddafd9f80b6ccdaf8f8c30e098df105e
Partial-bug: #1574965
2016-06-03 12:15:22 +08:00
sunyajing
909bab1e07 Support multiple argument for compute agent delete command
Change-Id: I3b19e4914d475b86d7e8aa8d76e62a2ac811272f
Partially-Implements: blueprint multi-argument-compute
2016-06-03 02:14:36 +00:00
Jenkins
9f65a9954c Merge "Add support for removing flavor-access" 2016-06-02 18:14:48 +00:00
Huanxuan Ao
22c60f3ac7 Add support for removing flavor-access
Add "--project" and "--project-domain" options in
"flavor unset" command to remove flavor access.

Change-Id: Ia5c5a80d9890d5af066b75b4e202647c18c7d915
Partial-Bug: #1575461
2016-06-02 12:40:43 +08:00
Jenkins
21924f55b9 Merge "Fix output and error log in server.py" 2016-05-31 13:42:14 +00:00
Jenkins
4e44f1206f Merge "Add support for setting flavor-access" 2016-05-30 20:00:11 +00:00
Huanxuan Ao
c46a5597be Add support for setting flavor-access
This patch adds "--project" option in "flavor set" command to support
for setting flavor access.

Change-Id: I75b473600080d8ab1dd6ad01561c4f989ed3c3bd
Partial-Bug: #1575461
2016-05-30 16:26:09 +08:00
Jenkins
4822bf1f53 Merge "[compute] Add server backup function" 2016-05-30 04:28:07 +00:00
Rui Chen
1a7284f63a Support to set server state
When a server is unexpected state, OSC don't support reset
the server to active or error state, that's supported by
novaclient, and it's an important command for operators, the
patch implement this function.

Change-Id: I3e7800feb192832b0719ef9a353945beb6bfd509
Implements: blueprint server-reset-state
2016-05-28 18:55:50 +08:00
Tang Chen
97162ecd22 Fix output and error log in server.py
This patch fixes 2 problems:

1. The '\n' should be in the end of a message,
   not the beginning.

i.e.:
   The original code was:
       sys.stdout.write(_('\nError deleting server'))
   It will make the output look like this:

   [root@tangchen /]# openstack server delete aaa bbb

   Error deleting server
   Error deleting server[root@tangchen /]#

   We change it to:
       sys.stdout.write(_('Error deleting server\n'))
   Then the output will become:

   [root@tangchen /]# openstack server delete aaa bbb
   Error deleting server
   Error deleting server
   [root@tangchen /]#

   which is much better.

2. Record the error in log for those who didn't.

Change-Id: I38b00c2321014757970183205f95f026e20a8090
2016-05-28 15:46:32 +08:00
Huanxuan Ao
b2a0e633eb Fix help message for "server group delete" command
"Server group delete" command supported deleting multi server
groups, but the help message was "Delete an existing server
group", so I change it in this patch.

Change-Id: I05b1a7e3f29b84b9190e7cc05c01734e3daa7a6d
2016-05-28 13:21:39 +08:00
jichenjc
460846cef2 [compute] Add server backup function
Add server backup function

There is no return value for this command per following doc
http://developer.openstack.org/api-ref-compute-v2.1.html#createBackup,
also novaclient can't be updated now due to backward compatible issue
http://lists.openstack.org/pipermail/openstack-dev/2016-March/089376.html,
so we have to get the information ourselves.

The Image tests were not using warlock images, so that needed to be fixed
before we could completely test things like --wait.

Change-Id: I30159518c4d3fdec89f15963bda641a0b03962d1
2016-05-27 11:47:25 -05:00
Tang Chen
5398c96e2a Fix i18n support for help and error messages in compute
Change-Id: Id6eebcb48d1b7b49b6636524506294edbc44a83f
Partial-bug: #1574965
2016-05-24 11:03:49 +08:00
Jenkins
35ea7a9baa Merge "remove #noqa from i18n imports" 2016-05-19 09:08:57 +00:00
Jenkins
948c76b0a4 Merge "Support X.latest format for OS_COMPUTE_API_VERSION" 2016-05-16 22:57:28 +00:00
Steve Martinelli
ebcbd6ba71 remove #noqa from i18n imports
hacking checks no longer fail on `import _`

Change-Id: Idd60f0a0e71e5081691eacb39e5091ab08fcce6d
2016-05-13 13:14:02 -07:00
Jenkins
b60ff95edf Merge "Use find_resource() instead of get() in _prep_server_detail()" 2016-05-11 13:26:30 +00:00
Tang Chen
d58280a279 Use find_resource() instead of get() in _prep_server_detail()
There is such a comment in test_server.py:

    # Call .get() to retrieve all of the server information
    # as findall(name=blah) and REST /details are not the same
    # and do not return flavor and image information.

This is an out of date comment. There is no function named
findall() in OSC now. So use find_resource() instead of get(),
and remove this comment.

Change-Id: I8d79afc5f341fb5caf771d905506b7f1c7a41ae8
2016-05-09 14:59:39 +08:00
Tang Chen
809239ca1e Map server power state num to meanful string
In _prep_server_detail(), power_state is not formatted
by _format_servers_list_power_state(). So when executing
"server show" or "server create", the power state is
represented by number. This patch map the numbers to
meanful strings.

This patch also adds power_state attribute to FakeServer,
and improves unit tests for this attribute.

Change-Id: I2ec674327de4e5133b8712ba6bb53fa5ce55e3f4
2016-05-07 14:54:44 +08:00
Huanxuan Ao
681d6dc2de Make "flavor show" command to show a private flavor properly
The "flavor show" command could not show a
private flavor by flavor name becauce it could
not find a private flavor by flavor name.
In "until.find_resource(parsed_args.flavor)",
If parsed_args.falvor is a name of a flavor,
"flavors.find(name=parsed_args.flavor)"will be
called to find a flavor.But the default value of
"is_public" is "Ture" in "flavors.find()" so that
we can only find public flavors.If we want to find
all flaovrs by flavor name,we should add
"is_public=None" in "flavors.find()".

So I tried to change
"until.find_resource(parsed_args.flavor)" to
"until.find_resource(parsed_args.flavor, is_public=None)",
but then I could not find any flavor by flavor id
because "is_public" is an unexpected argument of
"flavors.get()" in "until.find_resource()".

In this case,I think "until.find_resource()"
can not find a private flavor properly,and
we should combine "manager.get(flavor.id)" and
"manager.find(name=flavor.name, is_public=None)"
by ourselve to find a flavor.

Also,this bug affects other flavor commands like
"flavor set/unset/delete",so I fix them in this patch too.

Change-Id: I4a4ed7b0a2f522ee04d1c3270afcda7064285c39
Closes-Bug: #1575478
2016-05-02 16:47:53 +08:00
Huanxuan Ao
4524b3605f Fix error in flavor set/unset command
In the "flavor set/unset" command,the "flavor" parameter
can be a name but can not be a id of a flavor.
I think we should find a flavor by using "utils.find_resource()"
in these commands.

Change-Id: I5836788f7ed18813f1ebde31bb808b7c3f932b80
Closes-Bug: #1575624
2016-04-28 19:59:53 +08:00
Rui Chen
a0d79968ca Add "server group show" command
Support compute v2 "server group show" command in OSC.

Implements: blueprint nova-server-group-support
Closes-Bug: #1542171

Change-Id: I1a6d103151c704bda5b67cb9a49cc43c7d9f1d6a
2016-04-20 03:26:13 +00:00
Rui Chen
4e22728013 Add "server group list" command
Support compute v2 "server group list" command in OSC.

Implements: blueprint nova-server-group-support
Partial-Bug: #1542171

Change-Id: I68b80e3c4458692472af671028cd1f939736bcb8
2016-04-20 03:25:57 +00:00
Rui Chen
7458c612ed Add "server group delete" command
Support compute v2 "server group delete" command in OSC.

Implements: blueprint nova-server-group-support
Partial-Bug: #1542171
Related-Bug: #1563301

Change-Id: I7d792d669b147b24dc774844cfc9dbacd60d017b
2016-04-20 03:25:38 +00:00
Rui Chen
a06bb28bcc Add "server group create" command
Support compute v2 "server group create" command in OSC.

Implements: blueprint nova-server-group-support
Partial-Bug: #1542171

Change-Id: I96ffb07764d3adb715e048943cfee3b879c280f6
2016-04-20 03:24:58 +00:00
Rui Chen
a5a343a5a8 Support X.latest format for OS_COMPUTE_API_VERSION
OSC don't support to use "X.latest" format in order to talk with the
latest nova microversion API, that is very helpful shortcut usage to
use new nova side features, this patch implement it.

Change-Id: I87918addff1f50fbc6eb72ca82b31813330753b5
Closes-Bug: #1561838
2016-04-20 03:24:47 +00:00
Tang Chen
32c627eaf0 Doc: Unify repeatable option comments
There are lots of "this option can be repeated" comments
in the doc, which are not consistent to other similar
docs.

This patch changes them to the following format:

"repeat option to do something"

Change-Id: I54e01053091c428bf87bb36bb95f73a0b80ab6e7
2016-04-12 15:57:17 +08:00
Jenkins
cb8f757779 Merge "Refactor security group rule list to use SDK" 2016-04-11 03:01:13 +00:00
Rui Chen
4d3f996e7c Log hint when --enable present with --disable-reason
--enable and --disable-reason should be mutually exclusive in "compute
service set" command, but now when they are present at the same time,
--disable-reason would be ignored silently. Fix these and add some hints
about --disable-reason argument is ignored in this situation.

Change-Id: I43254b6bc40fcae4fd0dc3457f26fad84c267072
Closes-Bug: #1556801
2016-04-05 21:22:27 +08:00
Sean Dague
97492c168f rxtx factor should be a float
The rxtx factor on compute flavors is a float in the API. OSC is
currently blocking float values.

Change-Id: Ifa9c14825f388d2821ff4b63ab8ae83fa9c8d88b
2016-04-04 16:18:31 -04:00
Jenkins
01b2a0c49f Merge "Add "aggregate unset" to osc" 2016-03-30 23:21:37 +00:00
Sheel Rana
63c57eb56e Wrong param type in compute-service.rst
compute-service.rst file uses 'describe' for below
optional parameters

1. --long
2. --service <service>
3. --host <host>

This patchset changes type of these argument to option.

Change-Id: Ifd57bdf058efaeaa6cb43a7d4a60ee61ddb8de14
Closes-bug:#1563700
2016-03-30 14:45:41 +00:00
Richard Theis
c5b58a47b0 Refactor security group rule list to use SDK
Refactored the 'os security group rule list' command to use the
SDK when neutron is enabled, but continue to use the nova client
when nova network is enabled.

In addition, a release note was added to document the features
and fixes resulting from this refactor.

Change-Id: I24d04b720102ed1c60776e1ca67d4ca20e31b663
Partial-Bug: #1519512
Implements: blueprint neutron-client
2016-03-28 12:25:51 -05:00
Jenkins
d5596862b1 Merge "Refactor security group rule create to use SDK" 2016-03-28 09:16:23 +00:00
Rui Chen
4cbcd02a57 Add "aggregate unset" to osc
Support "aggregate unset" command in order to
remove the property of aggregate object in OSC.

Change-Id: I49645135586362f0fd251f5e4a4c03eff273d9e9
Closes-Bug: #1559866
2016-03-24 10:33:23 +08:00
Tang Chen
860dbc132d [Floating IP] Neutron support for "ip floating create" command
This patch adds --subnet, --port, --floating-ip-address
and --fixed-ip-address options only. Project related options
will be added in another patch because it relates to identity
v2 and v3, which will make the unit tests too complicated in
one single patch.

Change-Id: I3cce4404a114ff128b74e4596f0e847be2846b17
Partial-Bug: 1519502
Related-to: blueprint neutron-client
2016-03-24 09:07:25 +08:00
Richard Theis
d906507962 Refactor security group rule create to use SDK
Refactored the 'os security group rule create' command to use the
SDK when neutron is enabled, but continue to use the nova client
when nova network is enabled.

Added a release note for the change in security group rules output
due to Network v2.

Change-Id: I8c6c99d5272ff5d410a449f73d198d834c5cd96e
Partial-Bug: #1519512
Implements: blueprint neutron-client
2016-03-23 09:56:01 -05:00
Rui Chen
ee621509be Fix "server unset" document issue
Fix "--property" option describe issue in "server unset"
document, and update the help message to keep consistent.

Change-Id: I68022a187e83fad6320365400ad2a1b0c8cf9a61
2016-03-23 14:45:04 +08:00