1501 Commits

Author SHA1 Message Date
Jenkins
c8e4a1407f Merge "Add --reason for disable service" 2016-03-09 07:12:51 +00:00
jichenjc
b711c3a0ca Add --reason for disable service
disbale service allow a reason to be input as disable reason.
This patch add support for it.

Change-Id: I59622c3970e055ebd46bf03c33c864b6d064db28
2016-03-09 05:19:41 +00:00
Jas
e0d58641bb Add 'port set' command
Add CLI support for the 'port set' command

Change-Id: I2bea508e11290284aa64b1ab548a0bb61e7290d3
Partial-bug: #1519909
Partially-implements: blueprint neutron-client
2016-03-08 09:48:50 -06:00
Jenkins
9ab7740dfd Merge "Trivial: Fix incorrect comments in compute fakes.py" 2016-03-08 15:15:41 +00:00
Tang Chen
11c253ca19 Trivial: Fix incorrect comments in compute fakes.py
Change-Id: I18b1720af13b444527dda1ecab52e3cc8d8d9376
2016-03-08 20:48:58 +08:00
Tang Chen
762c4c9bdf [Identity] Check return value is None in identity v3 unit tests
take_action() in commands inheriting from Command returns nothing.
So we should assert the return is None in the unit tests of these
commands.

Change-Id: I02af06b3d476aac2d93a23ef2111cdc7fa0892ec
Partial-Bug: #1550636
2016-03-08 15:58:25 +08:00
Jenkins
752705ae30 Merge "Add port list command" 2016-03-08 03:04:28 +00:00
Jas
d548942645 Add port list command
This patch adds the ability to list all created ports

Change-Id: Ie1a48c203cabc96346a4950f21b83493d58a66a5
Partial-bug: #1519909
Partially-implements: blueprint neutron-client
2016-03-07 11:17:31 -06:00
Jenkins
13a6857142 Merge "Use _get_columns() to obtain columns in network.py" 2016-03-07 16:05:01 +00:00
Jenkins
dcc27fd5d3 Merge "Test take_action() instead of run() in unit tests" 2016-03-07 16:01:17 +00:00
Tang Chen
fc24f37ae2 Trivial: Remove useless return
If a function returns nothing, do not add return in the end.

Change-Id: I298b8717462f68d3076a1619d674775be2a94c42
2016-03-07 17:54:06 +08:00
Jenkins
67969e438c Merge "" openstack server image create " doesn't print proper info" 2016-03-06 08:33:44 +00:00
Tang Chen
7ba73845c1 Use _get_columns() to obtain columns in network.py
Objects returned by Network v2 and Compute v2 are different.
When getting columns to display, Network v2 uses obj.keys(),
while Compute v2 uses obj._info.keys(). But both of them could
obtain the keys of the object by _get_columns().

Change-Id: I347815f2d28822a95bd6f57d429b84b7ca96e0ee
2016-03-06 09:01:42 +08:00
Jenkins
0b2c4b1f32 Merge "Refactor security group set to use SDK" 2016-03-05 16:08:20 +00:00
Tang Chen
eb1574281b Test take_action() instead of run() in unit tests
Some of the unit tests test run(), but not take_action().

For example, in openstackclient/tests/volume/v1/test_volume.py, there is:

    def test_volume_set_size_smaller(self):
        ......

        result = self.cmd.run(parsed_args)

        self.assertEqual(0, result)
        ......

run() is defined in class Command in cliff. We don't need to test it in OSC
unit tests. On the contrary, we should test take_action(), which is
overwritten in each command classes in OSC.

Change-Id: If07e89953d40ac530f08cbb1ec05f5805171364b
Closes-bug: #1553468
2016-03-05 17:12:42 +08:00
Jenkins
fa3a34322c Merge "[compute] Support restore server" 2016-03-04 23:41:42 +00:00
Jenkins
a61c5cc8a4 Merge "Add 'port create' command" 2016-03-04 23:39:22 +00:00
Jenkins
5c1633f505 Merge "[compute] Add unit test for keypair" 2016-03-04 23:39:16 +00:00
Jenkins
0bf65361f5 Merge "[Volume] Check return value is None in volume unit tests" 2016-03-04 17:55:26 +00:00
Jas
d1d4a40808 Add 'port create' command
This patch adds usage of 'port create' in CLI

Change-Id: I888af50784c3b6c7ec30552ade79f05a5e974711
Partial-bug: #1519909
Partially-implements: blueprint neutron-client
2016-03-04 10:41:26 -06:00
Jenkins
d763acdf1c Merge "Add test cases to test some commands with '--wait' and fix bug" 2016-03-04 01:29:56 +00:00
Jenkins
5e11d24df8 Merge "Fix incorrect unit test for router" 2016-03-03 22:34:47 +00:00
Mohan Muppidi
e354d17d2c " openstack server image create " doesn't print proper info
After creating a snapshot of a running instance, a print out similar
to server create is expected, but it prints out something like "_info"
which is nothing related to created image. _prep_image_detail method
is added to /compute/v2/server.py to enable the priting, while running
the test properly.

Change-Id: I4b06be959768bcdaafd9aa8df497490958bee649
Closes-Bug:1551586
2016-03-03 21:03:14 +00:00
Tang Chen
b58dd4f17f [Volume] Check return value is None in volume unit tests
take_action() in commands inheriting from Command returns nothing.
So we should assert the return is None in the unit tests of these
commands.

Change-Id: Idd961a5fa3db825353700837a559621d17f782c5
Partial-Bug: #1550636
2016-03-03 21:07:08 +08:00
Tang Chen
50443127c5 Fix incorrect unit test for router
Command "router show" will display router's "tenant_id" as
"project_id". But in the unit test, it checks "tenant_id",
which is incorrect.

This patch fix this problem, and add a _get_columns() helper
function to simplify the code.

Change-Id: I0087ef7dfd0130b6c47222495848c4f2b9804b1b
2016-03-03 20:50:17 +08:00
Richard Theis
bac9fb18c1 Refactor security group set to use SDK
Refactored the 'os security group set' command to use the SDK
when neutron is enabled, but continue to use the nova client
when nova network is enabled.

This patch set also fixes a compute bug which ignores name
and description when set to an empty value.

Change-Id: I4225179dca4aedf799e1656ec49236bdedc5e9bd
Partial-Bug: #1519511
Implements: blueprint neutron-client
2016-03-03 06:33:15 -06:00
Jenkins
977eb4f1a6 Merge "Trivial: Reorder unit tests in alphabetical order in volume tests" 2016-03-03 05:00:36 +00:00
Jenkins
fc8b4cfcae Merge "[Image] Check return value is None in image unit tests." 2016-03-02 17:25:19 +00:00
Tang Chen
f2ef9f2044 Trivial: Reorder unit tests in alphabetical order in volume tests
Change-Id: I622123f68e2bb53f8767069e4a717fcc34e37b5c
2016-03-02 16:48:16 +08:00
Tang Chen
fd53a4980f [Image] Check return value is None in image unit tests.
take_action() in commands inheriting from Command returns nothing.
So we should assert the return is None in the unit tests of
these commands.

Change-Id: I237ea772f74fa52af2e9aacd35d4b9cfb225c94c
Partial-Bug: #1550636
2016-03-02 16:16:37 +08:00
Tang Chen
359dfa1a06 Support "network create" command in nova network
This patch only provide network name and subnet setting for
"network create" command.

The other options, such as --project which depends on
identity v2 or v3, will make the unit tests too complicated.
So I prefer to implement them in other patches.

Change-Id: I9ec93f0af813c8fae4170c36e16bbe8f0f53cbb6
Partial-Bug: 1543672
2016-03-02 14:39:00 +08:00
ting.wang
84942bb11c Add test cases to test some commands with '--wait' and fix bug
"server image create"
"server rebuild"
"server resize"
Above 3 commands are not covered by unit test.
So add some unit tests.

Meanwhile, fix bug. Now that image name is an optional argument,
we'd better record error messages with positional arguments
instead of optional argument. So, record server name.

Change-Id: I41bc025d4824dc46f63a3213d82e1528bacbbe12
2016-03-02 09:32:27 +08:00
Jenkins
77f2e98466 Merge "Clean up unnecessary import of urlparse module" 2016-03-01 23:51:00 +00:00
Jenkins
594d98431c Merge "Fix regression in interactive client mode" 2016-03-01 16:13:42 +00:00
Jenkins
2ae7072ea6 Merge "Trivial: Update image_list v2 docs" 2016-03-01 15:03:28 +00:00
Yang Hongyang
059f54eee4 Clean up unnecessary import of urlparse module
six.moves.urllib already covers the py2 and py3 compatibility issues
of urlparse module, use six.moves.urllib.parse.urlparse is enough.

Change-Id: I785f4f872850e5d770fdcf4c0d3392be3978cc4a
2016-03-01 22:06:53 +08:00
Yang Hongyang
8b17a1fa5b Trivial: Update image_list v2 docs
This api doc is clearly copied from v1, we should update it to reflact v2 API.
Added 'shared' param description.

Change-Id: I73d36e3a2a0448c28edab788a9340fd46177f8ef
2016-03-01 18:48:09 +08:00
Dina Belova
8a839ad8b8 Fix regression in interactive client mode
Fix typo introduced in OSprofiler intergation commit, that
leaded to non-working interactive mode of the CLI client.

Change-Id: If5dfc90dbbe64d4665c3e33e936f0cc674738351
Closes-Bug: 1551160
2016-03-01 13:45:19 +03:00
Jenkins
11490b79f4 Merge "TrivialOrder: Rearrange Class Names" 2016-03-01 10:09:07 +00:00
Jenkins
fa998d641d Merge "Fix return value of "image set" command" 2016-03-01 08:29:33 +00:00
Jenkins
d91e104670 Merge "Make SetAggregate inherit from cliff.Command" 2016-03-01 08:29:04 +00:00
Jenkins
53812170fe Merge "Trivial: Reorder flavor op order in flavor.py" 2016-03-01 07:40:48 +00:00
Jenkins
2ecbb738ef Merge "Refactor security group list to use SDK" 2016-03-01 07:18:10 +00:00
reedip
a1f2f4af58 TrivialOrder: Rearrange Class Names
As per the comment given by Steve Martinelli in
https://review.openstack.org/#/c/278209/ , the
following patch just rearranges the classes
as per the Alphabetical order.

TrivialFix

Change-Id: Ib8f0f703df4ef7d7ee6180ff8bd8a47062ae5b0f
2016-03-01 16:11:51 +09:00
Jenkins
0dfc50ea1c Merge "fix: Exception message includes unnecessary class args" 2016-03-01 07:03:17 +00:00
Jenkins
1299319b76 Merge "Subnet: Add "subnet delete" command using SDK" 2016-03-01 07:03:10 +00:00
Jenkins
7039cd3447 Merge "Make SetAgent inherit from cliff.Command" 2016-03-01 04:30:34 +00:00
Jenkins
3af46b1308 Merge "Trivial: Reorder unit tests in test_type.py" 2016-03-01 03:41:01 +00:00
Yang Hongyang
37c0e57d11 Trivial: Reorder flavor op order in flavor.py
Classes should be in alphabetical order.

Change-Id: I7a35c3a2dd6d36c49f0d54dec5c14609a9168bd0
2016-03-01 11:21:47 +08:00
reedip
88c92bf71a Subnet: Add "subnet delete" command using SDK
This patch adds "subnet delete" command to osc using sdk.

Change-Id: I6be27406b16909c6db2b95417355be302e218a8d
Implements: blueprint neutron-client
Closes-bug: #1542362
2016-03-01 11:26:27 +09:00