python-openstackclient/openstackclient
Akihiro Motoki 3cba09e767 Fix unit test failures related to new os-client-config and osc-lib
[breakage related to os-client-config 1.28.0]
os-client-config 1.28.0 add a check if filebased and envvars are
both used. This check causes OSC unit test failure.

OSC now instantiates OpenStackConfig twice as a workaround.
The unit test mocks _load_config_file() and it returns a config dict,
but os-client-config OpenStackConfig.__init__ updates the dict returned.
As a result, when OpenStackConfig is instantiated second time,
the mock of _load_config_file returns a modified version of the config
dict. This hits the new check in os-client-config 1.28.0.

This commit changes the mock to use side_effect rather than return_value
to ensure the original dict is used.

[breakage related to osc-lib 1.7.0]
The change in osc-lib 1.7.0 added "if" logic to avoid calling get() twice.
In tests.unit.volume.test_find_resource, kwargs is empty dict in find_resource(),
so the second call to get() is NOT called now.
Removing the second elements of side_effect addresses the unit failure.

Co-Authored-By: Rui Chen <chenrui.momo@gmail.com>
Change-Id: Ib9d14661b2755bbd6619e15c0d9023fbc9d27d70
Closes-Bug: #1703782
Closes-Bug: #1703783
2017-07-12 12:26:00 +00:00
..
api Allow objects to be streamed to stdout 2017-07-05 20:08:18 -03:00
common Add project purge command to osc 2017-06-13 10:26:35 -04:00
compute Merge "Create server with security group ID and name" 2017-05-22 23:09:02 +00:00
identity When creating a trust, send role_ids instead or role_names 2017-06-22 17:08:01 +00:00
image Added 'openstack image set --visibility' 2017-06-30 20:35:01 +00:00
locale Imported Translations from Zanata 2016-06-04 06:18:46 +00:00
network Add new parameter "is_default" to Network QoS policy. 2017-07-05 13:34:33 +00:00
object Allow objects to be streamed to stdout 2017-07-05 20:08:18 -03:00
tests Fix unit test failures related to new os-client-config and osc-lib 2017-07-12 12:26:00 +00:00
volume Replace "Display Name" by "Name" in volume list 2017-05-26 11:37:09 +08:00
__init__.py Change version reporting to use pbr 2013-08-02 12:11:49 -05:00
i18n.py Remove log translations 2017-03-21 17:23:09 +08:00
shell.py Improve no-auth path 2017-04-24 18:57:10 -05:00